pmbootstrap: pmb: Remind users to ensure pmbootstrap is updated before reporting errors v1 APPLIED

Newbyte: 1
 pmb: Remind users to ensure pmbootstrap is updated before reporting errors

 1 files changed, 2 insertions(+), 0 deletions(-)

Thanks for the patch, Newbyte!

Reviewed-by: Oliver Smith <ollieparanoid@postmarketos.org>

[PATCH pmbootstrap] pmb: Remind users to ensure pmbootstrap is updated before reporting errors Export this patch

---
 pmb/__init__.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/pmb/__init__.py b/pmb/__init__.py
index 18612e24..97bf1e5b 100644
--- a/pmb/__init__.py
+++ b/pmb/__init__.py
@@ -90,6 +90,8 @@ def main():
                          " get more output, e.g. 'pmbootstrap"
                          " --details-to-stdout init'.")
         print(log_hint)
+        print("Before you report this error, ensure that pmbootstrap is "
+              "up to date.")

Luca Weiss <luca@z3ntu.xyz>

1 year, 7 months ago

How about immediately printing the version number (pmb.__version__) and 
linking to the releases page?

https://gitlab.com/postmarketOS/pmbootstrap/-/releases

That way the user doesn't have to search for both but conveniently has both 
ready.

Oliver Smith <ollieparanoid@postmarketos.org>

1 year, 7 months ago

Good idea! This would be the right URL:
https://git.sr.ht/~postmarketos/pmbootstrap/refs

(It just shows git tags, the other URL is for gitlab.com releases which
are made by clicking buttons in the UI. We don't do that anymore for
quite some time as it is just extra effort.)

I'll add it before merge.

Regards
Luca

         return 1
 
 
-- 
2.40.1

Oliver Smith <ollieparanoid@postmarketos.org>

1 year, 7 months ago

Oliver Smith <ollieparanoid@postmarketos.org>

1 year, 7 months ago

Applied, thanks!

[1/1] pmb: Remind users to ensure pmbootstrap is updated before reporting errors
      commit: 40fc6f4fd4f0c9b5c112df12b5562f036f17f4fb

Best regards

builds.sr.ht <builds@sr.ht>

1 year, 7 months ago

pmbootstrap/patches/.build.yml: FAILED in 19m9s

[pmb: Remind users to ensure pmbootstrap is updated before reporting errors][0] from [Newbyte][1]

[0]: https://lists.sr.ht/~postmarketos/pmbootstrap-devel/patches/41304
[1]: mailto:newbyte@postmarketos.org

✗ #993229 FAILED pmbootstrap/patches/.build.yml https://builds.sr.ht/~postmarketos/job/993229