pmbootstrap: pmb.helpers.frontend: Convert kconfig check --file argument v1 APPLIED

Luca Weiss: 1
 pmb.helpers.frontend: Convert kconfig check --file argument

 2 files changed, 3 insertions(+), 3 deletions(-)

[PATCH pmbootstrap] pmb.helpers.frontend: Convert kconfig check --file argument Export this patch

Stop using --file as a boolean argument and just use the value behind
the argument as file to check. This also unbreaks this functionality
after the recent change now that args.package is a list since you can
pass multiple kernel packages as arguments.

Fixes: 41daa850 ("parse.arguments: Allow providing multiple packages for kconfig_check")
Closes: https://gitlab.com/postmarketOS/pmbootstrap/-/issues/2282

Oliver Smith <ollieparanoid@postmarketos.org>

1 year, 3 months ago

Thanks!

Reviewed-by: Oliver Smith <ollieparanoid@postmarketos.org>

---
 pmb/helpers/frontend.py | 2 +-
 pmb/parse/arguments.py  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/pmb/helpers/frontend.py b/pmb/helpers/frontend.py
index 95c507c0..5bbf863c 100644
--- a/pmb/helpers/frontend.py
+++ b/pmb/helpers/frontend.py
@@ -386,7 +386,7 @@ def kconfig(args):
 
         # Handle passing a file directly
         if args.file:
-            if pmb.parse.kconfig.check_file(args.package, components_list,
+            if pmb.parse.kconfig.check_file(args.file, components_list,
                                             details=details):
                 logging.info("kconfig check succeeded!")
                 return
diff --git a/pmb/parse/arguments.py b/pmb/parse/arguments.py
index 406f0de1..ffd8780c 100644
--- a/pmb/parse/arguments.py
+++ b/pmb/parse/arguments.py
@@ -468,8 +468,8 @@ def arguments_kconfig(subparser):
                        " kernels, even the ones that would be ignored by"
                        " default")
     check.add_argument("--arch", choices=arch_choices, dest="arch")
-    check.add_argument("--file", action="store_true", help="check a file"
-                       " directly instead of a config in a package")
+    check.add_argument("--file", help="check a file directly instead of a"
+                       " config in a package")
     check.add_argument("--no-details", action="store_false",
                        dest="kconfig_check_details",
                        help="print one generic error per component instead of"
-- 
2.43.0

builds.sr.ht <builds@sr.ht>

1 year, 3 months ago

pmbootstrap/patches/.build.yml: SUCCESS in 19m0s

[pmb.helpers.frontend: Convert kconfig check --file argument][0] from [Luca Weiss][1]

[0]: https://lists.sr.ht/~postmarketos/pmbootstrap-devel/patches/47312
[1]: mailto:luca@z3ntu.xyz

✓ #1106459 SUCCESS pmbootstrap/patches/.build.yml https://builds.sr.ht/~postmarketos/job/1106459