Date: Wed, 23 Sep 2020 09:35:48 -0600
From: Rob Herring <robh@kernel.org>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>, Andy Gross <agross@kernel.org>, Ohad Ben-Cohen <ohad@wizery.com>, Rajendra Nayak <rnayak@codeaurora.org>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 05/10] dt-bindings: remoteproc: qcom,q6v5: Deprecate
 regulators for PDs
Message-ID: <20200923153548.GA789614@bogus>
References: <20200916104135.25085-1-stephan@gerhold.net>
 <20200916104135.25085-6-stephan@gerhold.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200916104135.25085-6-stephan@gerhold.net>

On Wed, Sep 16, 2020 at 12:41:30PM +0200, Stephan Gerhold wrote:
> Newer platforms vote for necessary power domains through the power
> domain subsystem. For historical reasons older platforms like MSM8916
> or MSM8974 still control these as regulators.

Do you plan to change these platforms? If not then I wouldn't really 
call this deprecated.

> 
> Managing them as power domains is preferred since that allows us
> to vote for corners instead of raw voltages. Document that those
> should be specified as power domains and deprecate using them
> through the regulator interface.
> 
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
>  .../devicetree/bindings/remoteproc/qcom,q6v5.txt     | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
> index 1f9a62e13ebe..7ccd5534b0ae 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
> @@ -113,8 +113,8 @@ should be referenced as follows:
>  For the compatible strings below the following supplies are required:
>    "qcom,q6v5-pil"
>    "qcom,msm8916-mss-pil",
> -- cx-supply:
> -- mx-supply:
> +- cx-supply: (deprecated, use power domain instead)
> +- mx-supply: (deprecated, use power domain instead)
>  - pll-supply:
>  	Usage: required
>  	Value type: <phandle>
> @@ -123,9 +123,9 @@ For the compatible strings below the following supplies are required:
>  
>  For the compatible string below the following supplies are required:
>    "qcom,msm8974-mss-pil"
> -- cx-supply:
> +- cx-supply: (deprecated, use power domain instead)
>  - mss-supply:
> -- mx-supply:
> +- mx-supply: (deprecated, use power domain instead)
>  - pll-supply:
>  	Usage: required
>  	Value type: <phandle>
> @@ -149,11 +149,11 @@ For the compatible string below the following supplies are required:
>  	Usage: required
>  	Value type: <stringlist>
>  	Definition: The power-domains needed depend on the compatible string:
> -	qcom,q6v5-pil:
>  	qcom,ipq8074-wcss-pil:
> +		    no power-domain names required
> +	qcom,q6v5-pil:
>  	qcom,msm8916-mss-pil:
>  	qcom,msm8974-mss-pil:
> -		    no power-domain names required
>  	qcom,msm8996-mss-pil:
>  	qcom,msm8998-mss-pil:
>  		    must be "cx", "mx"
> -- 
> 2.28.0
>