The dts and dtsi add support for msm8916 variant of Samsung Galaxy J3
SM-J320YZ smartphone released in 2016.
Add a device tree for SM-J320YZ with initial support for:
- GPIO keys
- SDHCI (internal and external storage)
- USB Device Mode
- UART (on USB connector via the SM5703 MUIC)
- WCNSS (WiFi/BT)
- Regulators
- QDSP6 audio
- Speaker/earpiece/headphones/microphones via digital/analog codec in
MSM8916/PM8916
- WWAN Internet via BAM-DMUX
- Touchscreen
- Accelerometer
There are different variants of J3, with some differences in MUIC, sensor,
NFC and touch key I2C buses.
The common parts are shared in msm8916-samsung-j3-common.dtsi to reduce
duplication.
---
v2: Add accelerometer
V1: Initial device tree
Link: https://lore.kernel.org/r/20240802080701.3643-1-linmengbo06890@proton.me
On 04/08/2024 08:59, Lin, Meng-Bo wrote:
> Document samsung,j3ltetw bindings used in its device tree.>
Please do not work on old kernels... You *must* base on something recent.
<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
</form letter>
> Signed-off-by: "Lin, Meng-Bo" <linmengbo06890@proton.me>> ---> Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
On Sun, 04 Aug 2024 06:59:06 +0000, Lin, Meng-Bo wrote:
> The dts and dtsi add support for msm8916 variant of Samsung Galaxy J3> SM-J320YZ smartphone released in 2016.> > Add a device tree for SM-J320YZ with initial support for:> > - GPIO keys> - SDHCI (internal and external storage)> - USB Device Mode> - UART (on USB connector via the SM5703 MUIC)> - WCNSS (WiFi/BT)> - Regulators> - QDSP6 audio> - Speaker/earpiece/headphones/microphones via digital/analog codec in> MSM8916/PM8916> - WWAN Internet via BAM-DMUX> - Touchscreen> - Accelerometer> > There are different variants of J3, with some differences in MUIC, sensor,> NFC and touch key I2C buses.> > The common parts are shared in msm8916-samsung-j3-common.dtsi to reduce> duplication.> > ---> v2: Add accelerometer> V1: Initial device tree> Link: https://lore.kernel.org/r/20240802080701.3643-1-linmengbo06890@proton.me> > >
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y qcom/msm8916-samsung-j3ltetw.dtb' for 20240804065854.42437-1-linmengbo06890@proton.me:
arch/arm64/boot/dts/qcom/msm8916-samsung-j3ltetw.dtb: /soc@0/power-manager@b088000: failed to match any schema with compatible: ['qcom,msm8916-acc']
arch/arm64/boot/dts/qcom/msm8916-samsung-j3ltetw.dtb: /soc@0/power-manager@b098000: failed to match any schema with compatible: ['qcom,msm8916-acc']
arch/arm64/boot/dts/qcom/msm8916-samsung-j3ltetw.dtb: /soc@0/power-manager@b0a8000: failed to match any schema with compatible: ['qcom,msm8916-acc']
arch/arm64/boot/dts/qcom/msm8916-samsung-j3ltetw.dtb: /soc@0/power-manager@b0b8000: failed to match any schema with compatible: ['qcom,msm8916-acc']
On Sun, 04 Aug 2024 06:59:06 +0000, Lin, Meng-Bo wrote:
> The dts and dtsi add support for msm8916 variant of Samsung Galaxy J3> SM-J320YZ smartphone released in 2016.> > Add a device tree for SM-J320YZ with initial support for:> > - GPIO keys> - SDHCI (internal and external storage)> - USB Device Mode> - UART (on USB connector via the SM5703 MUIC)> - WCNSS (WiFi/BT)> - Regulators> - QDSP6 audio> - Speaker/earpiece/headphones/microphones via digital/analog codec in> MSM8916/PM8916> - WWAN Internet via BAM-DMUX> - Touchscreen> - Accelerometer> > [...]
Applied, thanks!
[1/2] dt-bindings: qcom: Document samsung,j3ltetw
commit: c17427c6ca5e0f7c5d1f9bd9c951cb6827c8c228
[2/2] arm64: dts: qcom: msm8916-samsung-j3ltetw: Add initial device tree
commit: 469fc2e7a995ade8b929c4e2a32c93a231a3844f
Best regards,
--
Bjorn Andersson <andersson@kernel.org>