Authentication-Results: mail-b.sr.ht; dkim=pass header.d=protesilaos.com header.i=@protesilaos.com
Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195])
	by mail-b.sr.ht (Postfix) with ESMTPS id 1AE3611F0F4
	for <~protesilaos/denote@lists.sr.ht>; Fri, 28 Oct 2022 16:17:51 +0000 (UTC)
Received: (Authenticated sender: public@protesilaos.com)
	by mail.gandi.net (Postfix) with ESMTPSA id 4CA6D60002;
	Fri, 28 Oct 2022 16:17:48 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com;
	s=gm1; t=1666973869;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Pfj92pXAu7R8CkNbr8e6KITxQgE/Ai1MEPZLxPEHV8g=;
	b=ZXoCy6nJ8Y17guXdlhhlLcP30N+toVai8neLbSzzFNCwKeZ07k/oeTp5V8XWi9ls/EPLpZ
	dBarxIzD4UxVwue6PpOasYixajpgwD6a/hAP/OjARSoCr3h9AwmICqhgRmdvxxVyGwwVUT
	hsY3R1Mvgoh+fszcCPkakLrBvDTBa90tSVZ/xvSTUNFowQ3/WXuXFQFPO+pYdZps/2kIX5
	OkokUMU7soKrgPd1Vz1j0BJqZV2r3vkillF7s2i/XTNhjLuPEy7AZeiw/lQjz9uIdry/Pa
	yWNdSeXlmkSlYqChZeVxZzkWyjwrJyGgCBiZssdZ5AbvcDyE9e8elda4SIplmA==
From: Protesilaos Stavrou <info@protesilaos.com>
To: Noboru Ota <me@nobiot.com>, ~protesilaos/denote@lists.sr.ht
Subject: Re: [PATCH] Display context of identifier in backlinks buffer with
 xref
In-Reply-To: <86ilk47yyz.fsf@nobiot.com>
References: <86ilk47yyz.fsf@nobiot.com>
Date: Fri, 28 Oct 2022 19:17:47 +0300
Message-ID: <875yg3orbo.fsf@protesilaos.com>
MIME-Version: 1.0
Content-Type: text/plain

> From: Noboru Ota <me@nobiot.com>
> Date: Fri, 28 Oct 2022 17:24:36 +0200
>
> Hi Prot,

Hello nobiot,

> I wanted to refactor the implementation, so I went ahead and created
> patches (attached).  I have elaborated on the intent and implementation
> detail in the commit message.

Thank you for preparing those and for the detailed explanation!  I
installed the patches and pushed them to the main branch.  I just
followed them up with a minor change to a couple of doc strings which
placates the byte compiler.

> I will be on two-week vacation from Saturday tomorrow; this is the main
> reason why I really wanted to send all the patches to you.

Enjoy your vacation!  Don't worry about this: it can wait.

> I realize that you would be busy with the updates on Modus theme -- it's
> the theme I use and love.  Thank you :).

You are welcome!

> Please treat these patches as another discussion starter.  There
> should be more elegant way to get the backlinks logic closer to the
> built-in way with Xref.  But I would like to believe that the current
> way is not so bad.  At least functionally, I have tested them on my
> Emacs 28.1 for all the four cases of backlinks (context on/off and two
> commands 'denote-link-backlinks' and 'denote-link-find-backlink').

The only thing I can think of right now is whether we need 'user-error'
forms when no backlinks are available.  Maybe a simple 'message' is
better, since this case is not technically an "error".

> I will not carry my laptop to the vacation but I should be able to read
> emails.  If there is anything I can/should do, I will see what I can do
> in mid November.

From my side, I promise NOT to send you anything: vacations are to be
respected.  It is okay to revisit whatever remaining work afterwards.
Also, version 1.1.0 of Denote was published on 2022-10-20, so we are not
in a hurry to release a new version---the package is stable as-is.

In other words: have fun!

All the best,
Prot

-- 
Protesilaos Stavrou
https://protesilaos.com