From: Protesilaos Stavrou <info@protesilaos.com>
To: Noboru Ota <me@nobiot.com>, ~protesilaos/denote@lists.sr.ht
Subject: Re: [PATCH] Display context of identifier in backlinks buffer with
 xref
In-Reply-To: <86h6zpmhpd.fsf@nobiot.com>
References: <86h6zpmhpd.fsf@nobiot.com>
Date: Thu, 27 Oct 2022 18:18:48 +0300
Message-ID: <877d0lwazr.fsf@protesilaos.com>
MIME-Version: 1.0
Content-Type: text/plain

> From: Noboru Ota <me@nobiot.com>
> Date: Thu, 27 Oct 2022 17:03:58 +0200
>
>> This is the current commit log, since our last exchange:
>> [... omitted ...]
>> Please let me know if you are okay with them.
>> [... omitted ...]
>> I believe I have not missed anything from the latest set of patches you
>> sent.  If I did, it was not intentional, and please tell me about it.
>
> All well on my end.  I tested commit ee69dae; it works for (both
> with/without context). Thank you. Your reasoning makes sense to me; I
> agree.

You are welcome and thank you for trying it out!

>> I believe the way I implemented those wrappers accommodates both the old
>> backlinks' buffer and the new one with the added context.  Please let me
>> know if this is true on your end.
>
> One thing I noticed is you use 'funcall'.  You could just call the
> function (?)

My mistake!  I just pushed an update.

> One additional thing I have noticed.  I am sending a patch; no
> functional change. Just to align the variable name 'xrefs-alist' (xrefs,
> plural) to the built-in library (Xref uses singular 'xref-alist') while
> it is still "hot". 

I installed the patch.  Thank you!

-- 
Protesilaos Stavrou
https://protesilaos.com