From: Protesilaos Stavrou <info@protesilaos.com>
To: Noboru Ota <me@nobiot.com>, ~protesilaos/denote@lists.sr.ht
Subject: Re: [PATCH] Display context of identifier in backlinks buffer with
 xref
In-Reply-To: <86sfja78ik.fsf@nobiot.com>
References: <86sfja78ik.fsf@nobiot.com>
Date: Thu, 27 Oct 2022 04:08:04 +0300
Message-ID: <87pmeef4zv.fsf@protesilaos.com>
MIME-Version: 1.0
Content-Type: text/plain

> From: Noboru Ota <me@nobiot.com>
> Date: Wed, 26 Oct 2022 20:19:15 +0200
>
> Hi Prot,

Hello Noboru,

> One more for the evening :)

Thank you!  I am just replying to this message, though I got all your
patches.  I will work on them now.

> Has Denote been ever tested with Emacs 27.2?

Only lightly.  I think we should rethink this dependency, as it holds us
back and may not be worth the trouble.

> I have got Emacs 27.2, checked out commit bc035823, which is the one
> before my first patch for backlinks buffer refactoring.  There is
> already an error where function 'xref--alistify' is called (line 1137 in
> the source code in this commit).  It requires 3 arguments in version
> 27.2.  In version one this has changed and it requires only 2 arguments
> (I'm attaching an image I took from version 27.2).
>
> I can only assume that it would have failed before my patches.  If you
> have tested Denote with 27.2 successfully, how did you manage the
> difference in the signature of the built-in function?

Yes, it would have failed in that case.  I did not test it.

* * *

I will now work on your patches.  If I have any specific comments, I
will let you know.  Thank you once again!

All the best,
Prot

-- 
Protesilaos Stavrou
https://protesilaos.com