~protesilaos/denote

1

denote-rename-file-using-front-matter not working after signature branch merge

Details
Message ID
<87zg86lru9.fsf@kotlak.com>
DKIM signature
missing
Download raw message
Hi Prot,

Just reporting it here. I pulled the latest changes (at 62c6853 now) and
noticed that 'denote-rename-file-using-front-matter' has started to give
error "No front matter for title and/or keywords". With some debugging
I could find that error is because of this line:

  (signature (denote-retrieve-filename-signature file))


If we remove this and use 'nil' as 'signature' value, it works.


thanks
Details
Message ID
<87mt46ptq6.fsf@protesilaos.com>
In-Reply-To
<87zg86lru9.fsf@kotlak.com> (view parent)
DKIM signature
missing
Download raw message
> From: relict007 <utils+sr.ht@kotlak.com>
> Date: Tue, 21 Mar 2023 08:37:33 +0530
>
> Hi Prot,

Hello there!

> Just reporting it here. I pulled the latest changes (at 62c6853 now) and
> noticed that 'denote-rename-file-using-front-matter' has started to give
> error "No front matter for title and/or keywords". With some debugging
> I could find that error is because of this line:
>
>   (signature (denote-retrieve-filename-signature file))
>
>
> If we remove this and use 'nil' as 'signature' value, it works.

Thank you for reporting this!  I just pushed an update:

    commit 2021999f82bf35579e6cc5d72618167e1f6ce9f7
    Author: Protesilaos Stavrou <info@protesilaos.com>
    Date:   Tue Mar 21 07:16:11 2023 +0200

        Fix case where denote-rename-file-using-front-matter finds no signature

        The idea is that we want the command to behave the way it always did
        when the file has no signature and to preserve the signature when it
        is present.

        Thanks to relict for reporting the issue on the mailing list:
        <https://lists.sr.ht/~protesilaos/denote/%3C87zg86lru9.fsf%40kotlak.com%3E>.

     denote.el | 7 +++++--
     1 file changed, 5 insertions(+), 2 deletions(-)

All the best,
Prot

-- 
Protesilaos Stavrou
https://protesilaos.com
Reply to thread Export thread (mbox)