~protesilaos/denote

4 2

[PATCH] Add denote-backlink-find-file

Details
Message ID
<m2fsg6o2t6.fsf@MBA21.fritz.box>
DKIM signature
missing
Download raw message
Hi all

Here's a patch that adds 'denote-backlink-find-file', a variation on
'denote-link-find-file', to visit a backlink note from the minibuffer.

First time sending a patch instead of a Github PR, so fingers crossed it
works.

All the best
Elias


PS: Still waiting for confirmation by the FSF that they received my
signed copyright assignment form... But should be okay I guess.
Details
Message ID
<874jwmp1py.fsf@protesilaos.com>
In-Reply-To
<m2fsg6o2t6.fsf@MBA21.fritz.box> (view parent)
DKIM signature
missing
Download raw message
> From: Elias Storms <elias.storms@gmail.com>
> Date: Sun,  2 Oct 2022 13:56:18 +0200
>
> Hi all

Hello Elias,

> Here's a patch that adds 'denote-backlink-find-file', a variation on
> 'denote-link-find-file', to visit a backlink note from the minibuffer.

Good idea!

The commands needs to be named a bit differently though so that it
shares the "denote-link-" prefix.  We used to have all the code in
separate files, but now we keep everything together while retaining the
prefixes.  Those help with, say, M-x imenu and related.

No need to update the patch though, I can do it after I install it.

[ You couldn't have known that.  No worries! ]

> First time sending a patch instead of a Github PR, so fingers crossed it
> works.

Looks good!

There is only one unrelated problem which I noticed with your pull
request on GitHub as well.  I just thought it was some GitHub bug...
Check your patch's "From:" header:

> From: EFLS <>

It has no email address.  It is better to configure Git accordingly:
<https://www.git-scm.com/book/en/v2/Customizing-Git-Git-Configuration>.
This way we have information about you in case we ever need to contact
you (e.g. a future reviewer may need to add you in Cc while mentioning
this commit).

If you need help, just let me know.

> PS: Still waiting for confirmation by the FSF that they received my
> signed copyright assignment form... But should be okay I guess.

It will be fine.  I will install your patch tomorrow morning, just to be
sure I don't miss something right now (it's been a looong day).

All the best,
Prot

-- 
Protesilaos Stavrou
https://protesilaos.com
Details
Message ID
<m2pmfam7yi.fsf@MBA21.fritz.box>
In-Reply-To
<874jwmp1py.fsf@protesilaos.com> (view parent)
DKIM signature
missing
Download raw message
Hi again

> The commands needs to be named a bit differently though so that it
> shares the "denote-link-" prefix.  

Earlier (in my own config) I called this function
'denote-link-find-backlink'. Perhaps that's more suitable?

> Check your patch's "From:" header:
>
>> From: EFLS <>
>
> It has no email address. 

I deliberately left this out earlier, but I'll make sure to include an
email address in the future.

Elias


Protesilaos Stavrou <info@protesilaos.com> writes:

>> From: Elias Storms <elias.storms@gmail.com>
>> Date: Sun,  2 Oct 2022 13:56:18 +0200
>>
>> Hi all
>
> Hello Elias,
>
>> Here's a patch that adds 'denote-backlink-find-file', a variation on
>> 'denote-link-find-file', to visit a backlink note from the minibuffer.
>
> Good idea!
>
> The commands needs to be named a bit differently though so that it
> shares the "denote-link-" prefix.  We used to have all the code in
> separate files, but now we keep everything together while retaining the
> prefixes.  Those help with, say, M-x imenu and related.
>
> No need to update the patch though, I can do it after I install it.
>
> [ You couldn't have known that.  No worries! ]
>
>> First time sending a patch instead of a Github PR, so fingers crossed it
>> works.
>
> Looks good!
>
> There is only one unrelated problem which I noticed with your pull
> request on GitHub as well.  I just thought it was some GitHub bug...
> Check your patch's "From:" header:
>
>> From: EFLS <>
>
> It has no email address.  It is better to configure Git accordingly:
> <https://www.git-scm.com/book/en/v2/Customizing-Git-Git-Configuration>.
> This way we have information about you in case we ever need to contact
> you (e.g. a future reviewer may need to add you in Cc while mentioning
> this commit).
>
> If you need help, just let me know.
>
>> PS: Still waiting for confirmation by the FSF that they received my
>> signed copyright assignment form... But should be okay I guess.
>
> It will be fine.  I will install your patch tomorrow morning, just to be
> sure I don't miss something right now (it's been a looong day).
>
> All the best,
> Prot
Details
Message ID
<87y1tynm9j.fsf@protesilaos.com>
In-Reply-To
<m2pmfam7yi.fsf@MBA21.fritz.box> (view parent)
DKIM signature
missing
Download raw message
> From: Elias Storms <elias.storms@gmail.com>
> Date: Sun,  2 Oct 2022 19:46:24 +0200
>
> Hi again
>
>> The commands needs to be named a bit differently though so that it
>> shares the "denote-link-" prefix.  
>
> Earlier (in my own config) I called this function
> 'denote-link-find-backlink'. Perhaps that's more suitable?

Yes, that sounds right!

>> Check your patch's "From:" header:
>>
>>> From: EFLS <>
>>
>> It has no email address. 
>
> I deliberately left this out earlier, but I'll make sure to include an
> email address in the future.

It is not a requirement.  If you have a reason not to include one, then
leave it as-is.  I just thought you missed it, so I brought it up.

-- 
Protesilaos Stavrou
https://protesilaos.com
Details
Message ID
<878rlxeggq.fsf@protesilaos.com>
In-Reply-To
<87y1tynm9j.fsf@protesilaos.com> (view parent)
DKIM signature
missing
Download raw message
> From: Protesilaos Stavrou <info@protesilaos.com>
> Date: Sun,  2 Oct 2022 20:55:20 +0300

> [... 20 lines elided]

>> I deliberately left this out earlier, but I'll make sure to include an
>> email address in the future.
>
> It is not a requirement.  If you have a reason not to include one, then
> leave it as-is.  I just thought you missed it, so I brought it up.

Good day Elias,

I installed your patch.  I edited the file to use the symbol
'denote-link-find-backlink' directly (one of the nice things about
patches).

    commit 56c39531669c75ca1b076c80f82f65ee66ca4b78
    Author: EFLS <>
    Date:   Sun Oct 2 13:38:28 2022 +0200

        Add denote-link-find-backlink command

        Variation on denote-link-find-file, but for visiting backlinks to the current
        note via the minibuffer.

     README.org |  4 ++++
     denote.el  | 14 ++++++++++++++
     2 files changed, 18 insertions(+)

I followed it up with some minor tweaks to the manual, to cross link to
the backlinks' buffer section and to update the sample configuration.

Have a nice day,
Prot

-- 
Protesilaos Stavrou
https://protesilaos.com
Reply to thread Export thread (mbox)