~protesilaos/denote

2 2

Bug: denote-rename-file changing the identifier for existing notes

Ashton Wiersdorf <mail@wiersdorf.dev>
Details
Message ID
<m2lefbbzl1.fsf@wiersdorfmail.net>
DKIM signature
missing
Download raw message
Hi there,

I've used `denote-rename-file' to get an interactive tag prompt. I 
think this has worked well for me in the past. However, I noticed 
today that when I use this function to add a tag to a file, the 
time part of the identifier gets clobbered with the current time.

Reproduce:

 - Create a new note
 - In the note, run `denote-rename-file'
   + Make some tweaks, e.g. add tags
 - Before committing the file rename, notice that the timestamp 
 has been clobbered

This is happening in existing notes too.

Is this the expected behavior? I would think not—if the date is 
getting preserved but not the time, then something seems amiss.

If this *is* the expected behavior, is there a new interactive 
command for renaming/adding tags without clobbering the file 
identifier?

Thanks,

-- 
Ashton Wiersdorf
https://lambdaland.org/
Details
Message ID
<87edl3lr3g.fsf@protesilaos.com>
In-Reply-To
<m2lefbbzl1.fsf@wiersdorfmail.net> (view parent)
DKIM signature
missing
Download raw message
> From: Ashton Wiersdorf <mail@wiersdorf.dev>
> Date: Wed, 19 Jul 2023 10:48:36 -0600
>
> Hi there,

Hello Ashton,

> I've used `denote-rename-file' to get an interactive tag prompt. I 
> think this has worked well for me in the past. However, I noticed 
> today that when I use this function to add a tag to a file, the 
> time part of the identifier gets clobbered with the current time.

> [... 19 lines elided]

Thank you for reporting this!

It is a regression caused by some recent changes I made.  I just pushed
an update that should restore the expected behaviour of preserving an
existing identifier.

Please try it and let me know how it goes.

All the best,
Prot

-- 
Protesilaos Stavrou
https://protesilaos.com
Ashton Wiersdorf <mail@wiersdorf.dev>
Details
Message ID
<m2cz0nvizv.fsf@wiersdorf.dev>
In-Reply-To
<87edl3lr3g.fsf@protesilaos.com> (view parent)
DKIM signature
missing
Download raw message
> Thank you for reporting this!

Gladly!

> It is a regression caused by some recent changes I made.

I'm glad that this was in fact a bug and not some misunderstanding 
I had been running with for a while. :)

> Please try it and let me know how it goes.

Seems to be working just fine now. Thank you so much Prot!

-- 
Ashton Wiersdorf
https://lambdaland.org/
Reply to thread Export thread (mbox)