~protesilaos/ef-themes

7 2

On `rcirc-nick-in-message-full-line'

Details
Message ID
<87edwphahl.fsf@posteo.net>
DKIM signature
missing
Download raw message
Hi,

I was just mentioned in a message and the message was highlighted in
italics.  I think this style is unusual, and think that using a
highlighted foreground or background would be better.  Though in both
cases this is not ideal, since IRC messages can contain certain control
codes that could both lead to italicised text or miscellaneous fg/bg
colours.  The only difference is that `rcirc-nick-in-message-full-line'
affects the entire line (plus the nickname) while messages with control
codes wouldn't touch the nick name.
Details
Message ID
<875yi18ddz.fsf@protesilaos.com>
In-Reply-To
<87edwphahl.fsf@posteo.net> (view parent)
DKIM signature
missing
Download raw message
> From: Philip Kaludercic <philipk@posteo.net>
> Date: Mon, 05 Sep 2022 19:44:38 +0000
>
>
> Hi,

Hello Philip,

> I was just mentioned in a message and the message was highlighted in
> italics.  I think this style is unusual, and think that using a
> highlighted foreground or background would be better.  Though in both
> cases this is not ideal, since IRC messages can contain certain control
> codes that could both lead to italicised text or miscellaneous fg/bg
> colours.  The only difference is that `rcirc-nick-in-message-full-line'
> affects the entire line (plus the nickname) while messages with control
> codes wouldn't touch the nick name.

Maybe I can join IRC later to see this in action with you?  Whenever I
log in there is no activity, so I just went with this style until
further review.  In the modus-themes, the face is like this:

    `(rcirc-nick-in-message-full-line ((,class :inherit bold :foreground ,cyan-alt-other)))

But I am not sure that a full line in bold is good either.

All the best,
Prot

-- 
Protesilaos Stavrou
https://protesilaos.com
Details
Message ID
<875yi1nd8t.fsf@posteo.net>
In-Reply-To
<875yi18ddz.fsf@protesilaos.com> (view parent)
DKIM signature
missing
Download raw message
Protesilaos Stavrou <info@protesilaos.com> writes:

>> From: Philip Kaludercic <philipk@posteo.net>
>> Date: Mon, 05 Sep 2022 19:44:38 +0000
>>
>>
>> Hi,
>
> Hello Philip,
>
>> I was just mentioned in a message and the message was highlighted in
>> italics.  I think this style is unusual, and think that using a
>> highlighted foreground or background would be better.  Though in both
>> cases this is not ideal, since IRC messages can contain certain control
>> codes that could both lead to italicised text or miscellaneous fg/bg
>> colours.  The only difference is that `rcirc-nick-in-message-full-line'
>> affects the entire line (plus the nickname) while messages with control
>> codes wouldn't touch the nick name.
>
> Maybe I can join IRC later to see this in action with you?  

One could, and I'd gladly help, but in general it is easier to connect
to a server like testnet.inspircd.org or testnet.ergo.chat.

>                                                             Whenever I
> log in there is no activity, so I just went with this style until
> further review.  In the modus-themes, the face is like this:
>
>     `(rcirc-nick-in-message-full-line ((,class :inherit bold :foreground ,cyan-alt-other)))

I believe this is preferable.

> But I am not sure that a full line in bold is good either.

It does help with recognising a message, especially if you just quickly
skim over a lot of messages one might have had received.

> All the best,
> Prot
Details
Message ID
<874jxka8s8.fsf@protesilaos.com>
In-Reply-To
<875yi1nd8t.fsf@posteo.net> (view parent)
DKIM signature
missing
Download raw message
> From: Philip Kaludercic <philipk@posteo.net>
> Date: Tue, 06 Sep 2022 08:00:50 +0000

> [... 20 lines elided]

>> Maybe I can join IRC later to see this in action with you?  
>
> One could, and I'd gladly help, but in general it is easier to connect
> to a server like testnet.inspircd.org or testnet.ergo.chat.

Okay, I will try those servers as soon as possible.

>>                                                             Whenever I
>> log in there is no activity, so I just went with this style until
>> further review.  In the modus-themes, the face is like this:
>>
>>     `(rcirc-nick-in-message-full-line ((,class :inherit bold :foreground ,cyan-alt-other)))
>
> I believe this is preferable.

Thank you!  For now I just made it use 'bold' instead of 'italic'.  This
is subject to review, as it may be better to also add a distinct colour.

-- 
Protesilaos Stavrou
https://protesilaos.com
Details
Message ID
<87bkrsfsf1.fsf@posteo.net>
In-Reply-To
<874jxka8s8.fsf@protesilaos.com> (view parent)
DKIM signature
missing
Download raw message
Protesilaos Stavrou <info@protesilaos.com> writes:

>> From: Philip Kaludercic <philipk@posteo.net>
>> Date: Tue, 06 Sep 2022 08:00:50 +0000
>
>> [... 20 lines elided]
>
>>> Maybe I can join IRC later to see this in action with you?  
>>
>> One could, and I'd gladly help, but in general it is easier to connect
>> to a server like testnet.inspircd.org or testnet.ergo.chat.
>
> Okay, I will try those servers as soon as possible.
>
>>>                                                             Whenever I
>>> log in there is no activity, so I just went with this style until
>>> further review.  In the modus-themes, the face is like this:
>>>
>>>     `(rcirc-nick-in-message-full-line ((,class :inherit bold :foreground ,cyan-alt-other)))
>>
>> I believe this is preferable.
>
> Thank you!  For now I just made it use 'bold' instead of 'italic'.  This
> is subject to review, as it may be better to also add a distinct colour.

The issue here is that messages might just as well be marked up to be
bold, see `rcirc-markup-attributes', but I guess it is more intuitive
than using italics.  I was confused the first time I saw a message like
that.
Details
Message ID
<87mtbc8qay.fsf@protesilaos.com>
In-Reply-To
<87bkrsfsf1.fsf@posteo.net> (view parent)
DKIM signature
missing
Download raw message
> From: Philip Kaludercic <philipk@posteo.net>
> Date: Tue, 06 Sep 2022 15:12:34 +0000

>> Thank you!  For now I just made it use 'bold' instead of 'italic'.  This
>> is subject to review, as it may be better to also add a distinct colour.
>
> The issue here is that messages might just as well be marked up to be
> bold, see `rcirc-markup-attributes', but I guess it is more intuitive
> than using italics.  I was confused the first time I saw a message like
> that.

Okay.  I revised it to inherit from 'warning' instead of 'bold'.  This
will give a bold weight and a yellow colour.  Though, again, I still
want to test this for thematic consistency.

-- 
Protesilaos Stavrou
https://protesilaos.com
Details
Message ID
<87leqwmqm0.fsf@posteo.net>
In-Reply-To
<87mtbc8qay.fsf@protesilaos.com> (view parent)
DKIM signature
missing
Download raw message
Protesilaos Stavrou <info@protesilaos.com> writes:

>> From: Philip Kaludercic <philipk@posteo.net>
>> Date: Tue, 06 Sep 2022 15:12:34 +0000
>
>>> Thank you!  For now I just made it use 'bold' instead of 'italic'.  This
>>> is subject to review, as it may be better to also add a distinct colour.
>>
>> The issue here is that messages might just as well be marked up to be
>> bold, see `rcirc-markup-attributes', but I guess it is more intuitive
>> than using italics.  I was confused the first time I saw a message like
>> that.
>
> Okay.  I revised it to inherit from 'warning' instead of 'bold'.  This
> will give a bold weight and a yellow colour.  Though, again, I still
> want to test this for thematic consistency.

I'd say this is an improvement, since the chance of someone using both
yellow and bold markup is lower.  Though I am uncertain if 'warning' is
the best face to associate, because it has a slightly negative
connotation, while being mentioned is usually a good thing.
Details
Message ID
<87h71k8omh.fsf@protesilaos.com>
In-Reply-To
<87leqwmqm0.fsf@posteo.net> (view parent)
DKIM signature
missing
Download raw message
> From: Philip Kaludercic <philipk@posteo.net>
> Date: Tue, 06 Sep 2022 16:09:43 +0000

> [... 14 lines elided]

>> Okay.  I revised it to inherit from 'warning' instead of 'bold'.  This
>> will give a bold weight and a yellow colour.  Though, again, I still
>> want to test this for thematic consistency.
>
> I'd say this is an improvement, since the chance of someone using both
> yellow and bold markup is lower.  Though I am uncertain if 'warning' is
> the best face to associate, because it has a slightly negative
> connotation, while being mentioned is usually a good thing.

True.  When I test it, I will consider other colours.  Tomorrow,
hopefully.

-- 
Protesilaos Stavrou
https://protesilaos.com
Reply to thread Export thread (mbox)