Hello,
When reading emails in notmuch-show-mode using ef-dark, I have trouble
distinguishing the limit between one email and the other. Could the
background of the from line be made lighter, to be better seen? (I tried
ef-light, and I can see the from line for other messages much better.)
Best,
Alan
> From: alan.schmitt@polytechnique.org> Date: Tue, 20 Sep 2022 13:07:29 +0200>> Hello,
Hello Alan,
> When reading emails in notmuch-show-mode using ef-dark, I have trouble> distinguishing the limit between one email and the other. Could the> background of the from line be made lighter, to be better seen? (I tried> ef-light, and I can see the from line for other messages much better.)
In principle, yes we can tweak those colours. Though I need to know if
you think this is specific to ef-dark or if it applies to other dark
themes as well.
If the problem is general, maybe you can check your monitor's settings?
Two tests, for example:
1. <http://www.lagom.nl/lcd-test/black.php>
2. <http://www.lagom.nl/lcd-test/white.php>
We can make improvements. This is just to have a better sense of what
needs to be done.
All the best,
Prot
--
Protesilaos Stavrou
https://protesilaos.com
Hello Prot,
On 2022-09-20 14:28, Protesilaos Stavrou <info@protesilaos.com> writes:
> In principle, yes we can tweak those colours. Though I need to know if> you think this is specific to ef-dark or if it applies to other dark> themes as well.
I looked at all the ef-themes, and for all of them the contrast is too
low for me.
> If the problem is general, maybe you can check your monitor's settings?> Two tests, for example:>> 1. <http://www.lagom.nl/lcd-test/black.php>> 2. <http://www.lagom.nl/lcd-test/white.php>
I can change my monitor settings such that the white test passes, but I
cannot find a setting where the black one passes. All the squares on the
first line are undistinguishable. I guess this means my monitor is not
great…
Best,
Alan
> From: Alan Schmitt <alan.schmitt@polytechnique.org>
> Date: Tue, 20 Sep 2022 13:46:42 +0200
>
> Hello Prot,
>
> On 2022-09-20 14:28, Protesilaos Stavrou <info@protesilaos.com> writes:
>
>> In principle, yes we can tweak those colours. Though I need to know if
>> you think this is specific to ef-dark or if it applies to other dark
>> themes as well.
>
> I looked at all the ef-themes, and for all of them the contrast is too
> low for me.
Okay, I thought so. All themes are designed to be similar in this
regard.
>> If the problem is general, maybe you can check your monitor's settings?
>> Two tests, for example:
>>
>> 1. <http://www.lagom.nl/lcd-test/black.php>
>> 2. <http://www.lagom.nl/lcd-test/white.php>
>
> I can change my monitor settings such that the white test passes, but I
> cannot find a setting where the black one passes. All the squares on the
> first line are undistinguishable. I guess this means my monitor is not
> great…
That's fine. This is the case with many monitors. I once spent 8 hours
to calibrate mine to show all the squares. But we don't want to do that
here...
What do you think about this modest change?
ef-themes.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ef-themes.el b/ef-themes.el
index 53ae1c6..21667e3 100644
--- a/ef-themes.el+++ b/ef-themes.el
@@ -1291,7 +1291,7 @@ ;;;; notmuch
`(notmuch-crypto-signature-good-key ((,c :inherit success)))
`(notmuch-crypto-signature-unknown ((,c :inherit warning)))
`(notmuch-jump-key ((,c :inherit ef-themes-key-binding)))
- `(notmuch-message-summary-face ((,c :inherit bold :background ,bg-dim)))+ `(notmuch-message-summary-face ((,c :inherit bold :background ,bg-dim :overline ,bg-active))) `(notmuch-search-count ((,c :foreground ,fg-dim)))
`(notmuch-search-date ((,c :foreground ,date)))
`(notmuch-search-flagged-face ((,c :foreground ,err)))
Will the added :overline help? If the above is still too subtle, we
have two more options: (1) to use a more intense overline such as
":overline ,border" or (2) to replace ",bg-dim" with ",bg-alt".
Can you try those and tell me what you think?
--
Protesilaos Stavrou
https://protesilaos.com
Hello Prot,
On 2022-09-20 14:57, Protesilaos Stavrou <info@protesilaos.com> writes:
>> I can change my monitor settings such that the white test passes, but I>> cannot find a setting where the black one passes. All the squares on the>> first line are undistinguishable. I guess this means my monitor is not>> great…>> That's fine. This is the case with many monitors. I once spent 8 hours> to calibrate mine to show all the squares. But we don't want to do that> here...
A funny thing: my home monitor is much better, and I don’t feel the need
for a change here… (And the black squares are all visible and different.)
> What do you think about this modest change?
I’m afraid that I don’t really know how to test it. I tried changing
this code and evaluate ef-themes-faces, but I’m not seeing any change.
Do I need to save the change and restart emacs?
Best,
Alan
> From: Alan Schmitt <alan.schmitt@polytechnique.org>> Date: Tue, 20 Sep 2022 19:53:47 +0200>> Hello Prot,
Hello Alan,
> On 2022-09-20 14:57, Protesilaos Stavrou <info@protesilaos.com> writes:>>>> I can change my monitor settings such that the white test passes, but I>>> cannot find a setting where the black one passes. All the squares on the>>> first line are undistinguishable. I guess this means my monitor is not>>> great…>>>> That's fine. This is the case with many monitors. I once spent 8 hours>> to calibrate mine to show all the squares. But we don't want to do that>> here...>> A funny thing: my home monitor is much better, and I don’t feel the need> for a change here… (And the black squares are all visible and different.)
Okay, that is good. If the problem with the dark shades of grey exists
in one place, it will exist everywhere and make the theme harder to
user.
>> What do you think about this modest change?>> I’m afraid that I don’t really know how to test it. I tried changing> this code and evaluate ef-themes-faces, but I’m not seeing any change.> Do I need to save the change and restart emacs?
Ah yes, I didn't explain... Sorry! Normally, you apply the diff,
evaluate the changed file, and then reload the theme. Though you must
delete any .elc file of that theme.
Another way for live testing is this:
(ef-themes-with-colors
(set-face-attribute
'notmuch-message-summary-face nil
:inherit 'bold :background bg-dim :overline border))
In this case the "bg-dim" and "border" are variables which represent
colour values. They are exposed by the 'ef-themes-with-colors' macro.
Just evaluate it and you see the results right away.
Though since your one monitor works, it is better to be conservative
with any possible changes here. As I noted, the problem with the
indistinguishable shades of dark grey will exist in other places as
well.
All the best,
Prot
--
Protesilaos Stavrou
https://protesilaos.com
On 2022-09-21 04:36, Protesilaos Stavrou <info@protesilaos.com> writes:
> Another way for live testing is this:>> (ef-themes-with-colors> (set-face-attribute> 'notmuch-message-summary-face nil> :inherit 'bold :background bg-dim :overline border))>> In this case the "bg-dim" and "border" are variables which represent> colour values. They are exposed by the 'ef-themes-with-colors' macro.>> Just evaluate it and you see the results right away.
Thank you! I gave it a try, and it is better. I also tried replacing
bg-dim with bg-alt, and I now find it very clear. The latter is my
preferred solution.
Best,
Alan
> From: Alan Schmitt <alan.schmitt@polytechnique.org>> Date: Wed, 21 Sep 2022 08:33:22 +0200>> On 2022-09-21 04:36, Protesilaos Stavrou <info@protesilaos.com> writes:>>> Another way for live testing is this:>>>> (ef-themes-with-colors>> (set-face-attribute>> 'notmuch-message-summary-face nil>> :inherit 'bold :background bg-dim :overline border))>>>> In this case the "bg-dim" and "border" are variables which represent>> colour values. They are exposed by the 'ef-themes-with-colors' macro.>>>> Just evaluate it and you see the results right away.>> Thank you! I gave it a try, and it is better. I also tried replacing> bg-dim with bg-alt, and I now find it very clear. The latter is my> preferred solution.
Okay, I am noting this. Though we need to consider the implications, as
there are other places that use 'bg-dim'. One prominent example is
Magit. The 'bg-dim' applies to stuff like the currently highlighted
diff hunk. Do you use Magit? Do you think the current style is usable?
--
Protesilaos Stavrou
https://protesilaos.com
Hello,
On 2022-09-21 13:38, Protesilaos Stavrou <info@protesilaos.com> writes:
> Okay, I am noting this. Though we need to consider the implications, as> there are other places that use 'bg-dim'. One prominent example is> Magit. The 'bg-dim' applies to stuff like the currently highlighted> diff hunk. Do you use Magit? Do you think the current style is usable?
I do use Magit, and I had not noticed that in the list of changes to
commit, there was an highlight (magit-section-highlight, if this is what
you are making reference to…). It is a very slightly lighter shade of
dark than the background.
Best,
Alan
> From: Alan Schmitt <alan.schmitt@polytechnique.org>> Date: Thu, 22 Sep 2022 14:33:30 +0200>> Hello,
Hi Alan,
> On 2022-09-21 13:38, Protesilaos Stavrou <info@protesilaos.com> writes:>>> Okay, I am noting this. Though we need to consider the implications, as>> there are other places that use 'bg-dim'. One prominent example is>> Magit. The 'bg-dim' applies to stuff like the currently highlighted>> diff hunk. Do you use Magit? Do you think the current style is usable?>> I do use Magit, and I had not noticed that in the list of changes to> commit, there was an highlight (magit-section-highlight, if this is what> you are making reference to…). It is a very slightly lighter shade of> dark than the background.
I think the more robust solution is for me to tweak all the colour
values of bg-dim and bg-alt in the dark themes. Basically to make them
all a bit lighter and easier to spot. Because if we just change the
notmuch face we were discussing, the problem will still surface
elsewhere, be it in existing faces or new ones that may get the bg-dim
background.
I will work on it this evening and report back to you.
All the best,
Prot
--
Protesilaos Stavrou
https://protesilaos.com
Hello Prot,
On 2022-09-22 17:44, Protesilaos Stavrou <info@protesilaos.com> writes:
> A follow-up on my work. I checked for the colour distance and contrast> between bg-main/bg-dim and bg-main/bg-alt. I copy the results further> below.
This is very impressive work, thanks a lot!
> These numbers are not consistent with what you are seeing because the> monitor does not reproduce black sufficiently well. So even though> ef-dark is better than ef-light for this test, it feels worse.
Yes. On my bad monitor, I can easily see all the white checkered
patterns, but not the black squares. I wonder how common an occurrence
this is (monitors having more subjective contrast in light colors than
dark colors).
> The complete results below. They show that we can tweak some values to> have more consistent levels throughout, though we are still missing the> optimal target for dark themes.
I’m actually getting used to switching themes depending on the time of
the day and the ambient light. Currently, I really like ef-duo-light as
it is a light theme but still gentle to the eyes.
Thanks again,
Alan
> From: Alan Schmitt <alan.schmitt@polytechnique.org>> Date: Thu, 22 Sep 2022 17:47:26 +0200>> Hello Prot,
Hello Alan,
> On 2022-09-22 17:44, Protesilaos Stavrou <info@protesilaos.com> writes:>>> A follow-up on my work. I checked for the colour distance and contrast>> between bg-main/bg-dim and bg-main/bg-alt. I copy the results further>> below.>> This is very impressive work, thanks a lot!
You are welcome! The next step is to tweak the relevant colour values
in the interest of consistency.
>> These numbers are not consistent with what you are seeing because the>> monitor does not reproduce black sufficiently well. So even though>> ef-dark is better than ef-light for this test, it feels worse.>> Yes. On my bad monitor, I can easily see all the white checkered> patterns, but not the black squares. I wonder how common an occurrence> this is (monitors having more subjective contrast in light colors than> dark colors).
Can you try Notmuch with ef-dark after evaluating this?
(set-face-attribute 'notmuch-message-summary-face nil :background "#232323")
My plan is to make bg-dim=#232323 instead of #1a1a1a. Then I will
adjust other backgrounds accordingly.
Does that work, or is it still too subtle?
>> The complete results below. They show that we can tweak some values to>> have more consistent levels throughout, though we are still missing the>> optimal target for dark themes.>> I’m actually getting used to switching themes depending on the time of> the day and the ambient light. Currently, I really like ef-duo-light as> it is a light theme but still gentle to the eyes.
I think switching themes to adapt to the environmental light is good for
productivity. I also like ef-duo-light, especially when it is sunny.
> Thanks again,
You are welcome!
All the best,
Prot
--
Protesilaos Stavrou
https://protesilaos.com
> From: Protesilaos Stavrou <info@protesilaos.com>> Date: Fri, 23 Sep 2022 04:41:37 +0300> [... 23 lines elided]>> Yes. On my bad monitor, I can easily see all the white checkered>> patterns, but not the black squares. I wonder how common an occurrence>> this is (monitors having more subjective contrast in light colors than>> dark colors).>> Can you try Notmuch with ef-dark after evaluating this?>> (set-face-attribute 'notmuch-message-summary-face nil :background "#232323")>> My plan is to make bg-dim=#232323 instead of #1a1a1a. Then I will> adjust other backgrounds accordingly.>> Does that work, or is it still too subtle?
Hello again Alan,
A follow-up on the above quote. I have formulated a patch that covers
all dark themes. Check the attached file.
The patch causes other problems: inactive mode lines are not legible
anymore, header lines can be problematic as well, inactive tabs
(tab-bar-mode and tab-line-mode) are harder to read, highlighted diffs
in Magit require changes to the background colours of the added/deleted
lines (focused and focused+refined).
With regard to diffs, changing the colours will have other knock-on
effects, as it also affects diff-mode and Ediff.
All things considered, I cannot make this change right now. It needs
more work to have a holistic understanding of what is affected. Only
then will I be able to determine if this is the right course of action.
I will thus release version 0.6.0 today and keep working on this for the
next version. Will keep you posted.
All the best,
Prot
--
Protesilaos Stavrou
https://protesilaos.com
On 2022-09-23 04:41, Protesilaos Stavrou <info@protesilaos.com> writes:
> Can you try Notmuch with ef-dark after evaluating this?>> (set-face-attribute 'notmuch-message-summary-face nil :background "#232323")>> My plan is to make bg-dim=#232323 instead of #1a1a1a. Then I will> adjust other backgrounds accordingly.>> Does that work, or is it still too subtle?
I think the contrast is very nice with it, thanks!
Alan
> From: Alan Schmitt <alan.schmitt@polytechnique.org>> Date: Fri, 23 Sep 2022 08:17:11 +0200>> On 2022-09-23 04:41, Protesilaos Stavrou <info@protesilaos.com> writes:>>> Can you try Notmuch with ef-dark after evaluating this?>>>> (set-face-attribute 'notmuch-message-summary-face nil :background "#232323")>>>> My plan is to make bg-dim=#232323 instead of #1a1a1a. Then I will>> adjust other backgrounds accordingly.>>>> Does that work, or is it still too subtle?>> I think the contrast is very nice with it, thanks!
Hello again Alan!
As I explained in my other email, the patch could not be merged in its
current state as it requires more changes. But I am not giving up on
it. I will continue working to make those changes happen. With your
feedback here I know now what the nominal target is, so it will be
easier to finalise the process.
I will keep you posted when I am done with it.
All the best,
Prot
--
Protesilaos Stavrou
https://protesilaos.com
Hello Prot,
On 2022-09-25 04:37, Protesilaos Stavrou <info@protesilaos.com> writes:
> As I explained in my other email, the patch could not be merged in its> current state as it requires more changes. But I am not giving up on> it. I will continue working to make those changes happen. With your> feedback here I know now what the nominal target is, so it will be> easier to finalise the process.>> I will keep you posted when I am done with it.
Thanks a lot for working on this. Don’t hesitate to ask if there is
something I should test. There might be some delays because I’m working
remotely two days a week, and the testing should happen on the work
monitor.
Best,
Alan