~protesilaos/ef-themes

4 2

issue with company + company-box

Details
Message ID
<87pmgjw3j9.fsf@m4x.org>
DKIM signature
missing
Download raw message
Hello,

I’ll start with a disclaimer: I’m using doom, so there might be side
effect from there… I did a quick look at the code but could not find any
significant modification, though.

In doom, choosing the company completion framework with the childframe
option results in using company-box
(https://github.com/sebastiencs/company-box/blob/master/company-box.el)

When doing so, the proposed completion open in a childframe. The problem
is that the currently selected completion looks the same than the rest
of the selections, hence it’s impossible to know which one is selected.

Investigating a bit, I found that the company-tooltip faces are the same
for the selection and the text:
Details
Message ID
<87tu5v5cs7.fsf@protesilaos.com>
In-Reply-To
<87pmgjw3j9.fsf@m4x.org> (view parent)
DKIM signature
missing
Download raw message
> From: alan.schmitt@polytechnique.org
> Date: Mon, 29 Aug 2022 16:03:06 +0200
>
> Hello,

Hello Alan,

> [... 25 lines elided]

> Is this an issue with ef-themes or with company-box?

Company is not supported yet by the themes.  I will try to include it
tomorrow morning.  Will keep you posted.

As for company-box, I will not support it for the time being because it
is no longer maintained.  This issue has been open for a long time:
<https://github.com/sebastiencs/company-box/issues/148>.  If the
situation changes, I am happy to add support for it.

All the best,
Prot

-- 
Protesilaos Stavrou
https://protesilaos.com
Details
Message ID
<87edwzw1co.fsf@m4x.org>
In-Reply-To
<87tu5v5cs7.fsf@protesilaos.com> (view parent)
DKIM signature
missing
Download raw message
Hello Prot,

On 2022-08-29 17:45, Protesilaos Stavrou <info@protesilaos.com> writes:

>> Is this an issue with ef-themes or with company-box?
>
> Company is not supported yet by the themes.  I will try to include it
> tomorrow morning.  Will keep you posted.

Great, thanks a lot.

> As for company-box, I will not support it for the time being because it
> is no longer maintained.  This issue has been open for a long time:
> <https://github.com/sebastiencs/company-box/issues/148>.  If the
> situation changes, I am happy to add support for it.

Indeed, I see many pull requests that are being ignored. I’ll stop using
it until it’s maintained again.

Best,

Alan
Details
Message ID
<87wnaqxyxe.fsf@protesilaos.com>
In-Reply-To
<87edwzw1co.fsf@m4x.org> (view parent)
DKIM signature
missing
Download raw message
> From: Alan Schmitt <alan.schmitt@polytechnique.org>
> Date: Mon, 29 Aug 2022 16:50:15 +0200
>
> Hello Prot,

Good morning Alan,

> On 2022-08-29 17:45, Protesilaos Stavrou <info@protesilaos.com> writes:
>
>>> Is this an issue with ef-themes or with company-box?
>>
>> Company is not supported yet by the themes.  I will try to include it
>> tomorrow morning.  Will keep you posted.
>
> Great, thanks a lot.

Just added support for Company in commit b564d1e.  Please let me know if
it works for you.

>> As for company-box, I will not support it for the time being because it
>> is no longer maintained.  This issue has been open for a long time:
>> <https://github.com/sebastiencs/company-box/issues/148>.  If the
>> situation changes, I am happy to add support for it.
>
> Indeed, I see many pull requests that are being ignored. I’ll stop using
> it until it’s maintained again.

Yes, let's hope for the best.

Have a nice day,
Prot

-- 
Protesilaos Stavrou
https://protesilaos.com
Details
Message ID
<87ler6dw88.fsf@m4x.org>
In-Reply-To
<87wnaqxyxe.fsf@protesilaos.com> (view parent)
DKIM signature
missing
Download raw message
Hello Prot,

On 2022-08-30 05:11, Protesilaos Stavrou <info@protesilaos.com> writes:

> Just added support for Company in commit b564d1e.  Please let me know if
> it works for you.

It works great, thanks!

And a quick note for doom users: to track the development version of
ef-themes, you can use this in packages.el.

(package! ef-themes :recipe (:host github :repo "protesilaos/ef-themes" :branch "main"))

Best,

Alan
Reply to thread Export thread (mbox)