~protesilaos/ef-themes

Eshel Yaron: 1
 Minor doc fixes

 2 files changed, 44 insertions(+), 43 deletions(-)
Protesilaos Stavrou <info@protesilaos.com> writes:
Next
Export patchset (mbox)
How do I use this?

Copy & paste the following snippet into your terminal to import this patchset into git:

curl -s https://lists.sr.ht/~protesilaos/ef-themes/patches/42030/mbox | git am -3
Learn more about email & git

[PATCH] Minor doc fixes Export this patch

* README.org (Preview theme colors): Fix typo.
(Sample configuration, Option for headings):
* ef-themes.el (ef-themes-headings): Prefer saying '(foo bar baz)'
over '(foo . (bar baz))' where appropriate; say "non-nil non-list
value" to describe such values.
---
 README.org   | 54 ++++++++++++++++++++++++++--------------------------
 ef-themes.el | 33 ++++++++++++++++----------------
 2 files changed, 44 insertions(+), 43 deletions(-)

diff --git a/README.org b/README.org
index e0599b6..987cb19 100644
--- a/README.org
+++ b/README.org
@@ -137,15 +137,15 @@ * Sample configuration
(setq ef-themes-to-toggle '(ef-summer ef-winter))

(setq ef-themes-headings ; read the manual's entry or the doc string
      '((0 . (variable-pitch light 1.9))
        (1 . (variable-pitch light 1.8))
        (2 . (variable-pitch regular 1.7))
        (3 . (variable-pitch regular 1.6))
        (4 . (variable-pitch regular 1.5))
        (5 . (variable-pitch 1.4)) ; absence of weight means `bold'
        (6 . (variable-pitch 1.3))
        (7 . (variable-pitch 1.2))
        (t . (variable-pitch 1.1))))
      '((0 variable-pitch light 1.9)
        (1 variable-pitch light 1.8)
        (2 variable-pitch regular 1.7)
        (3 variable-pitch regular 1.6)
        (4 variable-pitch regular 1.5)
        (5 variable-pitch 1.4) ; absence of weight means `bold'
        (6 variable-pitch 1.3)
        (7 variable-pitch 1.2)
        (t variable-pitch 1.1)))

;; They are nil by default...
(setq ef-themes-mixed-fonts t
@@ -334,12 +334,12 @@ ** Option for headings

#+begin_src emacs-lisp
(setq ef-themes-headings
      '((1 . (light variable-pitch 1.5))
        (2 . (regular 1.3))
        (3 . (1.1))
        (agenda-date . (1.3))
        (agenda-structure . (variable-pitch light 1.8))
        (t . (variable-pitch))))
      '((1 light variable-pitch 1.5)
        (2 regular 1.3)
        (3 1.1)
        (agenda-date 1.3)
        (agenda-structure variable-pitch light 1.8)
        (t variable-pitch)))
#+end_src

By default (a ~nil~ value for this variable), all headings have a bold
@@ -381,25 +381,25 @@ ** Option for headings

#+begin_src emacs-lisp
(setq ef-themes-headings
      '((1 . (light variable-pitch 1.5))
        (2 . (regular 1.3))
        (3 . (1.1))
        (t . (variable-pitch))))
      '((1 light variable-pitch 1.5)
        (2 regular 1.3)
        (3 1.1)
        (t variable-pitch)))
#+end_src

When defining the styles per heading level, it is possible to
pass a non-~nil~ value (t) instead of a list of properties.  This
will retain the original aesthetic for that level.  For example:
When defining the styles per heading level, it is possible to pass a
non-~nil~ non-list value (e.g. ~t~) instead of a list of properties.
This will retain the original aesthetic for that level.  For example:

#+begin_src emacs-lisp
(setq ef-themes-headings
      '((1 . t)           ; keep the default style
        (2 . (variable-pitch 1.2))
        (t . (variable-pitch)))) ; style for all unspecified headings
        (2 variable-pitch 1.2)
        (t variable-pitch))) ; style for all unspecified headings

(setq ef-themes-headings
      '((1 . (variable-pitch 1.6))
        (2 . (1.3))
      '((1 variable-pitch 1.6)
        (2 1.3)
        (t . t))) ; default style for all unspecified levels
#+end_src

@@ -786,7 +786,7 @@ * Preview theme colors

The name of the buffer describes the given Ef theme and what the
contents are, such as =*ef-summer-list-colors*= for named colors and
==*ef-summer-list-mappings*= for the semantic color mappings.
=*ef-summer-list-mappings*= for the semantic color mappings.

* Use colors from the active Ef theme
:PROPERTIES:
diff --git a/ef-themes.el b/ef-themes.el
index 905081d..bd517cf 100644
--- a/ef-themes.el
+++ b/ef-themes.el
@@ -188,12 +188,12 @@ (defcustom ef-themes-headings nil
available properties:

    (setq ef-themes-headings
          (quote ((1 . (light variable-pitch 1.5))
                  (2 . (regular 1.3))
                  (3 . (1.1))
                  (agenda-date . (1.3))
                  (agenda-structure . (variable-pitch light 1.8))
                  (t . (variable-pitch)))))
          (quote ((1 light variable-pitch 1.5)
                  (2 regular 1.3)
                  (3 1.1)
                  (agenda-date 1.3)
                  (agenda-structure variable-pitch light 1.8)
                  (t variable-pitch))))

By default (a nil value for this variable), all headings have a
bold typographic weight, a font family that is the same as the
@@ -232,23 +232,24 @@ (defcustom ef-themes-headings nil
In user configuration files the form may look like this:

    (setq ef-themes-headings
          (quote ((1 . (light variable-pitch 1.5))
                  (2 . (regular 1.3))
                  (3 . (1.1))
                  (t . (variable-pitch)))))
          (quote ((1 light variable-pitch 1.5)
                  (2 regular 1.3)
                  (3 1.1)
                  (t variable-pitch))))

When defining the styles per heading level, it is possible to
pass a non-nil value (t) instead of a list of properties.  This
will retain the original aesthetic for that level.  For example:
pass a non-nil non-list value (e.g. t) instead of a list of
properties.  This will retain the original aesthetic for that
level.  For example:

    (setq ef-themes-headings
          (quote ((1 . t)           ; keep the default style
                  (2 . (variable-pitch 1.2))
                  (t . (variable-pitch))))) ; style for all other headings
                  (2 variable-pitch 1.2)
                  (t variable-pitch)))) ; style for all other headings

    (setq ef-themes-headings
          (quote ((1 . (variable-pitch 1.6))
                  (2 . (1.3))
          (quote ((1 variable-pitch 1.6)
                  (2 1.3)
                  (t . t)))) ; default style for all other levels"
  :group 'ef-themes
  :package-version '(ef-themes . "0.10.0")
-- 
2.41.0
Thank you Eshel!  I just installed your patch.  Also updated the
manual's "Acknowledgements" to mention your name.

Can you please remind me if you have assigned copyright to the Free
Software Foundation?  It is not required for this patch, as it is within
the limits, though you will need to have the paperwork done for next
time.

All the best,
Prot