~protesilaos/general-issues

4 3

spacious-padding: tab-bar-mode breakage

Details
Message ID
<87jzovrvcj.fsf@esprit.tn>
DKIM signature
missing
Download raw message
Hi,

I love, love, love spacious padding. Thank you for this gem.

I recently found that spacious-padding-mode breaks the appearance of
tabs, the lower half of tabs and the padding seem to overlap.

I was able to reproduce this with `emacs --quick` with version:

   GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38,
   cairo version 1.17.8)

using the following snippet:

   (add-to-list 'load-path "/path/to/spacious-padding/")
   (require 'spacious-padding)
   (spacious-padding-mode)
   (tab-bar-mode)

Kind regards,
-- 
Aziz
Details
Message ID
<87bka572qy.fsf@protesilaos.com>
In-Reply-To
<87jzovrvcj.fsf@esprit.tn> (view parent)
DKIM signature
missing
Download raw message
> From: Taha Aziz Ben Ali <tahaaziz.benali@esprit.tn>
> Date: Sun, 31 Dec 2023 02:53:16 +0100
>
> Hi,

Hello Aziz,

> I love, love, love spacious padding. Thank you for this gem.

You are welcome!

> I recently found that spacious-padding-mode breaks the appearance of
> tabs, the lower half of tabs and the padding seem to overlap.
>
> I was able to reproduce this with `emacs --quick` with version:

> [... 12 lines elided]

I cannot reproduce this on Emacs 30. I will have to check. Does it
happen with any theme, or only with a specific one? This will help me
narrow down the cause of the issue.

All the best,
Protesilaos (or simply "Prot")

-- 
Protesilaos Stavrou
https://protesilaos.com
Details
Message ID
<878r57lc5b.fsf@rbenencia.name>
In-Reply-To
<87bka572qy.fsf@protesilaos.com> (view parent)
DKIM signature
missing
Download raw message
Hello,

Protesilaos Stavrou <info@protesilaos.com> writes:
>> I love, love, love spacious padding. Thank you for this gem.
>
> You are welcome!

Adding to the kudos for yet another wonderful package. Thanks for all your work!

>> I recently found that spacious-padding-mode breaks the appearance of
>> tabs, the lower half of tabs and the padding seem to overlap.
>>
>> I was able to reproduce this with `emacs --quick` with version:
>
>> [... 12 lines elided]
>
> I cannot reproduce this on Emacs 30. I will have to check. Does it
> happen with any theme, or only with a specific one? This will help me
> narrow down the cause of the issue.

I can reproduce this issue with many themes, o no theme at all. I'm
running this version: GNU Emacs 29.1 (build 2, x86_64-pc-linux-gnu, GTK+
Version 3.24.38, cairo version 1.16.0) of 2023-08-30, modified by Debian.

Interestingly, even if I restart Emacs and spacious-padding is not
enabled/loaded, the tab-bar remains broken. I've played a bit with
spacious-padding-widths and found out that setting internal-border-width
to 0 fixes the issue. I hope this information aids your debugging
efforts.

Thanks,
-- 
Raúl Benencia
Details
Message ID
<CAC5vAOT_g8NwDuaNYDUeOAfsde3WfNoezYsk6wbLFDtcXvaVWw@mail.gmail.com>
In-Reply-To
<878r57lc5b.fsf@rbenencia.name> (view parent)
DKIM signature
pass
Download raw message
On Sat, Jan 27, 2024 at 1:51 PM Raúl Benencia <id@rbenencia.name> wrote:
>
> Hello,
>
> Protesilaos Stavrou <info@protesilaos.com> writes:
> >> I love, love, love spacious padding. Thank you for this gem.
> >
> > You are welcome!
>
> Adding to the kudos for yet another wonderful package. Thanks for all your work!
>
> >> I recently found that spacious-padding-mode breaks the appearance of
> >> tabs, the lower half of tabs and the padding seem to overlap.
> >>
> >> I was able to reproduce this with `emacs --quick` with version:
> >
> >> [... 12 lines elided]
> >
> > I cannot reproduce this on Emacs 30. I will have to check. Does it
> > happen with any theme, or only with a specific one? This will help me
> > narrow down the cause of the issue.
>
> I can reproduce this issue with many themes, o no theme at all. I'm
> running this version: GNU Emacs 29.1 (build 2, x86_64-pc-linux-gnu, GTK+
> Version 3.24.38, cairo version 1.16.0) of 2023-08-30, modified by Debian.

I've noticed this same behavior in Emacs 29.1 but only when running a
Pure GTK (--with-pgtk) build. When using a GTK/X11
(--with-x-toolkit=gtk3) build the tab bar appears correctly. Which may
mean this isn't a spacious-padding issue at all, but something odd
with the PGTK implementation.

--
Byron Clark
Details
Message ID
<871qa2xbiz.fsf@protesilaos.com>
In-Reply-To
<878r57lc5b.fsf@rbenencia.name> (view parent)
DKIM signature
pass
Download raw message
> From: Raúl Benencia <id@rbenencia.name>
> Date: Tue,  2 Jan 2024 12:21:20 -0800
>
> Hello,

Hello everyone,

> [... 22 lines elided]

> Interestingly, even if I restart Emacs and spacious-padding is not
> enabled/loaded, the tab-bar remains broken. I've played a bit with
> spacious-padding-widths and found out that setting internal-border-width
> to 0 fixes the issue. I hope this information aids your debugging
> efforts.

It seems that some old values are stored by the Custom interface. Are
you loading the 'custom-file' somewhere in your configuration? Or do you
have a 'customize' somewhere?

Again, I cannot reproduce this on Emacs 30, but I will install Emacs 29
to check.

Have a nice day,
Protesilaos (or simply "Prot")

-- 
Protesilaos Stavrou
https://protesilaos.com
Reply to thread Export thread (mbox)