Hi Prot,
Just wanted to check in on the state of dired preview. Last we
discussed, you mentioned being unsatisfied with some of the design,
specifically involving preview window display. I held off on submitting
patches for large file and media previews as a result.
Is the package in a state where you are ready to accept patches? The
large file preview patch has been ready for a while and I can send it.
I haven't worked on media file previews yet, but I have a plan in place
and can get started on it.
No worries if you're busy with other projects -- I was just curious to
know if this was a good time to start working on media previews.
Karthik
> From: Karthik Chikmagalur <contact@karthinks.com>> Date: Tue, 5 Sep 2023 16:56:38 -0700>> Hi Prot,
Hello Karthik,
I was slow to respond. Now I am back online full-time.
> Just wanted to check in on the state of dired preview. Last we> discussed, you mentioned being unsatisfied with some of the design,> specifically involving preview window display. I held off on submitting> patches for large file and media previews as a result.
Indeed, this is how I remember it. I can work on this tomorrow and over
the weekend.
> Is the package in a state where you are ready to accept patches?
In principle yes, though I think it is better if we fix the groundwork
so that whatever we add on top does not to be changed afterwards.
Though I don't mind if we add stuff now and adjust it where necessary
(all this assumes the added code needs to be adapted, otherwise we are
good).
> The large file preview patch has been ready for a while and I can> send it. I haven't worked on media file previews yet, but I have a> plan in place and can get started on it.
I am happy to merge it right away. It depends on if you think it is the
right time or if you prefer to wait for the change to the window
handling. In general, I am flexible and want to cooperate on the most
suitable way forward.
> No worries if you're busy with other projects -- I was just curious to> know if this was a good time to start working on media previews.
I did not have regular Internet access because I had no electricity at
home. Now I do and we are good to go.
Thanks again for working on this!
Prot
--
Protesilaos Stavrou
https://protesilaos.com
Hi Prot,
Sorry about the delayed response -- I wasn't busy, I just missed your reply!
>> Is the package in a state where you are ready to accept patches?>> In principle yes, though I think it is better if we fix the groundwork> so that whatever we add on top does not to be changed afterwards.> Though I don't mind if we add stuff now and adjust it where necessary> (all this assumes the added code needs to be adapted, otherwise we are> good).
This depends on what kinds of changes you expect to make to the
groundwork. I am about 70 commits behind now, I will go through the
latest changes to the base package and see if we can merge VLF support.
>> The large file preview patch has been ready for a while and I can>> send it. I haven't worked on media file previews yet, but I have a>> plan in place and can get started on it.>> I am happy to merge it right away. It depends on if you think it is the> right time or if you prefer to wait for the change to the window> handling. In general, I am flexible and want to cooperate on the most> suitable way forward.
Very well. I'll send the VLF patch and start work on media previews in
the meantime. I'm assuming no one else is working on media previews
right now, so there won't be any duplication of effort.
>> No worries if you're busy with other projects -- I was just curious to>> know if this was a good time to start working on media previews.>> I did not have regular Internet access because I had no electricity at> home. Now I do and we are good to go.
Indeed, I was following along with your cabin building vlogs. Glad to
hear you're back online again.
Karthik
> From: Karthik Chikmagalur <contact@karthinks.com>> Date: Tue, 3 Oct 2023 18:50:50 -0700>> Hi Prot,
Hello Karthik,
> Sorry about the delayed response -- I wasn't busy, I just missed your reply!
That's fine, no worries!
>>> Is the package in a state where you are ready to accept patches?>>>> In principle yes, though I think it is better if we fix the groundwork>> so that whatever we add on top does not to be changed afterwards.>> Though I don't mind if we add stuff now and adjust it where necessary>> (all this assumes the added code needs to be adapted, otherwise we are>> good).>> This depends on what kinds of changes you expect to make to the> groundwork. I am about 70 commits behind now, I will go through the> latest changes to the base package and see if we can merge VLF support.
I merged it. All good! Even if there are pending issues, this gives us
> [... 18 lines elided]>> I did not have regular Internet access because I had no electricity at>> home. Now I do and we are good to go.>> Indeed, I was following along with your cabin building vlogs. Glad to> hear you're back online again.
It's a work-in-progress, though things are moving in the right
direction. I still need to reinforce the insulation as there are parts
which leak right now when there is a heavy rainfall.
Have a nice day,
Prot
--
Protesilaos Stavrou
https://protesilaos.com