Add new map for repeat-mode v1 APPLIED

Lucy McPhail: 1
 Add new map for repeat-mode

 1 files changed, 10 insertions(+), 0 deletions(-)

Hi Prot, and you're welcome!

Thanks for the explanation!  I expected it to be tricky...

Lucy McPhail <lucy.mcphail.p@gmail.com>

2 years ago

I'm sure it can be done but it seems like overkill, and besides,
everywhere I looked in Emacs it's done the same way. I suppose a user
could just change the map if they wanted to.

Next

I installed your patch and included your name in the manual's
"Acknowledgements" section.

Lucy McPhail <lucy.mcphail.p@gmail.com>

2 years ago

Thank you!

Next

Since this is a small change, it does not require copyright assignment
to the Free Software Foundation.  Though note that larger changes do
need that (I can send you the application form, if needed).

Indeed.  It is not a big deal.  In the worst case scenario, we will get
a bug report to which we wil react accordingly.  No worries!

[PATCH] Add new map for repeat-mode Export this patch

---
 logos.el | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/logos.el b/logos.el
index 33b2240..9b17964 100644
--- a/logos.el
+++ b/logos.el
@@ -360,6 +360,16 @@ alternate, thus toggling MODE."
 (defvar logos-focus-mode-map (make-sparse-keymap)
   "The keymap of `logos-focus-mode'.")
 
+(defvar logos-repeat-map
+  (let ((map (make-sparse-keymap)))
+    (define-key map "]" 'logos-forward-page-dwim)
+    (define-key map "[" 'logos-backward-page-dwim)
+    map)
+  "Keymap to repeat logos key sequences.  Used in `repeat-mode'.")

Protesilaos Stavrou <info@protesilaos.com>

2 years ago

Can we use the remap mechanism here?  Like we do in the sample
configuration?

Lucy McPhail <lucy.mcphail.p@gmail.com>

2 years ago

I don't think we can. When either command is called, repeat-mode
activates the keymap so that you can press [ or ] to repeat the command.
If we used the remap mechanism instead, you would have to repeat the
whole sequence, which defeats the purpose of repeat-mode. That said, if
one were to use some other key binding, it wouldn't get in the way, but
you would be able to press [ and ] next anyway to repeat the command.

Lucy

    (define-key map [remap forward-page] #'logos-forward-page-dwim)
    (define-key map [remap backward-page] #'logos-backward-page-dwim)

Not sure if repeat-mode has any special requirement in this regard.

All the best,
Protesilaos (or simply "Prot")

+
+(put #'logos-forward-page-dwim 'repeat-map 'logos-repeat-map)
+(put #'logos-backward-page-dwim 'repeat-map 'logos-repeat-map)
+
 (define-minor-mode logos-focus-mode
   "Buffer-local mode for focused editing.
 When enabled it sets the buffer-local value of these user
-- 
2.31.0

Protesilaos Stavrou <info@protesilaos.com>

2 years ago

Hello Lucy and thanks for the patch!