Hey Prot,

a minor usability detail - it would be great if the current day headline
in the weekly Org agenda could stand out a little bit more. Sometimes
when moving around in the agenda I get lost a little bit.
The current day uses the same background as hl-line, which is too dim
for my taste. (For hl-line I like the subtle highlight since it is only
supposed as a small visual aid to locate the cursor more quickly.)

Daniel

> From: Daniel Mendler <mail@daniel-mendler.de>
> Date: Sat, 16 Jul 2022 13:52:53 +0200
>
> Hey Prot,

Hello Daniel,

> a minor usability detail - it would be great if the current day headline
> in the weekly Org agenda could stand out a little bit more. Sometimes
> when moving around in the agenda I get lost a little bit.
> The current day uses the same background as hl-line, which is too dim
> for my taste. (For hl-line I like the subtle highlight since it is only
> supposed as a small visual aid to locate the cursor more quickly.)

Good point!  Here the highlighting must call attention to itself, unlike
the default hl-line.

Do you think we should just use a bit more intense grey?  Otherwise we
can try we a [subtle] coloured background.

Personally, I do not like a prominent grey background with a coloured
foreground in such a tight space.  It gives the perception that the
colour is too desaturated.

I will try everything, of course.  Just want to read your thoughts on
the matter, in case you have any preference. 

[ The surface area matters as it changes the perception. ]

All the best,
Prot

-- 
Protesilaos Stavrou
https://protesilaos.com

> Good point!  Here the highlighting must call attention to itself, unlike
> the default hl-line.
> 
> Do you think we should just use a bit more intense grey?  Otherwise we
> can try we a [subtle] coloured background.

I would like to have some color, either colored foreground or colored
background. A gray background only seems a bit to subtle. I don't have a
particular design in mind, - I just wanted to put this up for
discussion. Probably you have some precedent in other areas which can be
adapted.

Daniel

> From: Daniel Mendler <mail@daniel-mendler.de>
> Date: Sat, 16 Jul 2022 14:48:57 +0200
>
>> Good point!  Here the highlighting must call attention to itself, unlike
>> the default hl-line.
>> 
>> Do you think we should just use a bit more intense grey?  Otherwise we
>> can try we a [subtle] coloured background.
>
> I would like to have some color, either colored foreground or colored
> background. A gray background only seems a bit to subtle. I don't have a
> particular design in mind, - I just wanted to put this up for
> discussion. Probably you have some precedent in other areas which can be
> adapted.

Understood!

Does this modest change from bg-inactive to bg-special-cold add enough
colour?  It is blue/grey now but maybe it is enough?

If not, we will go for a more pronounced colour.

[ I will also refill those lines separately. ]


 modus-themes.el | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/modus-themes.el b/modus-themes.el
index 3e2769e..3d969fc 100644
--- a/modus-themes.el
+++ b/modus-themes.el
@@ -6488,14 +6488,11 @@ ;;;;; org
     `(org-agenda-column-dateline ((,class :background ,bg-alt)))
     `(org-agenda-current-time ((,class :foreground ,blue-alt-other-faint)))
     `(org-agenda-date ((,class ,@(modus-themes--agenda-date cyan fg-main))))
-    `(org-agenda-date-today ((,class ,@(modus-themes--agenda-date cyan fg-main
-                                                                  nil nil
-                                                                  bg-inactive t t))))
-    `(org-agenda-date-weekend ((,class ,@(modus-themes--agenda-date cyan-alt-other-faint fg-alt
-                                                                    cyan fg-main))))
-    `(org-agenda-date-weekend-today ((,class ,@(modus-themes--agenda-date cyan-alt-other-faint fg-alt
-                                                                          cyan fg-main
-                                                                          bg-inactive t t))))
+    `(org-agenda-date-today
+      ((,class ,@(modus-themes--agenda-date cyan fg-main nil nil bg-special-cold t t))))
+    `(org-agenda-date-weekend ((,class ,@(modus-themes--agenda-date cyan-alt-other-faint fg-alt cyan fg-main))))
+    `(org-agenda-date-weekend-today
+      ((,class ,@(modus-themes--agenda-date cyan-alt-other fg-alt cyan fg-main bg-special-cold t t))))
     `(org-agenda-diary ((,class :inherit org-agenda-calendar-sexp)))
     `(org-agenda-dimmed-todo-face ((,class :inherit shadow)))
     `(org-agenda-done ((,class :inherit modus-themes-grue-nuanced)))


-- 
Protesilaos Stavrou
https://protesilaos.com

On 7/16/22 15:48, Protesilaos Stavrou wrote:
> Understood!
> 
> Does this modest change from bg-inactive to bg-special-cold add enough
> colour?  It is blue/grey now but maybe it is enough?
> 
> If not, we will go for a more pronounced colour.

Thanks. It looks good like this.

Daniel

> From: Daniel Mendler <mail@daniel-mendler.de>
> Date: Sat, 16 Jul 2022 16:44:54 +0200
>
> On 7/16/22 15:48, Protesilaos Stavrou wrote:
>> Understood!
>> 
>> Does this modest change from bg-inactive to bg-special-cold add enough
>> colour?  It is blue/grey now but maybe it is enough?
>> 
>> If not, we will go for a more pronounced colour.
>
> Thanks. It looks good like this.

Just pushed the change.  Thank you!

-- 
Protesilaos Stavrou
https://protesilaos.com