~protesilaos/modus-themes

3 2

Re: [Bug?] Headings override doesn't work any more

Details
Message ID
<874jszvk5g.fsf@protesilaos.com>
DKIM signature
missing
Download raw message
> From: Marko Kocic <m@euptera.com>
> Date: Mon,  9 Jan 2023 15:37:47 +0100
>
> Hi Protesilaos,

Hi Marko,

[ I am adding the mailing list to the recipients as it was missing from
  your reply. ]

> I installed from elpa. Here's what package info says:
>
> Package modus-themes is installed.
>
>      Status: Installed in ‘modus-themes-20230109.43/’ (unsigned). Delete
>     Version: 20230109.43
>      Commit: 0dc7854103ecd7eba4b57eb7ce8eb05628cc9fbf
>     Summary: Elegant, highly legible and customizable themes
>    Requires: emacs-27.1
>     Website: https://git.sr.ht/~protesilaos/modus-themes
>    Keywords: faces theme accessibility 
>  Maintainer: Modus-Themes Development <~protesilaos/modus-themes@lists.sr.ht>
>      Author: Protesilaos Stavrou <info@protesilaos.com>
> Other versions: 20230109.43 (melpa), 3.0.0 (gnu).
>
> I'm pretty sure it was updated today, since my config stopped working,
> and I had to rework use-package according to the latest docs ;)
>
> Just now, I deleted manually eln-cache and elpa files from disk, and
> let use-package pull the latest version again just to make sure
> there's no remaining of the old version. Same behaviour.

This is very strange...  I copied your code in my config and restarted
Emacs: the headings are using the regular weight, as expected.

What happens if you re-load the theme?

-- 
Protesilaos Stavrou
https://protesilaos.com

Re: [Bug?] Headings override doesn't work any more

Marko Kocic <m@euptera.com>
Details
Message ID
<78972262.266735.1673276535581@office.mailbox.org>
In-Reply-To
<874jszvk5g.fsf@protesilaos.com> (view parent)
DKIM signature
missing
Download raw message
Hi Protesilaos,

reloading theme doesn't help. I still see bolded entries in org-agenda. I get the same behaviour on both Windows and Linux, both in console and GUI. Both system using Emacs-28.2 with the latest elpa versions of modus-themes. 

For a context, my (maybe) relevant parts of the org setup looks like this:

(use-package org
  :pin gnu
  :ensure t :defer t
  :mode (("\\.org$" . org-mode))
  :config
  (add-to-list 'org-modules 'org-tempo)
  (add-to-list 'org-modules 'org-habit)
  (add-hook 'org-mode-hook 'visual-line-mode)
  (set-face-attribute 'org-block nil :inherit 'default)
  (set-face-attribute 'org-block-begin-line nil :inherit 'default)
  (set-face-attribute 'org-table nil :inherit 'default)
  (set-face-attribute 'org-verbatim nil :inherit 'default)
  :custom
  (org-pretty-entities t)
  (org-hide-emphasis-markers t)

Best regards,
Marko

> Protesilaos Stavrou <info@protesilaos.com> hat am 09.01.2023 15:48 CET geschrieben:
> 
>  
> > From: Marko Kocic <m@euptera.com>
> > Date: Mon,  9 Jan 2023 15:37:47 +0100
> >
> > Hi Protesilaos,
> 
> Hi Marko,
> 
> [ I am adding the mailing list to the recipients as it was missing from
>   your reply. ]
> 
> > I installed from elpa. Here's what package info says:
> >
> > Package modus-themes is installed.
> >
> >      Status: Installed in ‘modus-themes-20230109.43/’ (unsigned). Delete
> >     Version: 20230109.43
> >      Commit: 0dc7854103ecd7eba4b57eb7ce8eb05628cc9fbf
> >     Summary: Elegant, highly legible and customizable themes
> >    Requires: emacs-27.1
> >     Website: https://git.sr.ht/~protesilaos/modus-themes
> >    Keywords: faces theme accessibility 
> >  Maintainer: Modus-Themes Development <~protesilaos/modus-themes@lists.sr.ht>
> >      Author: Protesilaos Stavrou <info@protesilaos.com>
> > Other versions: 20230109.43 (melpa), 3.0.0 (gnu).
> >
> > I'm pretty sure it was updated today, since my config stopped working,
> > and I had to rework use-package according to the latest docs ;)
> >
> > Just now, I deleted manually eln-cache and elpa files from disk, and
> > let use-package pull the latest version again just to make sure
> > there's no remaining of the old version. Same behaviour.
> 
> This is very strange...  I copied your code in my config and restarted
> Emacs: the headings are using the regular weight, as expected.
> 
> What happens if you re-load the theme?
> 
> -- 
> Protesilaos Stavrou
> https://protesilaos.com

Re: [Bug?] Headings override doesn't work any more

Details
Message ID
<87y1qbu4k3.fsf@protesilaos.com>
In-Reply-To
<78972262.266735.1673276535581@office.mailbox.org> (view parent)
DKIM signature
missing
Download raw message
> From: Marko Kocic <m@euptera.com>
> Date: Mon,  9 Jan 2023 16:02:15 +0100
>
> Hi Protesilaos,
>
> reloading theme doesn't help. I still see bolded entries in
> org-agenda. I get the same behaviour on both Windows and Linux, both
> in console and GUI. Both system using Emacs-28.2 with the latest elpa
> versions of modus-themes.

How about the Custom snippet that is normally appended to the end of the
init.el or placed inside the 'custom-file'?  Perhaps some variable is
set there which overrides what you have in your package declaration.  It
could be another value for 'modus-themes-headings' or face customisation
that are relevant to this.

> For a context, my (maybe) relevant parts of the org setup looks like this:
>
> (use-package org
>   :pin gnu
>   :ensure t :defer t
>   :mode (("\\.org$" . org-mode))
>   :config
>   (add-to-list 'org-modules 'org-tempo)
>   (add-to-list 'org-modules 'org-habit)
>   (add-hook 'org-mode-hook 'visual-line-mode)
>   (set-face-attribute 'org-block nil :inherit 'default)
>   (set-face-attribute 'org-block-begin-line nil :inherit 'default)
>   (set-face-attribute 'org-table nil :inherit 'default)
>   (set-face-attribute 'org-verbatim nil :inherit 'default)
>   :custom
>   (org-pretty-entities t)
>   (org-hide-emphasis-markers t)

This looks fine as well.

-- 
Protesilaos Stavrou
https://protesilaos.com

Re: [Bug?] Headings override doesn't work any more

Marko Kocic <m@euptera.com>
Details
Message ID
<446885154.275655.1673280746249@office.mailbox.org>
In-Reply-To
<87y1qbu4k3.fsf@protesilaos.com> (view parent)
DKIM signature
missing
Download raw message
Hi Protesilaos,

I don't even load custom-file. I manually executed startup script step by step, and there's no modus-themes-headings variable before loading modus-themes, and after loading it, it's set up correctly. However, I still see today's entries in org-agenda as bold.

Here you can find a link to the short version of my Emacs init file, which still shows the issue:
https://gist.github.com/markokocic/62d1dfc5087de4eab865750682b4e7d9

Best regards,
Marko
> Protesilaos Stavrou <info@protesilaos.com> hat am 09.01.2023 16:10 CET geschrieben:
> 
>  
> > From: Marko Kocic <m@euptera.com>
> > Date: Mon,  9 Jan 2023 16:02:15 +0100
> >
> > Hi Protesilaos,
> >
> > reloading theme doesn't help. I still see bolded entries in
> > org-agenda. I get the same behaviour on both Windows and Linux, both
> > in console and GUI. Both system using Emacs-28.2 with the latest elpa
> > versions of modus-themes.
> 
> How about the Custom snippet that is normally appended to the end of the
> init.el or placed inside the 'custom-file'?  Perhaps some variable is
> set there which overrides what you have in your package declaration.  It
> could be another value for 'modus-themes-headings' or face customisation
> that are relevant to this.
> 
> > For a context, my (maybe) relevant parts of the org setup looks like this:
> >
> > (use-package org
> >   :pin gnu
> >   :ensure t :defer t
> >   :mode (("\\.org$" . org-mode))
> >   :config
> >   (add-to-list 'org-modules 'org-tempo)
> >   (add-to-list 'org-modules 'org-habit)
> >   (add-hook 'org-mode-hook 'visual-line-mode)
> >   (set-face-attribute 'org-block nil :inherit 'default)
> >   (set-face-attribute 'org-block-begin-line nil :inherit 'default)
> >   (set-face-attribute 'org-table nil :inherit 'default)
> >   (set-face-attribute 'org-verbatim nil :inherit 'default)
> >   :custom
> >   (org-pretty-entities t)
> >   (org-hide-emphasis-markers t)
> 
> This looks fine as well.
> 
> -- 
> Protesilaos Stavrou
> https://protesilaos.com
Reply to thread Export thread (mbox)