~protesilaos/modus-themes

6 4

Magit blame faces for the modus-themes

Protesilaos Stavrou <public@protesilaos.com>
Details
Message ID
<87bkuv23vl.fsf@protesilaos.com>
DKIM signature
pass
Download raw message
Patch: +4 -4
Hello folks,

I am opening this thread to gather your thoughts on Magit blame.  Right
now, the headings it introduces use a subtle grey background and apply
different colours to the author, date, hash, and commit summary.  I
think this works, but may be a bit too subtle and/or hard to discern
depending on the density of the blame headings.

I am experimenting with adding some more colour, specifically background
values for the author and date fields.  Not too intense, but enough to
add more structure.  This is the diff:


modus-themes.el | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/modus-themes.el b/modus-themes.el
index 3e9ed32..ac2d672 100644
--- a/modus-themes.el
+++ b/modus-themes.el
@@ -5997,14 +5997,14 @@ ;;;;; magit
    `(magit-bisect-bad ((,class :inherit error)))
    `(magit-bisect-good ((,class :inherit success)))
    `(magit-bisect-skip ((,class :inherit warning)))
    `(magit-blame-date ((,class :foreground ,blue)))
    `(magit-blame-date ((,class :background ,bg-special-cold :foreground ,fg-special-cold)))
    `(magit-blame-dimmed ((,class :inherit (shadow modus-themes-reset-hard))))
    `(magit-blame-hash ((,class :foreground ,fg-special-warm)))
    `(magit-blame-heading ((,class :inherit modus-themes-reset-hard :background ,bg-alt :extend t)))
    `(magit-blame-heading ((,class :inherit (bold modus-themes-reset-hard) :background ,bg-header :extend t)))
    `(magit-blame-highlight ((,class :inherit modus-themes-nuanced-cyan)))
    `(magit-blame-margin ((,class :inherit (magit-blame-highlight modus-themes-reset-hard))))
    `(magit-blame-name ((,class :foreground ,magenta-alt-other)))
    `(magit-blame-summary ((,class :foreground ,cyan-alt-other)))
    `(magit-blame-name ((,class :background ,bg-special-calm :foreground ,fg-special-calm)))
    `(magit-blame-summary ((,class :foreground ,fg-main)))
    ;; ;; NOTE 2021-11-23: we do not set the `magit-branch-current'
    ;; ;; because its definition checks if the :box attribute can be set
    ;; ;; and if not, it uses :inverse-video.  Useful for terminal


What do you think?

1. Do you like this style?

2. Maybe you like the direction but want it to be tweaked some more?  If
  so, what feels off to you?

3. Do you prefer the status quo?

4. Something else?

Thank you for your time.

All the best,
Prot

-- 
Protesilaos Stavrou
https://protesilaos.com
Details
Message ID
<87v8t3iqt4.fsf@cassou.me>
In-Reply-To
<87bkuv23vl.fsf@protesilaos.com> (view parent)
DKIM signature
missing
Download raw message
Hi Prot,

Protesilaos Stavrou <public@protesilaos.com> writes:
> 1. Do you like this style?
> 2. Maybe you like the direction but want it to be tweaked some more?
>   If so, what feels off to you?
> 3. Do you prefer the status quo?
> 4. Something else?

both styles look good to me and I have no preference. I'm not the right
person to ask about color choice 😃. I'm sorry I can't be of much help
here.

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill
Protesilaos Stavrou <public@protesilaos.com>
Details
Message ID
<87fsk7ab5r.fsf@protesilaos.com>
In-Reply-To
<87v8t3iqt4.fsf@cassou.me> (view parent)
DKIM signature
pass
Download raw message
> From: Damien Cassou <damien@cassou.me>
> Date: Tue, 14 Jun 2022 10:37:27 +0200
>
> Hi Prot,

Hello Damien,

> Protesilaos Stavrou <public@protesilaos.com> writes:
>> 1. Do you like this style?
>> 2. Maybe you like the direction but want it to be tweaked some more?
>>   If so, what feels off to you?
>> 3. Do you prefer the status quo?
>> 4. Something else?
>
> both styles look good to me and I have no preference. I'm not the right
> person to ask about color choice 😃. I'm sorry I can't be of much help
> here.

That's good to know!  As long as it does not bother you, I know it might
not be a bad idea to try it.

All the best,
Prot

-- 
Protesilaos Stavrou
https://protesilaos.com
Details
Message ID
<87wndip988.fsf@dejaeghe.re>
In-Reply-To
<87bkuv23vl.fsf@protesilaos.com> (view parent)
DKIM signature
pass
Download raw message
Protesilaos

I'm less a fan. When I look at blame information, it's to understand why
a change was made. Summary is a good first hint. Name and date might be
relevant after I had a look at the diff but those are also shown on the
diff and since I'm looking at the diff... Put differently, I'm
unconvinced of wanting to draw attention to anything but the summary.
This is all personal and not a hill I'm willing to die on. I hope this
helps somewhat.

-- 
Nicolas De Jaeghere
Protesilaos Stavrou <public@protesilaos.com>
Details
Message ID
<87letynkuf.fsf@protesilaos.com>
In-Reply-To
<87wndip988.fsf@dejaeghe.re> (view parent)
DKIM signature
pass
Download raw message
> From: Nicolas De Jaeghere <nicolas@dejaeghe.re>
> Date: Wed, 15 Jun 2022 10:43:06 +0200
>
> Protesilaos

Hi Nicolas,

> I'm less a fan. When I look at blame information, it's to understand why
> a change was made. Summary is a good first hint. Name and date might be
> relevant after I had a look at the diff but those are also shown on the
> diff and since I'm looking at the diff... Put differently, I'm
> unconvinced of wanting to draw attention to anything but the summary.
> This is all personal and not a hill I'm willing to die on. I hope this
> helps somewhat.

Yes, this is helpful.  Thank you!

-- 
Protesilaos Stavrou
https://protesilaos.com
Details
Message ID
<87ilp1r2zw.fsf@gmail.com>
In-Reply-To
<87bkuv23vl.fsf@protesilaos.com> (view parent)
DKIM signature
pass
Download raw message
Protesilaos Stavrou <public@protesilaos.com> writes:

Hi Protesilaos!

> I am experimenting with adding some more colour, specifically background
> values for the author and date fields.  Not too intense, but enough to
> add more structure.  This is the diff:
>
> What do you think?

I'm afraid I prefer the status quo, and I don't see how further
experimentation would change my mind.

The Magit blame interface adds some lines in between sections of source
code, thus it seems correct to had a subtle, nuanced but constant
background that tells it apart.

I strongly oppose using bold faces.  The focus in actually in the source
code, and only then does the user actually look up to find information
about the commit.

Experimentation is good, and who knows if I could be convinced otherwise
on this topic.

Thank you.


-- 
André A. Gomes
"You cannot even find the ruins..."
Protesilaos Stavrou <public@protesilaos.com>
Details
Message ID
<87h74lv1cl.fsf@protesilaos.com>
In-Reply-To
<87ilp1r2zw.fsf@gmail.com> (view parent)
DKIM signature
pass
Download raw message
> From: André A. Gomes <andremegafone@gmail.com>
> Date: Wed, 15 Jun 2022 23:11:31 +0100
>
> Protesilaos Stavrou <public@protesilaos.com> writes:
>
> Hi Protesilaos!

Hello André!

>> I am experimenting with adding some more colour, specifically background
>> values for the author and date fields.  Not too intense, but enough to
>> add more structure.  This is the diff:
>>
>> What do you think?
>
> I'm afraid I prefer the status quo, and I don't see how further
> experimentation would change my mind.

Very well!  We have reached consensus.

I wanted to have your feedback exactly because I wasn't sure this was
heading in the right direction.

Have a nice day,
Protesilaos

-- 
Protesilaos Stavrou
https://protesilaos.com
Reply to thread Export thread (mbox)