~protesilaos/modus-themes

3 2

Styling of `mu4e-related-face` in mu4e 1.8.x

Simon Pugnet <simon@polaris64.net>
Details
Message ID
<87edxhvqwp.fsf@polaris64.net>
DKIM signature
missing
Download raw message
Dear Protesilaos,

In recent versions of mu4e there is a new face called
`mu4e-related-face` which is used in the mu4e headers (messages) list
in order to highlight messages that are not directly matched by the
current search but which are related. I am currently using mu4e
version 1.8.8 in Emacs 28.1.91 but I believe this was first introduced
in mu4e 1.8.0.

In the current version of `modus-vivendi`, this face has the following
attributes: -

  Face: mu4e-related-face (sample) (customize this face)

  Documentation:
  Face for a =’related’ header.

  Defined in ‘mu4e-vars.el’.


             Family: unspecified
            Foundry: unspecified
              Width: unspecified
             Height: unspecified
             Weight: unspecified
              Slant: italic
         Foreground: unspecified
  DistantForeground: unspecified
         Background: unspecified
          Underline: unspecified
           Overline: unspecified
     Strike-through: unspecified
                Box: unspecified
            Inverse: unspecified
            Stipple: unspecified
               Font: unspecified
            Fontset: unspecified
             Extend: unspecified
            Inherit: default

The problem is that in the current version of modus-themes, this face
is very close in style to that of unread messages. This makes it
difficult to differentiate between unread messages and messages that
have been read but which are only related.

I have attached an image showing the problem. In the screenshot the
second message is unread (bold and white), the third has been read and
forwarded (purple) and the forwarded (therefore related) message is
shown below that in white italics. The other messages have been read
and therefore are displayed in a medium grey. As you can see, the
related message face differs from the unread message face in that it
is not bold and is italicised, however to me there's too much
similarity between the two which makes it difficult for me to
differentiate at first glance.

Would it be possible to change `mu4e-related-face` in modus-themes to
make it more similar to `mu4e-header-face`, which is used for the
other unread messages? For reference, this face inherits from "shadow"
rather than "default" as shown above.

Thanks for all your work on these themes by the way, they are
fantastic!

Kind regards,

--
Simon Pugnet
https://www.polaris64.net/
Details
Message ID
<87y1vp3mss.fsf@protesilaos.com>
In-Reply-To
<87edxhvqwp.fsf@polaris64.net> (view parent)
DKIM signature
missing
Download raw message
> From: Simon Pugnet <simon@polaris64.net>
> Date: Mon, 15 Aug 2022 08:42:50 +0000
>
> Dear Protesilaos,

Good day Simon and thank you for the detailed message!

> [... 53 lines elided]

> Would it be possible to change `mu4e-related-face` in modus-themes to
> make it more similar to `mu4e-header-face`, which is used for the
> other unread messages? For reference, this face inherits from "shadow"
> rather than "default" as shown above.

I just added support for it.  Please give it a try.

I made it inherit from italic and shadow.  This way it looks like the
'mu4e-header-face' but retains some element of differentiation, as
intended by the mu4e developers.

> Thanks for all your work on these themes by the way, they are
> fantastic!

You are welcome!

All the best,
Protesilaos (or simply "Prot")

-- 
Protesilaos Stavrou
https://protesilaos.com
Simon Pugnet <simon@polaris64.net>
Details
Message ID
<875yitvlfz.fsf@polaris64.net>
In-Reply-To
<87y1vp3mss.fsf@protesilaos.com> (view parent)
DKIM signature
missing
Download raw message
"Protesilaos Stavrou" <info@protesilaos.com> writes:

>> Would it be possible to change `mu4e-related-face` in modus-themes
>> to
>> make it more similar to `mu4e-header-face`, which is used for the
>> other unread messages? For reference, this face inherits from
>> "shadow"
>> rather than "default" as shown above.
>
> I just added support for it.  Please give it a try.
>
> I made it inherit from italic and shadow.  This way it looks like
> the
> 'mu4e-header-face' but retains some element of differentiation, as
> intended by the mu4e developers.

That's perfect now, thank you very much!

Kind regards,

--
Simon Pugnet
https://www.polaris64.net/
Details
Message ID
<87r11hlr88.fsf@protesilaos.com>
In-Reply-To
<875yitvlfz.fsf@polaris64.net> (view parent)
DKIM signature
missing
Download raw message
> From: Simon Pugnet <simon@polaris64.net>
> Date: Mon, 15 Aug 2022 10:40:51 +0000

>> I made it inherit from italic and shadow.  This way it looks like the
>> 'mu4e-header-face' but retains some element of differentiation, as
>> intended by the mu4e developers.
>
> That's perfect now, thank you very much!

You are welcome and thanks again for the feedback!

-- 
Protesilaos Stavrou
https://protesilaos.com
Reply to thread Export thread (mbox)