I set `modus-themes-syntax' to (yellow-comments green-strings), and it
seems that on Modus version 2.5.0 font-lock-warning face and
font-lock-comment face are indistinguishable.
Let me know if you can reproduce, if not I'll make a more careful
report.
(FWIW, I liked the old red for warnings.)
> From: Augusto Stoffel <arstoffel@gmail.com>> Date: Sat, 13 Aug 2022 15:57:09 +0200
Hello Augusto
> I set `modus-themes-syntax' to (yellow-comments green-strings), and it> seems that on Modus version 2.5.0 font-lock-warning face and> font-lock-comment face are indistinguishable.>> Let me know if you can reproduce, if not I'll make a more careful> report.>> (FWIW, I liked the old red for warnings.)
I just pushed commit d40d5a5 which makes font-lock-warning-face red when
the yellow comments are enabled. Please give it a try and let me know
if it works for you.
All the best,
Prot
--
Protesilaos Stavrou
https://protesilaos.com
> From: Manuel Uberti <manuel.uberti@inventati.org>> Date: Tue, 16 Aug 2022 07:23:05 +0000>> Hi,
Good day Manuel,
> are there any plans to release this fix for the themes included in Emacs > master?
Normally I sync changes upon a new release. Given that the last one was
at the beginning of this month, I expect the next one to come some time
in September.
Though since you mention it, I could install this change (commit
d40d5a5) on Emacs 'master'. My only concern is if this will create
conflicts with git when I eventually merge the next release. I believe
it should be fine. But maybe you, or anyone reading this, knows better?
I can resolve git conflicts. It's just that I would rather avoid them
on emacs.git: I have write access though I don't want to cause any
trouble.
All the best,
Prot
--
Protesilaos Stavrou
https://protesilaos.com
On 16/08/22 09:54, Protesilaos Stavrou wrote:
> Normally I sync changes upon a new release. Given that the last one was> at the beginning of this month, I expect the next one to come some time> in September.> > Though since you mention it, I could install this change (commit> d40d5a5) on Emacs 'master'. My only concern is if this will create> conflicts with git when I eventually merge the next release. I believe> it should be fine. But maybe you, or anyone reading this, knows better?> > I can resolve git conflicts. It's just that I would rather avoid them> on emacs.git: I have write access though I don't want to cause any> trouble.
I see no need for you to rush. I'm happy to wait if it's easier for you
to install it later.
Actually, I can add it temporarily to my setup until it's on master.
Thanks!
--
Manuel Uberti
https://manueluberti.eu
> From: Manuel Uberti <manuel.uberti@inventati.org>> Date: Tue, 16 Aug 2022 10:14:58 +0200> [... 15 lines elided]> I see no need for you to rush. I'm happy to wait if it's easier for you > to install it later.>> Actually, I can add it temporarily to my setup until it's on master.
Okay, please do it this way and I will make a proper release by the end
of this week. I cannot just do a 2.5.1 right now as there are some
changes that need to be documented in the change log.
This way everything stays in sync.
Is this okay?
--
Protesilaos Stavrou
https://protesilaos.com
On 16/08/22 10:36, Protesilaos Stavrou wrote:
> Okay, please do it this way and I will make a proper release by the end> of this week. I cannot just do a 2.5.1 right now as there are some> changes that need to be documented in the change log.> > This way everything stays in sync.> > Is this okay?
Totally. Feel free to release whenever you think is best.
Thanks
--
Manuel Uberti
https://manueluberti.eu
> From: Manuel Uberti <manuel.uberti@inventati.org>> Date: Tue, 16 Aug 2022 10:39:51 +0200>> On 16/08/22 10:36, Protesilaos Stavrou wrote:>> Okay, please do it this way and I will make a proper release by the end>> of this week. I cannot just do a 2.5.1 right now as there are some>> changes that need to be documented in the change log.>> >> This way everything stays in sync.>> >> Is this okay?>> Totally. Feel free to release whenever you think is best.
Hello again, Manuel!
Just pushed commit dd97bff219 to emacs.git. Release notes here:
<https://protesilaos.com/codelog/2022-08-19-modus-themes-2-6-0/>.
Please let me know if there is anything else that needs to be fixed.
All the best,
Prot
--
Protesilaos Stavrou
https://protesilaos.com
On 19/08/22 11:42, Protesilaos Stavrou wrote:
> Hello again, Manuel!
Hey Prot
> Just pushed commit dd97bff219 to emacs.git. Release notes here:> <https://protesilaos.com/codelog/2022-08-19-modus-themes-2-6-0/>.
Fantastic, thanks. I'll build in a moment and give it a test. I'll
report back if I find any problem.
> Please let me know if there is anything else that needs to be fixed.
Sure!
--
Manuel Uberti
https://manueluberti.eu