Hi - I fetched version 4 to check it out - it seems an excellent
development - not just for the included themes, but as a framework for
defining other themes.

I think there may be a mistake with the tab bar?   For
tab-bar-tab-inactive uses bg-active which seems incongruous.

Also, can I suggest the core functionality set the `scroll-bar` face?
My GTK scrollbars seem to pick up colors from the GTK desktop theme,
but if I switch between dark and light themes I would then have to
switch GTK themes to get Emacs to look reasonable.

Thanks,

James

> From: James Ferguson <james@faff.org>
> Date: Sun, 18 Dec 2022 10:01:02 -0500

Hello James,

> Hi - I fetched version 4 to check it out - it seems an excellent
> development - not just for the included themes, but as a framework for
> defining other themes.

Indeed, the framework is there.

> I think there may be a mistake with the tab bar?   For
> tab-bar-tab-inactive uses bg-active which seems incongruous.

Good point!  I will take care of it tomorrow morning.

> Also, can I suggest the core functionality set the `scroll-bar` face?
> My GTK scrollbars seem to pick up colors from the GTK desktop theme,
> but if I switch between dark and light themes I would then have to
> switch GTK themes to get Emacs to look reasonable.

I had tried that before but it had no effect on my GTK build.  I think
it applies to the Lucid build and maybe others.  I need to see how it
looks before covering it.  If you can do it, then I am happy to see this
face included.

All the best,
Protesilaos (or simply "Prot")

-- 
Protesilaos Stavrou
https://protesilaos.com