Hi, Prot.
I've just updated the Modus Themes to version 4. I know that you are
still putting the finishing touches, so I'm not sure whether you know
about it, but I've noticed issues with 3 faces, namely
'avy-goto-char-timer-face', 'org-code', and 'org-verbatim' (or, rather,
the 'modus-themes-prose-*' faces these two Org faces inherit from).
Avy matches don't get highlighted: matches during reading chars become
bold, but the background does not get highlighted. At first I thought
that it was a design decision, but when matched text itself has a bold
face (e.g. headings) then the matches are not visible at all, so I
assume it's a bug. Furthermore, 'describe-face' says that the Avy face
inherits from 'modus-themes-intense-neutral' (and 'bold'), but apparently it's
undefined.
I have set 'modus-themes-mixed-fonts' user option to t, but 'org-code'
and 'org-verbatim' faces are not monospace when 'buffer-face-mode' is
enabled. 'org-block-begin-line' is monospace, though, because it
inherits from 'modus-themes-fixed-pitch'.
I'm not sure whether these are design decisions or you just forgot to do
some things, so I just wanted to let you know.
> From: soaringbird <soaringbird@tuta.io>> Date: Fri, 30 Dec 2022 11:20:36 +0100>> Hi, Prot.
Good day!
> I've just updated the Modus Themes to version 4. I know that you are> still putting the finishing touches, so I'm not sure whether you know> about it, but I've noticed issues with 3 faces, namely> 'avy-goto-char-timer-face', 'org-code', and 'org-verbatim' (or, rather,> the 'modus-themes-prose-*' faces these two Org faces inherit from).>> Avy matches don't get highlighted: matches during reading chars become> bold, but the background does not get highlighted. At first I thought> that it was a design decision, but when matched text itself has a bold> face (e.g. headings) then the matches are not visible at all, so I> assume it's a bug. Furthermore, 'describe-face' says that the Avy face> inherits from 'modus-themes-intense-neutral' (and 'bold'), but apparently it's> undefined.>> I have set 'modus-themes-mixed-fonts' user option to t, but 'org-code'> and 'org-verbatim' faces are not monospace when 'buffer-face-mode' is> enabled. 'org-block-begin-line' is monospace, though, because it> inherits from 'modus-themes-fixed-pitch'.
About Avy, there must be something weird going on. It works fine on my
end (and should look the same as before). I am trying it with, for
example, M-x avy-goto-char.
For the rest, they were omissions from my side that I just addressed.
Thanks for bringing this matter to my attention.
> I'm not sure whether these are design decisions or you just forgot to do> some things, so I just wanted to let you know.
You did well. In general, if something feels unusable, it most likely
is not by design.
All the best,
Prot
--
Protesilaos Stavrou
https://protesilaos.com
> About Avy, there must be something weird going on. It works fine on my> end (and should look the same as before). I am trying it with, for> example, M-x avy-goto-char.>> For the rest, they were omissions from my side that I just addressed.> Thanks for bringing this matter to my attention.
I meant the darker background that appears behind matches during typing,
as in Isearch. That's why it's specific to 'avy-goto-char-timer'
command.
But anyhow, I've downloaded the update and the patch did the trick.
Everything works now.
> You did well. In general, if something feels unusable, it most likely> is not by design.
Good, I was ready to start a holy war.
Cheers
> About Avy, there must be something weird going on. It works fine on my> end (and should look the same as before). I am trying it with, for> example, M-x avy-goto-char.>> For the rest, they were omissions from my side that I just addressed.> Thanks for bringing this matter to my attention.
I meant the darker background that appears behind matches during typing,
as in Isearch. That's why it's specific to 'avy-goto-char-timer'
command.
But anyhow, I've downloaded the update and the patch did the trick.
Everything works now.
> You did well. In general, if something feels unusable, it most likely> is not by design.
Good, I was ready to start a holy war.
Cheers
> From: soaringbird <soaringbird@tuta.io>> Date: Fri, 30 Dec 2022 17:52:54 +0100>>> About Avy, there must be something weird going on. It works fine on my>> end (and should look the same as before). I am trying it with, for>> example, M-x avy-goto-char.>>>> For the rest, they were omissions from my side that I just addressed.>> Thanks for bringing this matter to my attention.>> I meant the darker background that appears behind matches during typing,> as in Isearch. That's why it's specific to 'avy-goto-char-timer'> command.>> But anyhow, I've downloaded the update and the patch did the trick.> Everything works now.
Indeed. I realised it after sending my message. All good!
>> You did well. In general, if something feels unusable, it most likely>> is not by design.>> Good, I was ready to start a holy war.
The patch thus qualifies as a peace-keeping operation!
--
Protesilaos Stavrou
https://protesilaos.com