Hi, Prot.

I've noticed that the 'ibuffer-filter-group-name-face' user option uses
a now obsolete face. I think that filter group names were bold before.

I like using grep because it makes me feel powerful, and it turns out
there are a few more obsolete faces still in the code, all in the file
modus-themes.el:

- 'modus-themes-pseudo-header' (this is the one used in Ibuffer)
- 'modus-themes-special-mild'
- 'modus-themes-mark-symbol'
- 'modus-themes-hl-line'

Furthermore, the following faces are not used in the code, but they are
mentioned in docstrings:

- 'modus-themes-operandi-colors'
- 'modus-themes-vivendi-colors'
- 'modus-themes-reset-hard'

And 'modus-themes-hl-line' is made obsolete twice.

I guess that they shouldn't be used anymore and you just forgot to
replace them?

> From: soaringbird <soaringbird@tuta.io>
> Date: Sat, 31 Dec 2022 17:45:28 +0100
>
> Hi, Prot.

Hello there!

> I've noticed that the 'ibuffer-filter-group-name-face' user option uses
> a now obsolete face. I think that filter group names were bold before.

I have it assigned to the 'bold' face.  It used to be the
'modus-themes-pseudo-header', but that was a while ago.

> I like using grep because it makes me feel powerful, and it turns out
> there are a few more obsolete faces still in the code, all in the file
> modus-themes.el:
>
> - 'modus-themes-pseudo-header' (this is the one used in Ibuffer)
> - 'modus-themes-special-mild'
> - 'modus-themes-mark-symbol'
> - 'modus-themes-hl-line'

I fixed all those.  Except for the 'modus-themes-pseudo-header' which I
could not find anywhere.

> Furthermore, the following faces are not used in the code, but they are
> mentioned in docstrings:
>
> - 'modus-themes-operandi-colors'
> - 'modus-themes-vivendi-colors'
> - 'modus-themes-reset-hard'

Okay, removed those as well.

> And 'modus-themes-hl-line' is made obsolete twice.

This was because there was a user option and a face of the same name.  I
didn't notice it while I was obsoleting them.

> I guess that they shouldn't be used anymore and you just forgot to
> replace them?

You are right.  Thank you for informing me about them!

All the best,
Prot

-- 
Protesilaos Stavrou
https://protesilaos.com

> I have it assigned to the 'bold' face. It used to be the
> 'modus-themes-pseudo-header', but that was a while ago.

Okay, so I looked into it, and it turned out that I had a few Ibuffer
user options set to some Modus Themes faces in my 'custom-set-variables'
form, which I completely forgot about (I still have some trash set by
some packages I need to clean up).

I also have a few Flymake user options using Modus Themes faces, namely
'modus-themes-fringe-red', '*-cyan', and '*-yellow'. I don't know where
they came from, and they've been there since forever, but I guess that
it's better to just delete them all, as they might cause problems again
in the future.

Cheers.

> From: soaringbird <soaringbird@tuta.io>
> Date: Sun,  1 Jan 2023 14:39:54 +0100
>
>> I have it assigned to the 'bold' face. It used to be the
>> 'modus-themes-pseudo-header', but that was a while ago.
>
> Okay, so I looked into it, and it turned out that I had a few Ibuffer
> user options set to some Modus Themes faces in my 'custom-set-variables'
> form, which I completely forgot about (I still have some trash set by
> some packages I need to clean up).
>
> I also have a few Flymake user options using Modus Themes faces, namely
> 'modus-themes-fringe-red', '*-cyan', and '*-yellow'. I don't know where
> they came from, and they've been there since forever, but I guess that
> it's better to just delete them all, as they might cause problems again
> in the future.

Oh, I see.  Those must have been retained by Custom from older versions
of the themes.  I personally do not keep a permanent custom file as it
tends to cause unexpected issues from time-to-time:

    (setq custom-file (make-temp-file "emacs-custom-"))

-- 
Protesilaos Stavrou
https://protesilaos.com

> Oh, I see. Those must have been retained by Custom from older versions
> of the themes. I personally do not keep a permanent custom file as it
> tends to cause unexpected issues from time-to-time:
>
>     (setq custom-file (make-temp-file "emacs-custom-"))

I have a question. The only thing I have in my 'custom-set-variables'
form now is 'package-selected-packages'. Have you ever needed it, or is
it safe to remove it?

> From: soaringbird <soaringbird@tuta.io>
> Date: Sun,  1 Jan 2023 15:48:19 +0100
>
>> Oh, I see. Those must have been retained by Custom from older versions
>> of the themes. I personally do not keep a permanent custom file as it
>> tends to cause unexpected issues from time-to-time:
>>
>>     (setq custom-file (make-temp-file "emacs-custom-"))
>
> I have a question. The only thing I have in my 'custom-set-variables'
> form now is 'package-selected-packages'. Have you ever needed it, or is
> it safe to remove it?

I have never needed it.  I think the only scenario where you will get
into a problem with my setup is if you do M-x package-autoremove BEFORE
M-x list-packages.  Doing so will remove all your packages.  But once
you run the relevant package.el commands that variable will get updated
and then everything will work as expected.

-- 
Protesilaos Stavrou
https://protesilaos.com