~protesilaos/modus-themes

3 2

“Invalid face reference: quote” message

soaringbird <soaringbird@tuta.io>
Details
Message ID
<NXPVkVk--3-9@tuta.io>
DKIM signature
missing
Download raw message
Hi.

I noticed that the ‘*Messages*’ buffer was accumulating the message
“Invalid face reference: quote” while moving point in an Org buffer (a
todo list). It turned out that it was caused by one snippet from the
“Custom Org todo keyword and priority faces” section of the manual
(https://www.gnu.org/software/emacs/manual/html_node/modus-themes/Custom-Org-user-faces.html):

    (setq org-priority-faces
          '((?A . '(bold org-priority))
            (?B . org-priority)
            (?C . '(shadow org-priority))))

Everything worked properly, so the message is just a warning. But
apparently it’s not a correct way of inheriting faces—Emacs thinks
that, in addition to the faces in parentheses, you want to inherit a
nonexistent face called “quote” (check the value of
‘org-priority-faces’ with ‘C-h v’).

I think this is the proper way to do that:

    (setq org-priority-faces
          '((?A . (:inherit (bold org-priority)))
            (?B . org-priority)
            (?C . (:inherit (shadow org-priority)))))

This code doesn’t print the message in the buffer.
Details
Message ID
<87bkhqgmb9.fsf@protesilaos.com>
In-Reply-To
<NXPVkVk--3-9@tuta.io> (view parent)
DKIM signature
missing
Download raw message
> From: soaringbird <soaringbird@tuta.io>
> Date: Thu,  8 Jun 2023 12:17:38 +0200

> [... 20 lines elided]

> I think this is the proper way to do that:
>
>     (setq org-priority-faces
>           '((?A . (:inherit (bold org-priority)))
>             (?B . org-priority)
>             (?C . (:inherit (shadow org-priority)))))
>
> This code doesn’t print the message in the buffer.

You are right!  Do you want to send a patch?

-- 
Protesilaos Stavrou
https://protesilaos.com
soaringbird <soaringbird@tuta.io>
Details
Message ID
<NXQZKqZ--3-9@tuta.io>
In-Reply-To
<87bkhqgmb9.fsf@protesilaos.com> (view parent)
DKIM signature
missing
Download raw message
> You are right!  Do you want to send a patch?

I’d love to, but I don’t quite know how to do it yet (‘diff’ and
‘patch’ are probably involved, but that’s all I know). I also don’t
mind not attributing the change to me.
Details
Message ID
<87mt18doj9.fsf@protesilaos.com>
In-Reply-To
<NXQZKqZ--3-9@tuta.io> (view parent)
DKIM signature
missing
Download raw message
> From: soaringbird <soaringbird@tuta.io>
> Date: Thu,  8 Jun 2023 17:12:55 +0200
>
>> You are right!  Do you want to send a patch?
>
> I’d love to, but I don’t quite know how to do it yet (‘diff’ and
> ‘patch’ are probably involved, but that’s all I know). I also don’t
> mind not attributing the change to me.

Thank you!  I just made the changes.

-- 
Protesilaos Stavrou
https://protesilaos.com
Reply to thread Export thread (mbox)