Hi Prot,

After dabbling with the current MELPA version for a while, I found my
way around the new palettes. Nice!

I was looking for a way to try macOS like selection (region) colors with
v4 again, but noticed that there's no named 'fg-region' color in any
palette.

My suggestion would be to replace:

    `(region ((,c ,@(modus-themes--region bg-region fg-main bg-region-subtle))))

with:

    `(region ((,c ,@(modus-themes--region bg-region fg-region bg-region-subtle))))

... and conversely introduce:

    (fg-region fg-main)

as the default to keep the current values functional. Then people like
me could override 'bg-region and have a matching foreground color.

What do you think?

Cheers,
Christian

----
Sent from Bielefeld, Germany <3
https://christiantietze.de

> From: Christian Tietze <me@christiantietze.de>
> Date: Fri, 30 Dec 2022 13:32:54 +0100
>
> Hi Prot,

Hello Christian,

> After dabbling with the current MELPA version for a while, I found my
> way around the new palettes. Nice!

Thank you!  I am enjoying the designs you post on your blog.  I expect
this to give you the freedom you need.

> I was looking for a way to try macOS like selection (region) colors with
> v4 again, but noticed that there's no named 'fg-region' color in any
> palette.
>
> My suggestion would be to replace:
>
>     `(region ((,c ,@(modus-themes--region bg-region fg-main bg-region-subtle))))
>
> with:
>
>     `(region ((,c ,@(modus-themes--region bg-region fg-region bg-region-subtle))))
>
> ... and conversely introduce:
>
>     (fg-region fg-main)
>
> as the default to keep the current values functional. Then people like
> me could override 'bg-region and have a matching foreground color.
>
> What do you think?

Your proposal is correct.  Though we also need to deprecate
'modus-themes-region' and then remove the 'bg-region-subtle' entries
from the palettes.

This means that the function 'modus-themes--region' will also be
removed.

I will do it later today.

[ The case of the 'region' face shows the kind of complexity we had
  before.  For one face, we had one user option, one private function,
  and two different background colours per theme palette.  In some
  cases, like 'modus-themes-syntax', this was more egregious. ]

All the best,
Prot

-- 
Protesilaos Stavrou
https://protesilaos.com

> Your proposal is correct.  Though we also need to deprecate
> 'modus-themes-region' and then remove the 'bg-region-subtle' entries
> from the palettes.
>
> This means that the function 'modus-themes--region' will also be
> removed.
>
> I will do it later today.
>
> [ The case of the 'region' face shows the kind of complexity we had
>   before.  For one face, we had one user option, one private function,
>   and two different background colours per theme palette.  In some
>   cases, like 'modus-themes-syntax', this was more egregious. ]

Thank you for clarifying!

I did not realize that this setting was also intended to go away in a
short while, although it does make sense to me to go further and remove
more custom options in favor of your new color references.

-- Christian

> From: Christian Tietze <me@christiantietze.de>
> Date: Fri, 30 Dec 2022 17:27:29 +0100
>
>> Your proposal is correct.  Though we also need to deprecate
>> 'modus-themes-region' and then remove the 'bg-region-subtle' entries
>> from the palettes.
>>
>> This means that the function 'modus-themes--region' will also be
>> removed.
>>
>> I will do it later today.
>>
>> [ The case of the 'region' face shows the kind of complexity we had
>>   before.  For one face, we had one user option, one private function,
>>   and two different background colours per theme palette.  In some
>>   cases, like 'modus-themes-syntax', this was more egregious. ]
>
> Thank you for clarifying!

You are welcome!

> I did not realize that this setting was also intended to go away in a
> short while, although it does make sense to me to go further and remove
> more custom options in favor of your new color references.

I just pushed the changes.  They include an update to the manual which
shows how to refashion the region.  What I like here is the new
stylistic potential of a subtle grey region with a prominent foreground
(I use blue-cooler in the manual).

-- 
Protesilaos Stavrou
https://protesilaos.com