olivetti-mode supports `olivetti-style` option now.
https://github.com/rnkn/olivetti#features
It has multiple options, and by default inherits from fringe color. It
also supports `olivetti-fringe` color.
Perhaps modus-themes can add some support for the option, if it the
right place is indeed the theme code?
- Dhavan.
Hello Dhavan,
> From: Dhavan Vaidya <dhavan@codingquark.com>> Date: Tue, 21 Nov 2023 12:45:43 +0530>> olivetti-mode supports `olivetti-style` option now.>> https://github.com/rnkn/olivetti#features>> It has multiple options, and by default inherits from fringe color. It> also supports `olivetti-fringe` color.>> Perhaps modus-themes can add some support for the option, if it the> right place is indeed the theme code?
I think the status quo is fine, because the default fringe has a grey
background. Though I may be missing something. What colour would you use
in this case?
All the best,
Prot
--
Protesilaos Stavrou
https://protesilaos.com
Hello everyone,
Protesilaos Stavrou <info@protesilaos.com> [2023-11-27 09:45 +0200]:
>> From: Dhavan Vaidya <dhavan@codingquark.com>>> Date: Tue, 21 Nov 2023 12:45:43 +0530>>>> olivetti-mode supports `olivetti-style` option now.>>>> https://github.com/rnkn/olivetti#features>>>> It has multiple options, and by default inherits from fringe color. It>> also supports `olivetti-fringe` color.>>>> Perhaps modus-themes can add some support for the option, if it the>> right place is indeed the theme code?>> I think the status quo is fine, because the default fringe has a grey> background. Though I may be missing something. What colour would you use> in this case?
I believe that what Dhavan is pointing out is that currently in the
modus-themes the olivetti-fringe face use the background colour bg-main
instead of the colour bg-dim used by the fringe face. This face
olivetti-fringe is used when olivetti-style is non-nil. So with the
modus-themes, the different values of the variable olivetti-style have
little if not no impact on the appearance of the olivetti-mode.
Maybe the face olivetti-fringe could use the colour bg-dim used by the
fringe face as a background colour by default?
All the best,
Gautier.
> From: Gautier Ponsinet <gponsinet@gmail.com>> Date: Fri, 1 Dec 2023 00:13:50 +0100>> Hello everyone,
Hello Gautier, Dhavan,
> Protesilaos Stavrou <info@protesilaos.com> [2023-11-27 09:45 +0200]:>>> From: Dhavan Vaidya <dhavan@codingquark.com>>>> Date: Tue, 21 Nov 2023 12:45:43 +0530>>>>>> olivetti-mode supports `olivetti-style` option now.>>>>>> https://github.com/rnkn/olivetti#features>>>>>> It has multiple options, and by default inherits from fringe color. It>>> also supports `olivetti-fringe` color.>>>>>> Perhaps modus-themes can add some support for the option, if it the>>> right place is indeed the theme code?>>>> I think the status quo is fine, because the default fringe has a grey>> background. Though I may be missing something. What colour would you use>> in this case?>> I believe that what Dhavan is pointing out is that currently in the> modus-themes the olivetti-fringe face use the background colour bg-main> instead of the colour bg-dim used by the fringe face. This face> olivetti-fringe is used when olivetti-style is non-nil. So with the> modus-themes, the different values of the variable olivetti-style have> little if not no impact on the appearance of the olivetti-mode.>> Maybe the face olivetti-fringe could use the colour bg-dim used by the> fringe face as a background colour by default?
Oh, you are right! I just tested it. I have set 'olivetti-fringe' to use
the 'fringe' semantic colour mapping.
All the best,
Prot
--
Protesilaos Stavrou
https://protesilaos.com
Protesilaos Stavrou <info@protesilaos.com> [2023-12-13 09:41 +0200]:
> Oh, you are right! I just tested it. I have set 'olivetti-fringe' to use> the 'fringe' semantic colour mapping.
Thank you Protesilaos!
All the best,
Gautier.