~protesilaos/modus-themes

1

Problem with gnus-summary-low-unread face.

Details
Message ID
<m2r0zszc2z.fsf@gmail.com>
DKIM signature
missing
Download raw message
Hello -

Version Info:

> Emacs  : GNU Emacs 28.2 (build 1, x86_64-apple-darwin21.6.0, NS appkit-2113.60 Version 12.6 (Build 21G115))
>  of 2022-09-25
> Package: modus-themes (2.6.0)

Problem:

The face gnus-summary-low-unread is identical to
gnus-summary-high-unread resulting in some confusion. Looking at the
source code it appears that all the gnus-summary-low-* faces are
inherited from :italic while all the gnus-summary-high-* faces are
inherited from :bold.

*Except* that gnus-summary-low-unread is inherited from :bold as is
 gnus-summary-high-unread.

I believe a simple fix would be to change gnus-summary-low-unread to
inherit from :italic as the other 'low' faces do.

Thanks in advance

Ciao
Mark Simpson
Details
Message ID
<87fsg872oa.fsf@protesilaos.com>
In-Reply-To
<m2r0zszc2z.fsf@gmail.com> (view parent)
DKIM signature
missing
Download raw message
> From: mark <verdammelt@gmail.com>
> Date: Fri, 30 Sep 2022 19:17:40 -0400

> Hello -

Hello Mark and thank you for taking the time to do this!

> [... 17 lines elided]

> I believe a simple fix would be to change gnus-summary-low-unread to
> inherit from :italic as the other 'low' faces do.

I agree and pushed the change:

    commit c65ea67673c501066b7ae260bddd8c1af1cafbbf
    Author: Protesilaos Stavrou <info@protesilaos.com>
    Date:   Sat Oct 1 04:21:47 2022 +0300

        Make gnus-summary-low-unread inherit from italic

        This helps differentiate it from the gnus-summary-high-unread face.

        Thanks to Mark Simpson for pointing out the possibility of conflating
        those two faces: <https://lists.sr.ht/~protesilaos/modus-themes/%3Cm2r0zszc2z.fsf@gmail.com%3E>.

     doc/modus-themes.info | 40 ++++++++++++++++++++--------------------
     doc/modus-themes.org  | 37 +++++++++++++++++++------------------
     modus-themes.el       |  2 +-
     3 files changed, 40 insertions(+), 39 deletions(-)

[ The change to the manual is because I added your name to the
  "Acknowledgements". ]

> Thanks in advance

You are welcome!  This change will be synced with emacs.git in a few
days once I release version 2.7.0 of the themes.

All the best,
Protesilaos (or simply "Prot")

-- 
Protesilaos Stavrou
https://protesilaos.com
Reply to thread Export thread (mbox)