Hello Prot,

I want your help to configure moody with modus-themes.
(https://github.com/tarsius/moody)

I use modus themes with darkman (via
https://github.com/grtcdr/darkman.el), so the theme is switched between
operandi and vivendi by darkman.el.

The ribbon looks fine with most modus variants except modus-vivendi:

It looks like sourcehut doesn't like my attachment, so here's my mail
continuing from the last line which wasn't removed, with an imgur link
instead of an attachment:




The ribbon looks fine with most modus variants except modus-vivendi:
https://imgur.com/e14qB8h

Moody expects the "ribbon" background in `moody-ribbon-background` as
`(FACE ATTRIBUTE)`:
https://github.com/tarsius/moody/blob/249c5f1cf22f17c2d1e7793e2ffd3b09cf15bb10/moody.el#L117

How do go about this?

Thanks,

Chinmay

> From: Chinmay Dalal <dalal.chinmay.0101@gmail.com>
> Date: Sun, 16 Apr 2023 03:59:45 +0530
>
> Hello Prot,

Hello Chinmay,

> I want your help to configure moody with modus-themes.
> (https://github.com/tarsius/moody)
>
> I use modus themes with darkman (via
> https://github.com/grtcdr/darkman.el), so the theme is switched between
> operandi and vivendi by darkman.el.
>
> The ribbon looks fine with most modus variants except modus-vivendi:
> x
>
> Moody expects the "ribbon" background in `moody-ribbon-background` as
> `(FACE ATTRIBUTE)`:
> https://github.com/tarsius/moody/blob/249c5f1cf22f17c2d1e7793e2ffd3b09cf15bb10/moody.el#L117
>
> How do go about this?

This should work out-of-the-box.  I just installed moody and did this
from the moody README while using modus-vivendi:

    (use-package moody
      :config
      (setq x-underline-at-descent-line t)
      (moody-replace-mode-line-buffer-identification)
      (moody-replace-vc-mode)
      (moody-replace-eldoc-minibuffer-message-function)) 

Then I switch themes with either 'modus-themes-toggle' or
'modus-themes-select' and everything looks fine.

Can you try this without darkman.el?

All the best,
Prot

-- 
Protesilaos Stavrou
https://protesilaos.com

[ I ended up here after being mentioned in
<https://github.com/tarsius/moody/issues/27#issuecomment-1509985894>. ]

Chinmay, when you say ribbon, did you intend to say tab? Moody provides
both tabs and ribbons. I only see a tab in your screenshot. When you say
the "ribbon" doesn't look fine, are you talking about the line above the
"ribbon"? If yes, can you try my suggestion in
<https://github.com/tarsius/moody/issues/27#issuecomment-1510390189>? If
no, can you describe to us what doesn't look fine? Maybe share a
screenshot where it does look fine?

Protesilaos, I think the issue is the :box attribute on the mode-line
and mode-line-inactive faces. This used to be a customization. I think
Moody should be removed from the list of supported packages.

-- 
Nicolas De Jaeghere

> From: Nicolas De Jaeghere <nicolas@dejaeghe.re>
> Date: Sun, 16 Apr 2023 16:27:59 +0200

> [... 12 lines elided]

> Protesilaos, I think the issue is the :box attribute on the mode-line
> and mode-line-inactive faces. This used to be a customization. I think
> Moody should be removed from the list of supported packages.

Thank you Nicolas!  I just pushed the change.

-- 
Protesilaos Stavrou
https://protesilaos.com