Add theme property tags for modus-{operandi,vivendi}-theme v1 APPLIED

Philip Kaludercic: 1
 Add theme property tags for modus-{operandi,vivendi}-theme

 2 files changed, 6 insertions(+), 0 deletions(-)

Protesilaos Stavrou <info@protesilaos.com> writes:

Good day folks!

I reverted the deprecation because it is more intrusive than I had
thought:

    commit d9e454603155d0bd73e6b6ac0bee4e370e30b701
    Author: Protesilaos Stavrou <info@protesilaos.com>
    Date:   Tue Oct 18 11:00:22 2022 +0300

      Revert modus-themes-toggle obsolete

      The 'toggle-theme' is not functionally equivalent to the command
      'modus-themes-toggle' due to the optional arguments it accepts.  With
      'toggle-theme' we are prompted to confirm loading the theme.  We also
      get a second prompt that tells us how unsafe themes can be...  This is
      consistent with how 'load-theme' works, but is not what the user of
      'modus-themes-toggle' has come to expect.

      Users who do not like to maintain a 'custom-file' are thus penalised
      each time they invoke the command.  I will proceed with this
      deprecation, if there is, say, a user option in Emacs that disables
      those prompts each time a theme is loaded.  Basically, we need an
      arrangement that just toggles themes without questions.

      This commit reverts 59da1b3, 0260109.

      Read the discussion on the mailing list with the participation of
      Philip Kaludercic and Rudolf Adamkovič:
      <https://lists.sr.ht/~protesilaos/modus-themes/%3C877d116lh4.fsf%40posteo.net%3E#%3Cm2lepgrd8l.fsf@me.com%3E>.

Sorry about this back-and-forth!

All the best,
Prot

In principle, I am fine with this.  Though note that the themes support
Emacs 27.1 and there will be no pressure to change that even after Emacs
29 becomes the new stable.

Protesilaos Stavrou <info@protesilaos.com> writes:

It worked just fine.  I could not tell the difference.

Since we are on the meta level: I use notmuch as my MUA.  While viewing
a message, I invoke a command which appends its filesystem path to the
kill-ring.  Then I switch to the relevant project and do 'git am PATH'.

Protesilaos Stavrou <info@protesilaos.com> writes:

Yes.  This is because the mail is stored locally by the mbsync script.
Gnus can work this way, though it needs the nnmaildir (I think) backend
instead of nnimap.  Gnus can also leverage notmuch for searching, but I
never managed to make it work at the time.

Good!  Do you want to prepare a patch or shall I do it from here?

Protesilaos Stavrou <info@protesilaos.com> writes:

Protesilaos Stavrou <info@protesilaos.com> writes:

[PATCH] Add theme property tags for modus-{operandi,vivendi}-theme Export this patch

* modus-operandi-theme.el: Add autoloaded theme properties.
* modus-vivendi-theme.el: Add autoloaded theme properties.

As introduced in https://lists.gnu.org/archive/html/bug-gnu-emacs/2022-10/msg00886.html.
---
 modus-operandi-theme.el | 3 +++
 modus-vivendi-theme.el  | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/modus-operandi-theme.el b/modus-operandi-theme.el
index 6e609c0..c981e8b 100644
--- a/modus-operandi-theme.el
+++ b/modus-operandi-theme.el
@@ -71,4 +71,7 @@ which corresponds to a minimum contrast in relative luminance of
 
   (provide-theme 'modus-operandi))
 
+;;;###theme-autoload
+(put 'modus-operandi 'theme-properties '(:background-mode light :kind color-scheme :family modus))
+
 ;;; modus-operandi-theme.el ends here
diff --git a/modus-vivendi-theme.el b/modus-vivendi-theme.el
index 579b2af..746a008 100644
--- a/modus-vivendi-theme.el
+++ b/modus-vivendi-theme.el
@@ -71,4 +71,7 @@ which corresponds to a minimum contrast in relative luminance of
 
   (provide-theme 'modus-vivendi))
 
+;;;###theme-autoload
+(put 'modus-vivendi 'theme-properties '(:background-mode dark :kind color-scheme :family modus))
+
 ;;; modus-vivendi-theme.el ends here
-- 
2.37.3

Protesilaos Stavrou <info@protesilaos.com>

2 years ago

Installed the patch.  Thank you for this and for the work in emacs.git!

Rudolf Adamkovič <salutis@me.com>

2 years ago

Philip Kaludercic <philipk@posteo.net> writes:

Rudolf Adamkovič <salutis@me.com>

2 years ago

BTW, we could also perhaps deprecate 'modus-themes-toggle' in favor of
'toggle-theme' on Emacs 29.