Hi Prot,

first of all, thanks for these themes. I used to keep something very 
similar to `standard-dark` in my `.emacs.d/themes` directory because I 
like these colours.

Anyway, I think the default `hl-line` face does not make the highlighted 
content easy to read in some occasions. Take the
output of `M-x list-packages`, for instance. I found `Package` and 
`Description` on the current line a bit hard to read.

Maybe it's just my eyes, but could something more grey-ish be an 
alternative?


All the best

-- 
Manuel Uberti
https://manueluberti.eu

> From: Manuel Uberti <manuel.uberti@inventati.org>
> Date: Sun, 11 Dec 2022 13:25:34 +0100
>
> Hi Prot,

Hello Manuel,

> first of all, thanks for these themes. I used to keep something very 
> similar to `standard-dark` in my `.emacs.d/themes` directory because I 
> like these colours.

You are welcome!  I think they are nice to have and are consistent with
the default Emacs experience.

> Anyway, I think the default `hl-line` face does not make the highlighted 
> content easy to read in some occasions. Take the
> output of `M-x list-packages`, for instance. I found `Package` and 
> `Description` on the current line a bit hard to read.
>
> Maybe it's just my eyes, but could something more grey-ish be an 
> alternative?

In general, the looks of those themes are governed by the default faces.
In this case, the 'highlight' face:

    (defface highlight
      '((((class color) (min-colors 88) (background light))
         :background "darkseagreen2")
        (((class color) (min-colors 88) (background dark))
         :background "darkolivegreen")
        (((class color) (min-colors 16) (background light))
         :background "darkseagreen2")
        (((class color) (min-colors 16) (background dark))
         :background "darkolivegreen")
        (((class color) (min-colors 8))
         :background "green" :foreground "black")
        (t :inverse-video t))
      "Basic face for highlighting."
      :group 'basic-faces)

If we use 'M-x list-colors-display' we find that "darkolivegreen" is
"#556b2f", which is what I am using.

I am with you on this: I think it is too bright.  Keeping it in the
olive green style is fine, but we could tone it down a little bit.  The
light variant is easier on the eyes in this regard.

How about changing the value to "#334515"?  It is still olive green, but
it is toned down a bit and the text is easier to read.

There is precedent for such deviation from the defaults: I did it with
the dark mode line and the tab-bar/line tabs, which are all light grey
(I made them dark grey).  The idea is to address some inconsistencies
between the two themes.  So we are respectful of the original, but not
reverential.

All the best,
Prot

-- 
Protesilaos Stavrou
https://protesilaos.com

On 11/12/22 14:08, Protesilaos Stavrou wrote:
> You are welcome!  I think they are nice to have and are consistent with
> the default Emacs experience.

Totally. My humble variant was just the default faces with some 
customization here and there (mainly for LaTeX and Markdown), but you 
did a much better job.

> I am with you on this: I think it is too bright.  Keeping it in the
> olive green style is fine, but we could tone it down a little bit.  The
> light variant is easier on the eyes in this regard.
> 
> How about changing the value to "#334515"?  It is still olive green, but
> it is toned down a bit and the text is easier to read.

Better indeed. I tried it out quickly and the difference is subtle but 
definitely perceptible.

> There is precedent for such deviation from the defaults: I did it with
> the dark mode line and the tab-bar/line tabs, which are all light grey
> (I made them dark grey).  The idea is to address some inconsistencies
> between the two themes.  So we are respectful of the original, but not
> reverential.

It makes sense. The default colours are not holy scriptures, anyway.

-- 
Manuel Uberti
https://manueluberti.eu

> From: Manuel Uberti <manuel.uberti@inventati.org>
> Date: Sun, 11 Dec 2022 14:16:37 +0100
>
> On 11/12/22 14:08, Protesilaos Stavrou wrote:
>> You are welcome!  I think they are nice to have and are consistent with
>> the default Emacs experience.
>
> Totally. My humble variant was just the default faces with some 
> customization here and there (mainly for LaTeX and Markdown), but you 
> did a much better job.

Very well!  If you have more feedback, please let me know.

>> I am with you on this: I think it is too bright.  Keeping it in the
>> olive green style is fine, but we could tone it down a little bit.  The
>> light variant is easier on the eyes in this regard.
>> 
>> How about changing the value to "#334515"?  It is still olive green, but
>> it is toned down a bit and the text is easier to read.
>
> Better indeed. I tried it out quickly and the difference is subtle but 
> definitely perceptible.
>
>> There is precedent for such deviation from the defaults: I did it with
>> the dark mode line and the tab-bar/line tabs, which are all light grey
>> (I made them dark grey).  The idea is to address some inconsistencies
>> between the two themes.  So we are respectful of the original, but not
>> reverential.
>
> It makes sense. The default colours are not holy scriptures, anyway.

I just pushed the change.  Thank you!

-- 
Protesilaos Stavrou
https://protesilaos.com

On 11/12/22 14:46, Protesilaos Stavrou wrote:
> Very well!  If you have more feedback, please let me know.

Sure!

> I just pushed the change.  Thank you!

Awesome, thanks.

-- 
Manuel Uberti
https://manueluberti.eu