~protesilaos/standard-themes

7 2

standard-themes: deprecate standard-themes-region?

Details
Message ID
<fa9ee123-c2b5-4d61-b7a5-e3bd70543730@inventati.org>
DKIM signature
missing
Download raw message
Hi Prot,

this is more of a suggestion than anything else, but what do you think
about deprecating `standard-themes-region'?

To me `standard-themes-common-palette-overrides' is already enough. For
instance, the user could do something like the following:

(setq-default
 standard-themes-common-palette-overrides '((bg-region bg-alt)))

And get the same result as they would with the following setting:

(setq-default standard-themes-region '(neutral))


All the best

-- 
Manuel Uberti
https://manueluberti.eu
Details
Message ID
<87mswm6fzq.fsf@protesilaos.com>
In-Reply-To
<fa9ee123-c2b5-4d61-b7a5-e3bd70543730@inventati.org> (view parent)
DKIM signature
missing
Download raw message
> From: Manuel Uberti <manuel.uberti@inventati.org>
> Date: Thu, 12 Oct 2023 13:25:03 +0200
>
> Hi Prot,

Hello Manuel,

> this is more of a suggestion than anything else, but what do you think
> about deprecating `standard-themes-region'?
>
> To me `standard-themes-common-palette-overrides' is already enough. For
> instance, the user could do something like the following:
>
> (setq-default
>  standard-themes-common-palette-overrides '((bg-region bg-alt)))
>
> And get the same result as they would with the following setting:
>
> (setq-default standard-themes-region '(neutral))

Yes, this makes perfect sense.  I will most probably do it tomorrow.  I
will have to update the manual to show how to get back the same
functionality.

All the best,
Prot

-- 
Protesilaos Stavrou
https://protesilaos.com
Details
Message ID
<0c1e72ad-53fc-4f2d-94a8-0375cc1bbfc6@inventati.org>
In-Reply-To
<87mswm6fzq.fsf@protesilaos.com> (view parent)
DKIM signature
missing
Download raw message
On 13/10/23 11:14, Protesilaos Stavrou wrote:
> Yes, this makes perfect sense.  I will most probably do it tomorrow.  I
> will have to update the manual to show how to get back the same
> functionality.

No problem, take the time you need, this is not urgent at all.

-- 
Manuel Uberti
https://manueluberti.eu
Details
Message ID
<87pm1h22ey.fsf@protesilaos.com>
In-Reply-To
<0c1e72ad-53fc-4f2d-94a8-0375cc1bbfc6@inventati.org> (view parent)
DKIM signature
missing
Download raw message
> From: Manuel Uberti <manuel.uberti@inventati.org>
> Date: Fri, 13 Oct 2023 12:48:54 +0200
>
> On 13/10/23 11:14, Protesilaos Stavrou wrote:
>> Yes, this makes perfect sense.  I will most probably do it tomorrow.  I
>> will have to update the manual to show how to get back the same
>> functionality.
>
> No problem, take the time you need, this is not urgent at all.

I took a look and there are more things that need to be changed.
Basically, all colour-related tweaks should be done via palette
overrides.  This also affects, links, prompts, and the mode line.  I
will do it as soon as possible.

-- 
Protesilaos Stavrou
https://protesilaos.com
Details
Message ID
<4b02e851-cc84-46d1-9700-6e63f5d16cdf@inventati.org>
In-Reply-To
<87pm1h22ey.fsf@protesilaos.com> (view parent)
DKIM signature
missing
Download raw message
On 14/10/23 07:33, Protesilaos Stavrou wrote:
> I took a look and there are more things that need to be changed.
> Basically, all colour-related tweaks should be done via palette
> overrides.  This also affects, links, prompts, and the mode line.  I
> will do it as soon as possible.

Yes, I think it would make sense to follow the same approach to palette
customisation as the one you provide for the Modus Themes.

-- 
Manuel Uberti
https://manueluberti.eu
Details
Message ID
<874jh8sr90.fsf@protesilaos.com>
In-Reply-To
<4b02e851-cc84-46d1-9700-6e63f5d16cdf@inventati.org> (view parent)
DKIM signature
missing
Download raw message
> From: Manuel Uberti <manuel.uberti@inventati.org>
> Date: Sun, 15 Oct 2023 07:49:59 +0200
>
> On 14/10/23 07:33, Protesilaos Stavrou wrote:
>> I took a look and there are more things that need to be changed.
>> Basically, all colour-related tweaks should be done via palette
>> overrides.  This also affects, links, prompts, and the mode line.  I
>> will do it as soon as possible.
>
> Yes, I think it would make sense to follow the same approach to palette
> customisation as the one you provide for the Modus Themes.

Hello again Manuel,

I pushed several commits today that move towards that direction. I will
need to review everything, though I think it works well already.

Have a nice day,
Prot

-- 
Protesilaos Stavrou
https://protesilaos.com
Details
Message ID
<73a28ae6-3750-4208-8d89-3cdfb38b0565@inventati.org>
In-Reply-To
<874jh8sr90.fsf@protesilaos.com> (view parent)
DKIM signature
missing
Download raw message
On 26/11/23 12:12, Protesilaos Stavrou wrote:
> Hello again Manuel,

Hi Prot

> I pushed several commits today that move towards that direction. I will
> need to review everything, though I think it works well already.

I upgraded earlier today and everything works as expected. Thank you!

> Have a nice day,

You too!

-- 
Manuel Uberti
https://manueluberti.eu
Details
Message ID
<878r6jfi0p.fsf@protesilaos.com>
In-Reply-To
<73a28ae6-3750-4208-8d89-3cdfb38b0565@inventati.org> (view parent)
DKIM signature
missing
Download raw message
> From: Manuel Uberti <manuel.uberti@inventati.org>
> Date: Mon, 27 Nov 2023 13:17:46 +0100
>
> On 26/11/23 12:12, Protesilaos Stavrou wrote:
>> Hello again Manuel,
>
> Hi Prot

Hello Manuel,

>> I pushed several commits today that move towards that direction. I will
>> need to review everything, though I think it works well already.
>
> I upgraded earlier today and everything works as expected. Thank you!

Great!

Take care,
Prot

-- 
Protesilaos Stavrou
https://protesilaos.com
Reply to thread Export thread (mbox)