Hi,
we shouldn't depend on human being to make sure that quality of the code
is top level. The 2 attached patches add a Makefile to facilitate
checking code:
$ make check
# Run checkdoc on tmr.el, tmr-tabulated.el…
# Run package-lint on tmr.el, tmr-tabulated.el…
# Run byte compilation on tmr.el, tmr-tabulated.el…
Best
--
Damien Cassou
"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill
> From: Damien Cassou <damien@cassou.me>> Date: Fri, 13 May 2022 18:15:45 +0200>> we shouldn't depend on human being to make sure that quality of the code> is top level.
Indeed!
I suppose we need to update the package recipe on elpa.git so that the
makefile is ignored. Though I notice that not many packages do that.
Will have to double-check before pushing this change.
* * *
Without having checked the code thoroughly, are these archive names
hardcoded?
# List of package archives to download above dependencies
# from. Available archives are: gnu, melpa, melpa-stable and org:
ELPA_ARCHIVES=melpa
The reason I am asking is because 'package-archives' lets you identify
an archive with an arbitrary string. Earlier today, I was experimenting
with this:
(setq package-archives
'(("elpa" . "https://elpa.gnu.org/packages/")
("elpa-devel" . "https://elpa.gnu.org/devel/")
("nongnu" . "https://elpa.nongnu.org/nongnu/")
("melpa" . "https://melpa.org/packages/")))
So instead of a "gnu" archive I call it "elpa" which contrasts better
with "elpa-devel".
--
Protesilaos Stavrou
https://protesilaos.com
Protesilaos Stavrou <info@protesilaos.com> writes:
> Without having checked the code thoroughly, are these archive names> hardcoded?
they are in https://gitea.petton.fr/DamienCassou/makel/src/branch/master/makel.mk> So instead of a "gnu" archive I call it "elpa" which contrasts better> with "elpa-devel".
Feel free to send a PR to https://gitea.petton.fr/DamienCassou/makel to
add more package archives and to rename (or alias) existing ones.
--
Damien Cassou
"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill
> From: Damien Cassou <damien@cassou.me>> Date: Sat, 14 May 2022 10:37:55 +0200>> Feel free to send a PR to https://gitea.petton.fr/DamienCassou/makel to> add more package archives and to rename (or alias) existing ones.
I tried to register an account a few hours ago. Still haven't received
the confirmation email.
Anyhow, I don't know how to write a Makefile and thus can't do a
rename/alias. The idea is this (feel free to change):
diff --git a/makel.mk b/makel.mk
index 67e8734..0bd7d7d 100644
--- a/makel.mk
+++ b/makel.mk
@@ -4,6 +4,9 @@ MAKEL_LOAD_PATH=-L . $(patsubst %,-L ../%,$(ELPA_DEPENDENCIES))
MAKEL_SET_ARCHIVES0=${ELPA_ARCHIVES}
MAKEL_SET_ARCHIVES1=$(patsubst gnu,(cons \"gnu\" \"https://elpa.gnu.org/packages/\"),${MAKEL_SET_ARCHIVES0})
+MAKEL_SET_ARCHIVES1=$(patsubst elpa,(cons \"elpa\" \"https://elpa.gnu.org/packages/\"),${MAKEL_SET_ARCHIVES0})
+MAKEL_SET_ARCHIVES1=$(patsubst elpa-devel,(cons \"elpa-devel\" \"https://elpa.gnu.org/devel/\"),${MAKEL_SET_ARCHIVES0})
+MAKEL_SET_ARCHIVES1=$(patsubst nongnu,(cons \"nongnu\" \"https://elpa.nongnu.org/nongnu/\"),${MAKEL_SET_ARCHIVES0})
MAKEL_SET_ARCHIVES2=$(patsubst melpa,(cons \"melpa\" \"https://melpa.org/packages/\"),${MAKEL_SET_ARCHIVES1})
MAKEL_SET_ARCHIVES3=$(patsubst melpa-stable,(cons \"melpa-stable\" \"https://stable.melpa.org/packages/\"),${MAKEL_SET_ARCHIVES2})
MAKEL_SET_ARCHIVES4=$(patsubst org,(cons \"org\" \"https://orgmode.org/elpa/\"),${MAKEL_SET_ARCHIVES3})
--
Protesilaos Stavrou
https://protesilaos.com
Hi Protesilaos,
Protesilaos Stavrou <info@protesilaos.com> writes:
> I tried to register an account a few hours ago. Still haven't received> the confirmation email.
I tried to contact him but he is sick.
> Anyhow, I don't know how to write a Makefile and thus can't do a> rename/alias. The idea is this (feel free to change):
I pushed the necessary changes (you were almost right) and created a new
release. Feel free to make according changes in tmr's Makefile (you have
to specify version 0.8.0 instead of 0.7.1).
--
Damien Cassou
"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill
> From: Damien Cassou <damien@cassou.me>> Date: Mon, 16 May 2022 21:01:35 +0200>> Hi Protesilaos,
Good day Damien,
> Protesilaos Stavrou <info@protesilaos.com> writes:>> I tried to register an account a few hours ago. Still haven't received>> the confirmation email.>> I tried to contact him but he is sick.
No worries. I wish him a swift recovery.
>> Anyhow, I don't know how to write a Makefile and thus can't do a>> rename/alias. The idea is this (feel free to change):>> I pushed the necessary changes (you were almost right) and created a new> release. Feel free to make according changes in tmr's Makefile (you have> to specify version 0.8.0 instead of 0.7.1).
Very well! Just updated the Makefile.
--
Protesilaos Stavrou
https://protesilaos.com