~protesilaos/tmr

2 2

Re: Wrong type argument: stringp, 20 error in DENOTE

Daniel Mendler <mail@daniel-mendler.de>
Details
Message ID
<eeed597b-d963-e963-709a-4fb0671225d4@daniel-mendler.de>
DKIM signature
missing
Download raw message
Hi,

maybe we should fix this in the `tmr` function by converting
the input to a string:

         (timer (tmr--timer-create
                 :description description
                 :creation-date creation-date
                 :end-date (time-add creation-date duration)
                 :input (format "%s" time)))

`tmr--unit` still handles numbers. You may want to continue supporting
numeric arguments for backward compatibility.

Daniel

Re: Wrong type argument: stringp, 20 error in DENOTE

Daniel Mendler <mail@daniel-mendler.de>
Details
Message ID
<3ab8c04f-9712-4f1e-8575-b6a6207a9778@daniel-mendler.de>
In-Reply-To
<eeed597b-d963-e963-709a-4fb0671225d4@daniel-mendler.de> (view parent)
DKIM signature
missing
Download raw message
Hey Prot,

to solve this issue, you may want to consider the attached patch which
simplifies tmr--unit and the numeric argument handling.

Daniel

On 7/14/22 14:54, Daniel Mendler wrote:
> Hi,
> 
> maybe we should fix this in the `tmr` function by converting
> the input to a string:
> 
>          (timer (tmr--timer-create
>                  :description description
>                  :creation-date creation-date
>                  :end-date (time-add creation-date duration)
>                  :input (format "%s" time)))
> 
> `tmr--unit` still handles numbers. You may want to continue supporting
> numeric arguments for backward compatibility.
> 
> Daniel

Re: Wrong type argument: stringp, 20 error in DENOTE

Details
Message ID
<87a69blixn.fsf@protesilaos.com>
In-Reply-To
<3ab8c04f-9712-4f1e-8575-b6a6207a9778@daniel-mendler.de> (view parent)
DKIM signature
missing
Download raw message
> From: Daniel Mendler <mail@daniel-mendler.de>
> Date: Thu, 14 Jul 2022 15:01:19 +0200
>
> Hey Prot,

Hello Daniel,

> to solve this issue, you may want to consider the attached patch which
> simplifies tmr--unit and the numeric argument handling.

Thank you!  Just merged it.

All the best,
Prot

-- 
Protesilaos Stavrou
https://protesilaos.com
Reply to thread Export thread (mbox)