From Maarten van Gompel to ~mil/sxmo-devel
This should fix https://todo.sr.ht/~mil/sxmo-tickets/391, I already applied it because it's a major regression. --- configs/default_hooks/is_idle | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/configs/default_hooks/is_idle b/configs/default_hooks/is_idle index e2fb77c..fe5a4c8 100644 --- a/configs/default_hooks/is_idle +++ b/configs/default_hooks/is_idle @@ -3,6 +3,10 @@ # This hook goal is to return a non zero exit code if the device # must be considered not idle (ongoing call, playing mpd, etc) [message trimmed]
From Maarten van Gompel to ~mil/sxmo-devel
Thanks! This looks like a very useful addition. I applied it now (with your follow-up patch for the icon) -- Maarten van Gompel (proycon) https://proycon.anaproy.nl
From Maarten van Gompel to ~mil/sxmo-devel
On 21-10-22 05:03, Avalon Woodard wrote: > Noticed that a missed call notification still came in on muted calls. > After this fix, modemmonitor checkforfinishedcalls identifies cachefile > correctly. Thanks for the patch. I'm a bit confused what this fixes because it looks functionally identical to me. But explicit naming is better than implicit so I merged it. -- Maarten van Gompel (proycon) https://proycon.anaproy.nl
From Maarten van Gompel to ~mil/sxmo-devel
On 21-10-21 11:08, Stacy Harper wrote: > We dont need those config and this prevent the user mpv config to take > priority by default. > > We just drop this completly. Agreed, applied. -- Maarten van Gompel (proycon) https://proycon.anaproy.nl
From Maarten van Gompel to ~mil/sxmo-devel
The doas configuration was considerably broken, I wonder why this didn't emerge in our earlier tests. I removed all absolute paths, because the command is required to be invoked by absolute path then (and we can't be sure where the underlying distro installs things). Better let doas use its internal system path to find the command. I already applied this patch as we have significant regression without it. --- configs/doas/sxmo.conf | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/configs/doas/sxmo.conf b/configs/doas/sxmo.conf [message trimmed]
From Maarten van Gompel to ~mil/sxmo-devel
(already applied) --- configs/doas/sxmo.conf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/doas/sxmo.conf b/configs/doas/sxmo.conf index 8a07a91..5392bda 100644 --- a/configs/doas/sxmo.conf +++ b/configs/doas/sxmo.conf @@ -10,3 +10,5 @@ permit nopass :wheel as root cmd "/sbin/rc-service eg25-manager restart" permit nopass :wheel as root cmd "/sbin/rc-service modemmanager stop" permit nopass :wheel as root cmd "/sbin/rc-service modemmanager start" permit nopass :wheel as root cmd "/sbin/rc-service modemmanager restart" [message trimmed]
From Maarten van Gompel to ~mil/sxmo-devel
(already applied) --- configs/doas/sxmo.conf | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/doas/sxmo.conf b/configs/doas/sxmo.conf index 1186439..8a07a91 100644 --- a/configs/doas/sxmo.conf +++ b/configs/doas/sxmo.conf @@ -3,6 +3,7 @@ permit nopass :wheel as root cmd "/bin/busybox reboot" permit nopass :wheel as root cmd "/sbin/poweroff" permit nopass :wheel as root cmd "/sbin/reboot" permit nopass :wheel as root cmd "/usr/bin/sxmo_wifitoggle.sh" [message trimmed]
From Maarten van Gompel to ~mil/sxmo-devel
Merged now, with an extra commit adding the suggestion by Maxim. Note: Users should ensure that doas is installed! (sxmo-build will take care of this) -- Maarten van Gompel (proycon) https://proycon.anaproy.nl
From Maarten van Gompel to ~mil/sxmo-devel
Nice work! Merged! -- Maarten van Gompel (proycon) https://proycon.anaproy.nl
From Maarten van Gompel to ~mil/sxmo-devel
Applied. On 21-10-20 02:45, Anjandev Momi wrote: > We should add those programs to the swmo ui metapackage Indeed, it shouldn't forget when we release 1.6.0 -- Maarten van Gompel (proycon) https://proycon.anaproy.nl