Thanks! Merged!

--

Maarten van Gompel (proycon)
https://proycon.anaproy.nl

Thanks for your patch (and the lengthy explanation)! I hadn't noticed
the issue yet, but your fix looks good. I applied it to the master
branch now.

--

Maarten van Gompel (proycon)
https://proycon.anaproy.nl

Thanks! I'll give it a try first and will forward the patch upstream after testing.

--

Maarten van Gompel (proycon)
https://proycon.anaproy.nl

Thanks, applied!

--

Maarten van Gompel (proycon)
https://proycon.anaproy.nl

Thanks! Applied. Would be great to have sxmo work on Librem 5!

--

Maarten van Gompel (proycon)
https://proycon.anaproy.nl

Good idea, applied.

--

Maarten van Gompel (proycon)
https://proycon.anaproy.nl

Thanks for this big patch! I already tested the previous version for a
bit and it seems to work quite nicely. I applied this one to the master
branch now.

--

Maarten van Gompel (proycon)
https://proycon.anaproy.nl

On 21-04-11 07:52, Maxim Karasev wrote:
> -				$(command -v neovim     >/dev/null && echo "$icon_vim Neovim      ^ 0 ^ st -e neovim")
> +				$(command -v nvim       >/dev/null && echo "$icon_vim Neovim      ^ 0 ^ st -e nvim")

Right! Silly typo on my part. Merged!

--

Maarten van Gompel
    Language Machines research group
    Centre for Language and Speech Technology
    Radboud Universiteit Nijmegen

proycon@anaproy.nl

I'm testing this patch in my own development branch currently since this
is a pretty big one (will merge into master later). It looks quite
promising.

One minor thing I noticed thus-far is that the proximity sensor works
and is a nice addition, but it also triggers when you haven't picked up
a call yet and move the device to your ear (in which case it either shouldn't
activate yet or do an **opt-in** automatic pickup)

I'll do some further testing

--

Maarten van Gompel (proycon)

Goes hand in hand with the same patch for sxmo-utils (both are required
or things break)

---
 config.def.h | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/config.def.h b/config.def.h
index 3350654..2f09e6a 100644
--- a/config.def.h
+++ b/config.def.h
@@ -85,18 +85,18 @@ static const char *dmenucmd[] = { "dmenu_run", "-m", dmenumon, "-fn", dmenufont,
 #include <X11/XF86keysym.h>
 static Key keys[] = {
[message trimmed]