From: Alyssa Ross <hi@alyssa.is>
To: ~qaul/community@lists.sr.ht
Cc: Katharina Fey <kookie@spacekookie.de>,
	Alyssa Ross <hi@alyssa.is>
Subject: [PATCH 2/2] clients/android: fix build.sh undefined variable
Date: Sun, 31 May 2020 18:17:02 +0000
Message-Id: <20200531181702.6226-2-hi@alyssa.is>
In-Reply-To: <20200531181702.6226-1-hi@alyssa.is>
References: <20200531181702.6226-1-hi@alyssa.is>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

If no argument was given, this script would produce the error:

    ./build.sh: line 9: [: =3D: unary operator expected

This happened because the expansion of the [ command became

    [ =3D "dev" ]

Adding the quotes around $1 makes the expansion

    [ "" =3D "dev" ]

Which is what we actually want.
---
 clients/android/build.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clients/android/build.sh b/clients/android/build.sh
index eb559798..b644bef0 100755
--- a/clients/android/build.sh
+++ b/clients/android/build.sh
@@ -6,7 +6,7 @@ basedir=3D$(realpath $(dirname "$0"))
 user=3D$(id -u)
 group=3D$(id -g)
=20
-if [ $1 =3D "dev" ]; then
+if [ "$1" =3D "dev" ]; then
     echo "Attaching shell for repeated builds."
     echo "Don't invoke gradle yourself! Use 'client/android/.build_neste=
d.sh' instead!"
     echo "Don't forget to run 'export USER=3D$USER GROUP=3D$GROUP'!"
--=20
2.26.2