Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mail-b.sr.ht (Postfix) with ESMTPS id B49C9FF211 for <~qaul/community@lists.sr.ht>; Sun, 31 May 2020 18:17:31 +0000 (UTC) Authentication-Results: mail-b.sr.ht; dkim=pass (2048-bit key) header.d=alyssa.is header.i=@alyssa.is header.b=FfD/Pq3T; dkim=fail reason="key not found in DNS" (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=HX2rh+2K Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 72BDC5C00CF; Sun, 31 May 2020 14:17:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 31 May 2020 14:17:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm3; bh=PJ7wNaS1ni98c 3PH8VBHTu4iQMhzIx1phpViuXgaicM=; b=FfD/Pq3TccKj9DLw2rleEDJveXM1i vFZM6HnwHpKDV5wGVlHosHNf1mQyCM/G/kJN4fdXMtB1Rs9z3FzRsrkbVP+EHo+R 28vH9TqAhmytQMdbsp5IY3jM5P6HPTf5SIzYR07+HTCkFsIV7j8k2B96sCukJK4M RxsKokGlE/rZbKude5RJ3nnb3IVEm0Bni8cekUeFNovOlnO5ac4KZDEY83OmBzL8 x9fDXDqvJe8OcMjEnUMkHm7EVGT+Gc6gfVlvxZdC5oj0CjWDKO9M81QSr63F5r9+ 4R95v4rFtpH9lWvDWcOSOgUKttCrSkb9/opQtgba2o9WQ9PSIOTVNWNpw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=PJ7wNaS1ni98c3PH8VBHTu4iQMhzIx1phpViuXgaicM=; b=HX2rh+2K LPCjlO1Ck2jOxIGabn/wS4EtNIr2i5OwKYVHHYNyFAtuN+BgnTXwJKg88xLmNSEd Atk9TmEVpuKGe7kM9edqkGLMXsJsf28gAJ6KWDgASckIExcgEcy2vfcYDzqBMjT5 0odH5CTkJ78Sq0VwEwXIe348szLNzH6NjRyqRamC/SxPFP3tytN0Ipy3QvNv8/BF wSJwKY7RO3bG7EW0d+meB/rYMceJGvj/j7g5tGme5qZFWXrHjn1qcMYzvPJXzhUU Y6ETEWMmOnvvAZST4VYfcptrjp+UufbnyYkMkBEzsi/9TNcYsBx+OagJKWYukFoV S9iTq9uNySUuXg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudeffedguddvtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpeetlhihshhsrgcutfhoshhsuceohhhisegrlhihshhsrgdr ihhsqeenucggtffrrghtthgvrhhnpefgfedukedvleeileeludefveehgeelgfegvdduje dvtdffueeuveffheeljeekvdenucfkphepjeelrddvfeehrdduudelrdduleegnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepqhihlhhishhsse igvddvtddrqhihlhhishhsrdhnvght X-ME-Proxy: Received: from x220.qyliss.net (p4feb77c2.dip0.t-ipconnect.de [79.235.119.194]) by mail.messagingengine.com (Postfix) with ESMTPA id C48ED3280059; Sun, 31 May 2020 14:17:30 -0400 (EDT) Received: by x220.qyliss.net (Postfix, from userid 1000) id F07B2484; Sun, 31 May 2020 18:17:28 +0000 (UTC) From: Alyssa Ross To: ~qaul/community@lists.sr.ht Cc: Katharina Fey , Alyssa Ross Subject: [PATCH 2/2] clients/android: fix build.sh undefined variable Date: Sun, 31 May 2020 18:17:02 +0000 Message-Id: <20200531181702.6226-2-hi@alyssa.is> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200531181702.6226-1-hi@alyssa.is> References: <20200531181702.6226-1-hi@alyssa.is> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable If no argument was given, this script would produce the error: ./build.sh: line 9: [: =3D: unary operator expected This happened because the expansion of the [ command became [ =3D "dev" ] Adding the quotes around $1 makes the expansion [ "" =3D "dev" ] Which is what we actually want. --- clients/android/build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/android/build.sh b/clients/android/build.sh index eb559798..b644bef0 100755 --- a/clients/android/build.sh +++ b/clients/android/build.sh @@ -6,7 +6,7 @@ basedir=3D$(realpath $(dirname "$0")) user=3D$(id -u) group=3D$(id -g) =20 -if [ $1 =3D "dev" ]; then +if [ "$1" =3D "dev" ]; then echo "Attaching shell for repeated builds." echo "Don't invoke gradle yourself! Use 'client/android/.build_neste= d.sh' instead!" echo "Don't forget to run 'export USER=3D$USER GROUP=3D$GROUP'!" --=20 2.26.2