From: Katharina Fey <kookie@spacekookie.de>
To: Alyssa Ross <hi@alyssa.is>, ~qaul/community@lists.sr.ht
Subject: Re: [PATCH 1/2] clients/android: don't override USER in build.sh
In-Reply-To: <87v9kba6yx.fsf@alyssa.is>
References: <20200531181702.6226-1-hi@alyssa.is> <87v9kba6yx.fsf@alyssa.is>
Date: Fri, 19 Jun 2020 12:43:53 +0200
Message-ID: <87lfkjz66u.fsf@kookie.space>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain

Hey there,

>>  if [ $1 = "dev" ]; then
>>      echo "Attaching shell for repeated builds."
>>      echo "Don't invoke gradle yourself! Use 'client/android/.build_nested.sh' instead!"
>>      echo "Don't forget to run 'export USER=$USER GROUP=$GROUP'!"
>
> This should have been changed too, but I'm not sure what these
> instructions are actually for.  I think the idea is that
> .build_nested.sh uses them, but looking at the source for that, it
> actually uses positional arguments instead.
>
> So I'm not really sure what to do with this until that's clarified.

Ah yes, that's kinda wrong at the moment.

The ./build_nested.sh script shouldn't use positional paraments because
it makes using it inside the container shell much more annoying.  So
maybe we just wanna set QAUL_USER and QAUL_GROUP as env vars then that
the script can use? (don't actually know how we spawn a shell in the
container that has a certain env set in case of the dev setup.

Anyway, long story short: remove the 'export ...' instructions, and make
both build.sh and .build_nested.sh use a custom env var to store the
UIDs.  Does that make sense?

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEVV8uS2+H+RpBEGaekHNKnmGcimwFAl7slukACgkQkHNKnmGc
imwy0w//dy9oMq+2WJd4cz99Xm3KIUOn9q09qWt0BQWDSbTJY26ubC2V0ykJwSOu
Gp57IRlzYOqNeIKfzAI5eWv8UE5jEYVRdlbbWgEmHGCb9EBF9H/b7XsYR6V+2UKx
UuMu/9Li7LVOou4F/G/IuJnGUVdl5qYzEKgTjLqo2LWXRv1ta/+ljjl9hc6bkzs4
Uj7UJI2GCJa78BXNm2P0RTSkZbSMIVOypR/H81aHdYcHQjlywes5ucHGOp2+s5KW
ZPYp66G1KzCJyqHy8fmWgaA4n+pah/dMmZdvi6x/KTA4Bx57hFUvBjqLlpn2mpoG
l6NYYqQtkxwQhHa1/ViANSNRtTBxxfKGho+F85MZFe2Y4DLSJLQg49dP8eJ7e/DI
lW6ARIzJprgKFCrvQnJDlf8CFjB5KFUhtM6gJmZRnFVer+E7TdiK9qtpu7vnqCZD
zppB1ktgoL3qQN7/IMb3tJtAoS2lSrHTJWELab93WGrHU5hulfVbXs90/h397Ol8
/bduA0Y6sWOXxPsvNCfz4QmttJ1P0DsJjagLo2cYq2cduRYqbbpqFBGUG3cvTj+O
pwm9EDrPS1Jmxbl5kGlLlKC0FKG8y+wgUpSwDJukUqNJy8TDLQwRyBEbtOFfXXCq
J0eF5WphGjhGn2s1e4GcKpmQRwBhFhAGOAkCjAs/2EKZ0Q7ejew=
=IGKb
-----END PGP SIGNATURE-----
--=-=-=--