From: Alyssa Ross <hi@alyssa.is>
To: ~qaul/community@lists.sr.ht, Katharina Fey <kookie@spacekookie.de>
Subject: Re: [PATCH 1/2] clients/android: don't override USER in build.sh
In-Reply-To: <20200531181702.6226-1-hi@alyssa.is>
References: <20200531181702.6226-1-hi@alyssa.is>
Date: Mon, 01 Jun 2020 01:51:50 +0000
Message-ID: <87v9kba6yx.fsf@alyssa.is>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

> USER is a standard global environment variable that contains the name
> of the current user.  Previously, build.sh would reassign user to be
> the id of the current user.  This would break podman, which uses $USER
> to find the name of the user to look up in /etc/subuid.
>
> Since environment variables are conventionally upper case, using
> lowercase variable names in scripts avoids the problem of overriding
> variables in the environment.
> [snip]
>=20
>  if [ $1 =3D "dev" ]; then
>      echo "Attaching shell for repeated builds."
>      echo "Don't invoke gradle yourself! Use 'client/android/.build_neste=
d.sh' instead!"
>      echo "Don't forget to run 'export USER=3D$USER GROUP=3D$GROUP'!"

This should have been changed too, but I'm not sure what these
instructions are actually for.  I think the idea is that
.build_nested.sh uses them, but looking at the source for that, it
actually uses positional arguments instead.

So I'm not really sure what to do with this until that's clarified.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAl7UXzYACgkQ+dvtSFmy
ccBHkw//dfA9MTQODwAb8BL+rMMmo3Edbo8bwYL498xkRzdWfu9m9iu7VnI2nRyW
6pIuSq+XQYZMa9nifNfx2GL6SJX41Ds90tPHMfkrqna123UJIlW6upee5LENThJ+
3SjKsZKmmu5XFFF2gVksG9XzhxtEE1JIJNkNngXWxYHoFTac9HsoVAz1pNlCa64K
mnBFzW+/vMdJDGaPMwjALKecaTlMXewIjBDY20i4gbuB3eNUgcj+uvewSy9YlR6y
3Y/4r9JPl4Mro9N71/k7lMyOb9ZELzkDxpdS2SXcwDUYWjHpkwDJ9AitHKevhARh
vJnX4ryyjhrqgdaYiTuu/IqC6r+zU1lhRXIIgTIF155m7QIVPjQSV2Tp38PzQZiV
1npIGYFScs6El7F0ZndC3FklUh2Y61wzEEVNHvmkoRJcaOkZPI0twSSeVZGdB0CS
xJBLMoiuOXMBx9ZBWECCfUyWXRpvvCzvRcmKllR86v0eJclxpgh8JYq7aFfypBfV
Bsr0k2r0/uyn3jkIysI5anU2b+TJL9qs1OALOAyIa8Yeene5r4Pjq3cnRSwhlfSL
b+cmcU0i8SCdApQGYuonhHD954MM4v92c5PG1ol99jHEY6kdU9W+NgHH0uJxpu5s
6G2BtZy7IwwtJ09d91aAyuRphh8d23Dt9jp/eXaBL5H9X602GPA=
=/7yM
-----END PGP SIGNATURE-----
--=-=-=--