~rabbits/public-inbox

Modify controller char code only on keydown v1 APPLIED

Kyle Perik: 1
 Modify controller char code only on keydown

 1 files changed, 1 insertions(+), 1 deletions(-)
Export patchset (mbox)
How do I use this?

Copy & paste the following snippet into your terminal to import this patchset into git:

curl -s https://lists.sr.ht/~rabbits/public-inbox/patches/47248/mbox | git am -3
Learn more about email & git

[PATCH] Modify controller char code only on keydown Export this patch

---
I see .Controller/key always gets overwritten to 0 on keyup, which appears to be a discrepancy with the C version.

I just moved it up a few lines into the conditional already checking for keydown.

 src/devices/controller.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/devices/controller.js b/src/devices/controller.js
index 3c55e14..d024dc0 100644
--- a/src/devices/controller.js
+++ b/src/devices/controller.js
@@ -39,12 +39,12 @@ function Controller(emu) {
		} else if (mask == 0 && event.keyCode < 20) {
			charCode = event.keyCode;
		}
		emu.uxn.dev[0x83] = charCode;
		} else {
			this.keys &= ~mask;
		}
		// console.log("keydown", event.key, (0x83).toString(16));
		emu.uxn.dev[0x82] = this.keys;
		emu.uxn.dev[0x83] = charCode;
		emu.uxn.eval(peek16(emu.uxn.dev, 0x80))
	}
}
-- 
2.32.1 (Apple Git-133)