~radicle-link/dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
26 5

[PATCH v1] Sync LICENSE file with Radicle Upstream

Details
Message ID
<20220203220246.49585-1-jason@jasonyundt.email>
DKIM signature
pass
Download raw message
Patch: +11 -8
Radicle Upstream’s LICENSE file [1] had some improvements that this
repo’s LICENSE file was missing. This change adds those improvements:

- Bump copyright year to 2022.
- Fix capitalization of “Developer Certificate of Origin”.
- Correct location of DCO. Before this change, LICENSE incorrectly said
  that the DCO was “below”.

[1]: <https://github.com/radicle-dev/radicle-upstream/blob/main/LICENSE>

Signed-off-by: Jason Yundt <jason@jasonyundt.email>
Published-As: <https://github.com/Jayman2000/radicle-link-patch/releases/tag/patches%2Flicense-improvements%2Fv1>
---
 LICENSE | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/LICENSE b/LICENSE
index c4744b96..a7cd4567 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1,18 +1,21 @@
radicle-link is Copyright © 2019-2020
radicle-link is Copyright © 2019-2022
The Radicle Foundation <hello@radicle.foundation>

radicle-link is licensed under version 3 of the GNU General Public
License (GPLv3) with the Radicle Linking Exception. Any contribution
to radicle-link must be made subject to the developer certificate of
origin (DCO).
to radicle-link must be made subject to the Developer Certificate of
Origin (DCO).

By making your contribution, you are (1) making the declaration set
out in the Linux Foundation’s Developer Certificate of Origin
version 1.1 as set out below, in which the “open source licence
indicated in the file” is GPLv3 with the Radicle Linking Exception, and
(2) granting the additional permission referred to in the Radicle
Linking Exception to downstream recipients of current and future
versions of radicle-link released by the Radicle Foundation.
version 1.1, in which the “open source licence indicated in the file” is
GPLv3 with the Radicle Linking Exception, and (2) granting the additional
permission referred to in the Radicle Linking Exception to downstream
recipients of current and future versions of radicle-link released by the
Radicle Foundation.

A copy of Radicle Linking Exception and the GPLv3 can be found below. A
copy of the DCO can be found in the file named “DCO”.

                       Radicle Linking Exception

-- 
2.35.1
Details
Message ID
<20220204092601.GD43431@schmidt.localdomain>
In-Reply-To
<20220203220246.49585-1-jason@jasonyundt.email> (view parent)
DKIM signature
pass
Download raw message
On Thu, 03 Feb 2022 17:02:46 -0500 Jason Yundt <jason@jasonyundt.email> wrote:
> diff --git a/LICENSE b/LICENSE
> index c4744b96..a7cd4567 100644
> --- a/LICENSE
> +++ b/LICENSE
> @@ -1,18 +1,21 @@
> -radicle-link is Copyright © 2019-2020
> +radicle-link is Copyright © 2019-2022
>  The Radicle Foundation <hello@radicle.foundation>
>
>  radicle-link is licensed under version 3 of the GNU General Public
>  License (GPLv3) with the Radicle Linking Exception. Any contribution
> -to radicle-link must be made subject to the developer certificate of
> -origin (DCO).
> +to radicle-link must be made subject to the Developer Certificate of
> +Origin (DCO).
>
>  By making your contribution, you are (1) making the declaration set
>  out in the Linux Foundation’s Developer Certificate of Origin
> -version 1.1 as set out below, in which the “open source licence
> -indicated in the file” is GPLv3 with the Radicle Linking Exception, and
> -(2) granting the additional permission referred to in the Radicle
> -Linking Exception to downstream recipients of current and future
> -versions of radicle-link released by the Radicle Foundation.
> +version 1.1, in which the “open source licence indicated in the file” is
> +GPLv3 with the Radicle Linking Exception, and (2) granting the additional
> +permission referred to in the Radicle Linking Exception to downstream
> +recipients of current and future versions of radicle-link released by the
> +Radicle Foundation.
> +
> +A copy of Radicle Linking Exception and the GPLv3 can be found below. A
> +copy of the DCO can be found in the file named “DCO”.
>
>                         Radicle Linking Exception


Thanks for bringing this up. I think, however, that we need to get a detail
clarified first: since Monadic GmbH is no longer sponsoring radicle-link
development, maintainers are no longer waiving their copyright automatically
(and contributors neither). That is, the copyright is held 2019-2021 by the
Radicle Foundation, but since 2021 by "The Radicle Link Contributors".

Now, the clause "... released by the Radicle Foundation" for the linking
exception was intended to mean "there is only a linking exception for releases
made by the Radicle Foundation". Ie. if a release is made by someone else, the
license is plain GPLv3 without any exceptions.

As there is no defined process of how the Radicle Foundation would make releases
of radicle-link, I think we should clarify that, most of the time, the Radicle
Linking Exception does not apply.

[PATCH v2 0/2] LICENSE improvements

Details
Message ID
<20220204121122.13741-1-jason@jasonyundt.email>
In-Reply-To
<20220203220246.49585-1-jason@jasonyundt.email> (view parent)
DKIM signature
pass
Download raw message
The first version of this patch was named “[PATCH v1] Sync LICENSE file
with Radicle Upstream”. This new version:

- Introduces the improvements from radicle-upstream#2742 [1]. (This
  makes the first commit message a bit misleading because I’m assuming
  that that PR will be merged).
- Adds the clarifications that Kim asked for when reviewing the first
  version.

[1]: <https://github.com/radicle-dev/radicle-upstream/pull/2742>

Jason Yundt (2):
  Sync LICENSE file with Radicle Upstream
  Clarify copyright and licensing situation

 LICENSE | 58 +++++++++++++++++++++++++++++++--------------------------
 1 file changed, 32 insertions(+), 26 deletions(-)

-- 
2.35.1

[PATCH v2 1/2] Sync LICENSE file with Radicle Upstream

Details
Message ID
<20220204121122.13741-2-jason@jasonyundt.email>
In-Reply-To
<20220204121122.13741-1-jason@jasonyundt.email> (view parent)
DKIM signature
pass
Download raw message
Patch: +26 -24
Radicle Upstream’s LICENSE file [1] had some improvements that this
repo’s LICENSE file was missing. This change adds those improvements:

- Bump copyright year.
- Fix capitalization of “Developer Certificate of Origin”.
- Correct location of DCO. Before this change, LICENSE incorrectly said
  that the DCO was “below”.
- More consistent word wrapping.

[1]: <https://github.com/radicle-dev/radicle-upstream/blob/main/LICENSE>

Signed-off-by: Jason Yundt <jason@jasonyundt.email>
Published-As: <https://github.com/Jayman2000/radicle-link-patch/releases/tag/patches/license-improvements/v2>
---
 LICENSE | 50 ++++++++++++++++++++++++++------------------------
 1 file changed, 26 insertions(+), 24 deletions(-)

diff --git a/LICENSE b/LICENSE
index c4744b96..840d3a50 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1,29 +1,31 @@
radicle-link is Copyright © 2019-2020
radicle-link is Copyright © 2019-2021
The Radicle Foundation <hello@radicle.foundation>

radicle-link is licensed under version 3 of the GNU General Public
License (GPLv3) with the Radicle Linking Exception. Any contribution
to radicle-link must be made subject to the developer certificate of
origin (DCO).

By making your contribution, you are (1) making the declaration set
out in the Linux Foundation’s Developer Certificate of Origin
version 1.1 as set out below, in which the “open source licence
indicated in the file” is GPLv3 with the Radicle Linking Exception, and
(2) granting the additional permission referred to in the Radicle
Linking Exception to downstream recipients of current and future
versions of radicle-link released by the Radicle Foundation.

                       Radicle Linking Exception

In addition to the permissions in the GNU General Public License,
the authors give you unlimited permission to link the compiled
version of this unmodified program into combinations with other programs,
and to distribute those combinations without any restriction
coming from the use of this program. (The General Public License
restrictions do apply in other respects; for example, they cover
modification of this program, and distribution when not linked into
a combined executable.)
radicle-link is licensed under version 3 of the GNU General Public License
(GPLv3) with the Radicle Linking Exception. Any contribution to
radicle-link must be made subject to the Developer Certificate of Origin
(DCO).

By making your contribution, you are (1) making the declaration set out in
the Linux Foundation’s Developer Certificate of Origin version 1.1, in
which the “open source licence indicated in the file” is GPLv3 with the
Radicle Linking Exception, and (2) granting the additional permission
referred to in the Radicle Linking Exception to downstream recipients of
current and future versions of radicle-link released by the Radicle
Foundation.

A copy of the Radicle Linking Exception and the GPLv3 can be found below.
A copy of the DCO can be found in the file named “DCO”.

                        Radicle Linking Exception

In addition to the permissions in the GNU General Public License, the
authors give you unlimited permission to link the compiled version of this
unmodified program into combinations with other programs, and to
distribute those combinations without any restriction coming from the use
of this program. (The General Public License restrictions do apply in
other respects; for example, they cover modification of this program, and
distribution when not linked into a combined executable.)

--------------------------------------------------------------------------

-- 
2.35.1

[PATCH v2 2/2] Clarify copyright and licensing situation

Details
Message ID
<20220204121122.13741-3-jason@jasonyundt.email>
In-Reply-To
<20220204121122.13741-1-jason@jasonyundt.email> (view parent)
DKIM signature
pass
Download raw message
Patch: +9 -5
This change clarifies that the Radicle Link Contributors have some
copyright over radicle-link. It also clarifies that the Radicle Linking
Exception only applies to versions released by the Radicle Foundation.

Signed-off-by: Jason Yundt <jason@jasonyundt.email>
---
 LICENSE | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/LICENSE b/LICENSE
index 840d3a50..829dfdf7 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1,10 +1,14 @@
radicle-link is Copyright © 2019-2021
The Radicle Foundation <hello@radicle.foundation>
radicle-link
Copyright © 2019-2021 The Radicle Foundation <hello@radicle.foundation>
Copyright © 2019-2021 The Radicle Link Contributors
<https://github.com/radicle-dev/radicle-link/graphs/contributors>

radicle-link is licensed under version 3 of the GNU General Public License
(GPLv3) with the Radicle Linking Exception. Any contribution to
radicle-link must be made subject to the Developer Certificate of Origin
(DCO).
(GPLv3) sometimes with the Radicle Linking Exception. The Radicle Linking
Exception only applies to released created by the Radicle Foundation. At
the moment, there is no defined process for how the Radicle Foundation
would make releases of radicle-link. Any contribution to radicle-link must
be made subject to the Developer Certificate of Origin (DCO).

By making your contribution, you are (1) making the declaration set out in
the Linux Foundation’s Developer Certificate of Origin version 1.1, in
-- 
2.35.1
Details
Message ID
<20220209204711.GB941898@schmidt.localdomain>
In-Reply-To
<20220204092601.GD43431@schmidt.localdomain> (view parent)
DKIM signature
pass
Download raw message
Alexis,

do you want to comment on this?

If we want to keep the linking exception, a simple process could be "whatever
release tag is published at https://github.com/radicle-dev/radicle-link
constitutes a release by The Radicle Foundation".

It might however be that the linking exception is becoming obsolete anyway,
because it is possible to build applications which talk to a Radicle (Link) node
over the network (even if that's the local host).
Details
Message ID
<zWvcsJHutccEwNcIYhX0TDFNbg2ZcNgpTg2EIm-UmGBOb_hi1_7esuEeZMuxBJl5-tKnfMXi9K_9CfJu8aPtamqw3Y0p7ic-y7KMYAOjvsE=@radicle.foundation>
In-Reply-To
<20220209204711.GB941898@schmidt.localdomain> (view parent)
DKIM signature
pass
Download raw message
I see two options:

1. Make the linking exception always apply for any code released by the link team
2. Deprecate the linking exception

(1) is more permissive, (2) less so, though as you said there are ways around using link if (2).

------- Original Message -------

On Wednesday, February 9th, 2022 at 20:47, Kim Altintop <kim@eagain.st> wrote:

> Alexis,
> 

> do you want to comment on this?
> 

> If we want to keep the linking exception, a simple process could be "whatever
> 

> release tag is published at https://github.com/radicle-dev/radicle-link
> 

> constitutes a release by The Radicle Foundation".
> 

> It might however be that the linking exception is becoming obsolete anyway,
> 

> because it is possible to build applications which talk to a Radicle (Link) node
> 

> over the network (even if that's the local host).
Details
Message ID
<20220210135924.GF2562@schmidt.localdomain>
In-Reply-To
<zWvcsJHutccEwNcIYhX0TDFNbg2ZcNgpTg2EIm-UmGBOb_hi1_7esuEeZMuxBJl5-tKnfMXi9K_9CfJu8aPtamqw3Y0p7ic-y7KMYAOjvsE=@radicle.foundation> (view parent)
DKIM signature
pass
Download raw message
On Thu, 10 Feb 2022 09:40:36 +0000 Alexis Sellier <alexis@radicle.foundation> wrote:
> I see two options:
>
> 1. Make the linking exception always apply for any code released by the link team
> 2. Deprecate the linking exception
>
> (1) is more permissive, (2) less so, though as you said there are ways around using link if (2).

Right. So. Which one do you prefer?

The linking exception is currently granted by the foundation, which means that
only the foundation can revoke it (it also doesn't need to ask any
contributors). If the foundation would want to transfer the right to grant the
linking exception to the "link team", we need to define what the "link team" is
and how to verify that the release was made by it.

The strategic significance of the exception was not so much to prevent
proprietary software to be derived from the link code, but to allow software
under open source but non-copyleft licenses to integrate. The only way I could
see this apply in practice is if someone would want to build an (iOS) mobile
app. I'm not sure how much sense this makes, but who knows.

My opinion as a link maintainer is that the link project itself does not have
much interest in the exception.
Details
Message ID
<2qwDtk7Y_EZGod5su3QS933TZVBcYLaPEFVPx-LgZ6wLS6cFd-JdmWCzu2yGgTCP3QBMB7It169YN073ohFvAzQeJZuoGHSIhQV5c7Z9k3g=@radicle.foundation>
In-Reply-To
<20220210135924.GF2562@schmidt.localdomain> (view parent)
DKIM signature
pass
Download raw message
Let's drop it then. I hereby decree the Radicle Linking exception defunct.

------- Original Message -------

On Thursday, February 10th, 2022 at 13:59, Kim Altintop <kim@eagain.st> wrote:

> On Thu, 10 Feb 2022 09:40:36 +0000 Alexis Sellier alexis@radicle.foundation wrote:
> 

> > I see two options:
> > 

> > 1.  Make the linking exception always apply for any code released by the link team
> > 2.  Deprecate the linking exception
> > 

> > (1) is more permissive, (2) less so, though as you said there are ways around using link if (2).
> 

> Right. So. Which one do you prefer?
> 

> The linking exception is currently granted by the foundation, which means that
> 

> only the foundation can revoke it (it also doesn't need to ask any
> 

> contributors). If the foundation would want to transfer the right to grant the
> 

> linking exception to the "link team", we need to define what the "link team" is
> 

> and how to verify that the release was made by it.
> 

> The strategic significance of the exception was not so much to prevent
> 

> proprietary software to be derived from the link code, but to allow software
> 

> under open source but non-copyleft licenses to integrate. The only way I could
> 

> see this apply in practice is if someone would want to build an (iOS) mobile
> 

> app. I'm not sure how much sense this makes, but who knows.
> 

> My opinion as a link maintainer is that the link project itself does not have
> 

> much interest in the exception.

[PATCH radicle-link v3 2/3] Clarify copyright situation

Details
Message ID
<20220216174002.30455-3-jason@jasonyundt.email>
In-Reply-To
<20220216174002.30455-1-jason@jasonyundt.email> (view parent)
DKIM signature
pass
Download raw message
Patch: +4 -2
This change clarifies that the Radicle Link Contributors have some
copyright over radicle-link.

Signed-off-by: Jason Yundt <jason@jasonyundt.email>
---
 LICENSE | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/LICENSE b/LICENSE
index 840d3a50..e69a4413 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1,5 +1,7 @@
radicle-link is Copyright © 2019-2021
The Radicle Foundation <hello@radicle.foundation>
radicle-link
Copyright © 2019-2021 The Radicle Foundation <hello@radicle.foundation>
Copyright © 2019-2021 The Radicle Link Contributors
<https://github.com/radicle-dev/radicle-link/graphs/contributors>

radicle-link is licensed under version 3 of the GNU General Public License
(GPLv3) with the Radicle Linking Exception. Any contribution to
-- 
2.35.1

[PATCH radicle-link v3 3/3] Remove Radicle Linking Exception

Details
Message ID
<20220216174002.30455-4-jason@jasonyundt.email>
In-Reply-To
<20220216174002.30455-1-jason@jasonyundt.email> (view parent)
DKIM signature
pass
Download raw message
Patch: +11 -32
The discussion that resulted in this change can be found here:
<https://lists.sr.ht/~radicle-link/dev/%3C20220203220246.49585-1-jason%40jasonyundt.email%3E>

Signed-off-by: Jason Yundt <jason@jasonyundt.email>
---
 DCO       | 10 +++-------
 LICENSE   | 31 +++++++------------------------
 README.md |  2 +-
 3 files changed, 11 insertions(+), 32 deletions(-)

diff --git a/DCO b/DCO
index 24951788..d53d3ada 100644
--- a/DCO
+++ b/DCO
@@ -1,12 +1,8 @@
                  Developer Certificate of Origin

By making your contribution, you are (1) making the declaration set
out in the Linux Foundation’s Developer Certificate of Origin
version 1.1 as set out below, in which the “open source licence indicated
in the file” is GPLv3 with the Radicle Linking Exception, and (2) granting the
additional permission referred to in the Radicle Linking Exception to
downstream recipients of current and future versions of radicle-upstream
released by the Radicle Foundation.
By making your contribution, you are making the declaration set out in the
Linux Foundation’s Developer Certificate of Origin version 1.1 as set out
below, in which the “open source licence indicated in the file” is GPLv3.

Developer Certificate of Origin
Version 1.1
diff --git a/LICENSE b/LICENSE
index e69a4413..5201fd60 100644
--- a/LICENSE
+++ b/LICENSE
@@ -4,30 +4,13 @@ Copyright © 2019-2021 The Radicle Link Contributors
<https://github.com/radicle-dev/radicle-link/graphs/contributors>

radicle-link is licensed under version 3 of the GNU General Public License
(GPLv3) with the Radicle Linking Exception. Any contribution to
radicle-link must be made subject to the Developer Certificate of Origin
(DCO).

By making your contribution, you are (1) making the declaration set out in
the Linux Foundation’s Developer Certificate of Origin version 1.1, in
which the “open source licence indicated in the file” is GPLv3 with the
Radicle Linking Exception, and (2) granting the additional permission
referred to in the Radicle Linking Exception to downstream recipients of
current and future versions of radicle-link released by the Radicle
Foundation.

A copy of the Radicle Linking Exception and the GPLv3 can be found below.
A copy of the DCO can be found in the file named “DCO”.

                        Radicle Linking Exception

In addition to the permissions in the GNU General Public License, the
authors give you unlimited permission to link the compiled version of this
unmodified program into combinations with other programs, and to
distribute those combinations without any restriction coming from the use
of this program. (The General Public License restrictions do apply in
other respects; for example, they cover modification of this program, and
distribution when not linked into a combined executable.)
(GPLv3). Any contribution to radicle-link must be made subject to the
Developer Certificate of Origin (DCO).

By making your contribution, you are making the declaration set out in the
Linux Foundation’s Developer Certificate of Origin version 1.1, in which
the “open source licence indicated in the file” is GPLv3. A copy of the
DCO can be found in the file named “DCO”.

--------------------------------------------------------------------------

diff --git a/README.md b/README.md
index e1dcb173..693fac42 100644
--- a/README.md
+++ b/README.md
@@ -25,7 +25,7 @@ installation is currently required as a runtime dependency.
## License

Unless otherwise noted, all source code in this repository is licensed under the
[GPLv3] with the Radicle Linking Exception. See the [LICENSE] file for details.
[GPLv3]. See the [LICENSE] file for details.

## Contributing

-- 
2.35.1

[PATCH radicle-link v3 0/3] Improvements to copyright and licensing info

Details
Message ID
<20220216174002.30455-1-jason@jasonyundt.email>
In-Reply-To
<20220203220246.49585-1-jason@jasonyundt.email> (view parent)
DKIM signature
pass
Download raw message
Compared to the previous version of this patch, this one removes the
Radicle Linking Exception.

Published-As: <https://git.sr.ht/~jayman/radicle-link/refs/patches/license-improvements/v3>

Jason Yundt (3):
  Sync LICENSE file with Radicle Upstream
  Clarify copyright situation
  Remove Radicle Linking Exception

 DCO       | 10 +++-------
 LICENSE   | 39 +++++++++++++--------------------------
 README.md |  2 +-
 3 files changed, 17 insertions(+), 34 deletions(-)

-- 
2.35.1

[PATCH radicle-link v3 1/3] Sync LICENSE file with Radicle Upstream

Details
Message ID
<20220216174002.30455-2-jason@jasonyundt.email>
In-Reply-To
<20220216174002.30455-1-jason@jasonyundt.email> (view parent)
DKIM signature
pass
Download raw message
Patch: +26 -24
Radicle Upstream’s LICENSE file [1] had some improvements that this
repo’s LICENSE file was missing. This change adds those improvements:

- Bump copyright year.
- Fix capitalization of “Developer Certificate of Origin”.
- Correct location of DCO. Before this change, LICENSE incorrectly said
  that the DCO was “below”.
- More consistent word wrapping.

[1]: <https://github.com/radicle-dev/radicle-upstream/blob/main/LICENSE>

Signed-off-by: Jason Yundt <jason@jasonyundt.email>
---
 LICENSE | 50 ++++++++++++++++++++++++++------------------------
 1 file changed, 26 insertions(+), 24 deletions(-)

diff --git a/LICENSE b/LICENSE
index c4744b96..840d3a50 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1,29 +1,31 @@
radicle-link is Copyright © 2019-2020
radicle-link is Copyright © 2019-2021
The Radicle Foundation <hello@radicle.foundation>

radicle-link is licensed under version 3 of the GNU General Public
License (GPLv3) with the Radicle Linking Exception. Any contribution
to radicle-link must be made subject to the developer certificate of
origin (DCO).

By making your contribution, you are (1) making the declaration set
out in the Linux Foundation’s Developer Certificate of Origin
version 1.1 as set out below, in which the “open source licence
indicated in the file” is GPLv3 with the Radicle Linking Exception, and
(2) granting the additional permission referred to in the Radicle
Linking Exception to downstream recipients of current and future
versions of radicle-link released by the Radicle Foundation.

                       Radicle Linking Exception

In addition to the permissions in the GNU General Public License,
the authors give you unlimited permission to link the compiled
version of this unmodified program into combinations with other programs,
and to distribute those combinations without any restriction
coming from the use of this program. (The General Public License
restrictions do apply in other respects; for example, they cover
modification of this program, and distribution when not linked into
a combined executable.)
radicle-link is licensed under version 3 of the GNU General Public License
(GPLv3) with the Radicle Linking Exception. Any contribution to
radicle-link must be made subject to the Developer Certificate of Origin
(DCO).

By making your contribution, you are (1) making the declaration set out in
the Linux Foundation’s Developer Certificate of Origin version 1.1, in
which the “open source licence indicated in the file” is GPLv3 with the
Radicle Linking Exception, and (2) granting the additional permission
referred to in the Radicle Linking Exception to downstream recipients of
current and future versions of radicle-link released by the Radicle
Foundation.

A copy of the Radicle Linking Exception and the GPLv3 can be found below.
A copy of the DCO can be found in the file named “DCO”.

                        Radicle Linking Exception

In addition to the permissions in the GNU General Public License, the
authors give you unlimited permission to link the compiled version of this
unmodified program into combinations with other programs, and to
distribute those combinations without any restriction coming from the use
of this program. (The General Public License restrictions do apply in
other respects; for example, they cover modification of this program, and
distribution when not linked into a combined executable.)

--------------------------------------------------------------------------

-- 
2.35.1

Re: [PATCH radicle-link v3 0/3] Improvements to copyright and licensing info

Details
Message ID
<CAH_DpYTtW8eggp6XTgarWmfT1LUJqzzK=zX-uEthk-e5Q3hq5Q@mail.gmail.com>
In-Reply-To
<20220216174002.30455-1-jason@jasonyundt.email> (view parent)
DKIM signature
missing
Download raw message
These changes LGTM but I think it would probably make more sense to have
them all as one commit

Re: [PATCH radicle-link v3 0/3] Improvements to copyright and licensing info

Details
Message ID
<20220217161131.GE1962@schmidt.localdomain>
In-Reply-To
<CAH_DpYTtW8eggp6XTgarWmfT1LUJqzzK=zX-uEthk-e5Q3hq5Q@mail.gmail.com> (view parent)
DKIM signature
pass
Download raw message
On Thu, 17 Feb 2022 06:34:12 -0800 Alex Good <alex@memoryandthought.me> wrote:
> These changes LGTM but I think it would probably make more sense to have
> them all as one commit

I think it's fine, but I dread the change which removes mention of the linking
exception from the file headers.. :(

Re: [PATCH radicle-link v3 2/3] Clarify copyright situation

Details
Message ID
<CHZC82RC02GB.30CLYWG0BJAIO@haptop>
In-Reply-To
<20220216174002.30455-3-jason@jasonyundt.email> (view parent)
DKIM signature
pass
Download raw message
On Wed Feb 16, 2022 at 5:40 PM GMT, Jason Yundt wrote:
> This change clarifies that the Radicle Link Contributors have some
> copyright over radicle-link.
>
> Signed-off-by: Jason Yundt <jason@jasonyundt.email>
> ---
> LICENSE | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/LICENSE b/LICENSE
> index 840d3a50..e69a4413 100644
> --- a/LICENSE
> +++ b/LICENSE
> @@ -1,5 +1,7 @@
> -radicle-link is Copyright © 2019-2021
> -The Radicle Foundation <hello@radicle.foundation>
> +radicle-link
> +Copyright © 2019-2021 The Radicle Foundation
> <hello@radicle.foundation>
> +Copyright © 2019-2021 The Radicle Link Contributors
> +<https://github.com/radicle-dev/radicle-link/graphs/contributors>
>  
> radicle-link is licensed under version 3 of the GNU General Public
> License
> (GPLv3) with the Radicle Linking Exception. Any contribution to
> --
> 2.35.1

Should the dates be updated to 2022?

Re: [PATCH radicle-link v3 0/3] Improvements to copyright and licensing info

Details
Message ID
<CHZC8U7188FH.1UPXH3TXESYVH@haptop>
In-Reply-To
<20220216174002.30455-1-jason@jasonyundt.email> (view parent)
DKIM signature
pass
Download raw message
Looks good to me, other than wondering about the update to the year :)

Re: [PATCH radicle-link v3 2/3] Clarify copyright situation

Details
Message ID
<12962904.uLZWGnKmhe@jason-desktop-linux>
In-Reply-To
<CHZC82RC02GB.30CLYWG0BJAIO@haptop> (view parent)
DKIM signature
pass
Download raw message
On Friday, February 18, 2022 12:10:24 PM EST Fintan Halpenny wrote:
> On Wed Feb 16, 2022 at 5:40 PM GMT, Jason Yundt wrote:
> > This change clarifies that the Radicle Link Contributors have some
> > copyright over radicle-link.
> > 
> > Signed-off-by: Jason Yundt <jason@jasonyundt.email>
> > ---
> > LICENSE | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/LICENSE b/LICENSE
> > index 840d3a50..e69a4413 100644
> > --- a/LICENSE
> > +++ b/LICENSE
> > @@ -1,5 +1,7 @@
> > -radicle-link is Copyright © 2019-2021
> > -The Radicle Foundation <hello@radicle.foundation>
> > +radicle-link
> > +Copyright © 2019-2021 The Radicle Foundation
> > <hello@radicle.foundation>
> > +Copyright © 2019-2021 The Radicle Link Contributors
> > +<https://github.com/radicle-dev/radicle-link/graphs/contributors>
> > 
> > radicle-link is licensed under version 3 of the GNU General Public
> > License
> > (GPLv3) with the Radicle Linking Exception. Any contribution to
> > --
> > 2.35.1
> 
> Should the dates be updated to 2022?

At least one of them should be. According to Kim [1],

On Friday, February 4, 2022 3:26:01 AM EST Kim Altintop wrote:
> Thanks for bringing this up. I think, however, that we need to get a detail
> clarified first: since Monadic GmbH is no longer sponsoring radicle-link
> development, maintainers are no longer waiving their copyright automatically
> (and contributors neither). That is, the copyright is held 2019-2021 by the
> Radicle Foundation, but since 2021 by "The Radicle Link Contributors".

[1]: <https://lists.sr.ht/~radicle-link/dev/%3C20220203220246.49585-1-jason%40jasonyundt.email%3E#%3C20220204092601.GD43431@schmidt.localdomain%3E>

[PATCH radicle-link v4 0/3] Improvements to copyright and licensing info

Details
Message ID
<20220218180801.12382-1-jason@jasonyundt.email>
In-Reply-To
<20220203220246.49585-1-jason@jasonyundt.email> (view parent)
DKIM signature
pass
Download raw message
Compared to the previous version of this patch, this version fixes the
Radicle Link Contributors’s copyright date.

Published-As: <https://git.sr.ht/~jayman/radicle-link/refs/patches/license-improvements/v4>

Jason Yundt (3):
  Sync LICENSE file with Radicle Upstream
  Clarify copyright situation
  Remove Radicle Linking Exception

 DCO       | 10 +++-------
 LICENSE   | 39 +++++++++++++--------------------------
 README.md |  2 +-
 3 files changed, 17 insertions(+), 34 deletions(-)

-- 
2.35.1

[PATCH radicle-link v4 1/3] Sync LICENSE file with Radicle Upstream

Details
Message ID
<20220218180801.12382-2-jason@jasonyundt.email>
In-Reply-To
<20220218180801.12382-1-jason@jasonyundt.email> (view parent)
DKIM signature
pass
Download raw message
Patch: +26 -24
Radicle Upstream’s LICENSE file [1] had some improvements that this
repo’s LICENSE file was missing. This change adds those improvements:

- Bump copyright year.
- Fix capitalization of “Developer Certificate of Origin”.
- Correct location of DCO. Before this change, LICENSE incorrectly said
  that the DCO was “below”.
- More consistent word wrapping.

[1]: <https://github.com/radicle-dev/radicle-upstream/blob/main/LICENSE>

Signed-off-by: Jason Yundt <jason@jasonyundt.email>
---
 LICENSE | 50 ++++++++++++++++++++++++++------------------------
 1 file changed, 26 insertions(+), 24 deletions(-)

diff --git a/LICENSE b/LICENSE
index c4744b96..840d3a50 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1,29 +1,31 @@
radicle-link is Copyright © 2019-2020
radicle-link is Copyright © 2019-2021
The Radicle Foundation <hello@radicle.foundation>

radicle-link is licensed under version 3 of the GNU General Public
License (GPLv3) with the Radicle Linking Exception. Any contribution
to radicle-link must be made subject to the developer certificate of
origin (DCO).

By making your contribution, you are (1) making the declaration set
out in the Linux Foundation’s Developer Certificate of Origin
version 1.1 as set out below, in which the “open source licence
indicated in the file” is GPLv3 with the Radicle Linking Exception, and
(2) granting the additional permission referred to in the Radicle
Linking Exception to downstream recipients of current and future
versions of radicle-link released by the Radicle Foundation.

                       Radicle Linking Exception

In addition to the permissions in the GNU General Public License,
the authors give you unlimited permission to link the compiled
version of this unmodified program into combinations with other programs,
and to distribute those combinations without any restriction
coming from the use of this program. (The General Public License
restrictions do apply in other respects; for example, they cover
modification of this program, and distribution when not linked into
a combined executable.)
radicle-link is licensed under version 3 of the GNU General Public License
(GPLv3) with the Radicle Linking Exception. Any contribution to
radicle-link must be made subject to the Developer Certificate of Origin
(DCO).

By making your contribution, you are (1) making the declaration set out in
the Linux Foundation’s Developer Certificate of Origin version 1.1, in
which the “open source licence indicated in the file” is GPLv3 with the
Radicle Linking Exception, and (2) granting the additional permission
referred to in the Radicle Linking Exception to downstream recipients of
current and future versions of radicle-link released by the Radicle
Foundation.

A copy of the Radicle Linking Exception and the GPLv3 can be found below.
A copy of the DCO can be found in the file named “DCO”.

                        Radicle Linking Exception

In addition to the permissions in the GNU General Public License, the
authors give you unlimited permission to link the compiled version of this
unmodified program into combinations with other programs, and to
distribute those combinations without any restriction coming from the use
of this program. (The General Public License restrictions do apply in
other respects; for example, they cover modification of this program, and
distribution when not linked into a combined executable.)

--------------------------------------------------------------------------

-- 
2.35.1

[PATCH radicle-link v4 2/3] Clarify copyright situation

Details
Message ID
<20220218180801.12382-3-jason@jasonyundt.email>
In-Reply-To
<20220218180801.12382-1-jason@jasonyundt.email> (view parent)
DKIM signature
pass
Download raw message
Patch: +4 -2
This change clarifies that the Radicle Link Contributors have some
copyright over radicle-link.

Signed-off-by: Jason Yundt <jason@jasonyundt.email>
---
 LICENSE | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/LICENSE b/LICENSE
index 840d3a50..95da6af6 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1,5 +1,7 @@
radicle-link is Copyright © 2019-2021
The Radicle Foundation <hello@radicle.foundation>
radicle-link
Copyright © 2019-2021 The Radicle Foundation <hello@radicle.foundation>
Copyright © 2021-2022 The Radicle Link Contributors
<https://github.com/radicle-dev/radicle-link/graphs/contributors>

radicle-link is licensed under version 3 of the GNU General Public License
(GPLv3) with the Radicle Linking Exception. Any contribution to
-- 
2.35.1

[PATCH radicle-link v4 3/3] Remove Radicle Linking Exception

Details
Message ID
<20220218180801.12382-4-jason@jasonyundt.email>
In-Reply-To
<20220218180801.12382-1-jason@jasonyundt.email> (view parent)
DKIM signature
pass
Download raw message
Patch: +11 -32
The discussion that resulted in this change can be found here:
<https://lists.sr.ht/~radicle-link/dev/%3C20220203220246.49585-1-jason%40jasonyundt.email%3E>

Signed-off-by: Jason Yundt <jason@jasonyundt.email>
---
 DCO       | 10 +++-------
 LICENSE   | 31 +++++++------------------------
 README.md |  2 +-
 3 files changed, 11 insertions(+), 32 deletions(-)

diff --git a/DCO b/DCO
index 24951788..d53d3ada 100644
--- a/DCO
+++ b/DCO
@@ -1,12 +1,8 @@
                  Developer Certificate of Origin

By making your contribution, you are (1) making the declaration set
out in the Linux Foundation’s Developer Certificate of Origin
version 1.1 as set out below, in which the “open source licence indicated
in the file” is GPLv3 with the Radicle Linking Exception, and (2) granting the
additional permission referred to in the Radicle Linking Exception to
downstream recipients of current and future versions of radicle-upstream
released by the Radicle Foundation.
By making your contribution, you are making the declaration set out in the
Linux Foundation’s Developer Certificate of Origin version 1.1 as set out
below, in which the “open source licence indicated in the file” is GPLv3.

Developer Certificate of Origin
Version 1.1
diff --git a/LICENSE b/LICENSE
index 95da6af6..280210be 100644
--- a/LICENSE
+++ b/LICENSE
@@ -4,30 +4,13 @@ Copyright © 2021-2022 The Radicle Link Contributors
<https://github.com/radicle-dev/radicle-link/graphs/contributors>

radicle-link is licensed under version 3 of the GNU General Public License
(GPLv3) with the Radicle Linking Exception. Any contribution to
radicle-link must be made subject to the Developer Certificate of Origin
(DCO).

By making your contribution, you are (1) making the declaration set out in
the Linux Foundation’s Developer Certificate of Origin version 1.1, in
which the “open source licence indicated in the file” is GPLv3 with the
Radicle Linking Exception, and (2) granting the additional permission
referred to in the Radicle Linking Exception to downstream recipients of
current and future versions of radicle-link released by the Radicle
Foundation.

A copy of the Radicle Linking Exception and the GPLv3 can be found below.
A copy of the DCO can be found in the file named “DCO”.

                        Radicle Linking Exception

In addition to the permissions in the GNU General Public License, the
authors give you unlimited permission to link the compiled version of this
unmodified program into combinations with other programs, and to
distribute those combinations without any restriction coming from the use
of this program. (The General Public License restrictions do apply in
other respects; for example, they cover modification of this program, and
distribution when not linked into a combined executable.)
(GPLv3). Any contribution to radicle-link must be made subject to the
Developer Certificate of Origin (DCO).

By making your contribution, you are making the declaration set out in the
Linux Foundation’s Developer Certificate of Origin version 1.1, in which
the “open source licence indicated in the file” is GPLv3. A copy of the
DCO can be found in the file named “DCO”.

--------------------------------------------------------------------------

diff --git a/README.md b/README.md
index e1dcb173..693fac42 100644
--- a/README.md
+++ b/README.md
@@ -25,7 +25,7 @@ installation is currently required as a runtime dependency.
## License

Unless otherwise noted, all source code in this repository is licensed under the
[GPLv3] with the Radicle Linking Exception. See the [LICENSE] file for details.
[GPLv3]. See the [LICENSE] file for details.

## Contributing

-- 
2.35.1

Re: [PATCH radicle-link v4 1/3] Sync LICENSE file with Radicle Upstream

Details
Message ID
<CI04SOM3SXL6.1J89427KITPMW@haptop>
In-Reply-To
<20220218180801.12382-2-jason@jasonyundt.email> (view parent)
DKIM signature
pass
Download raw message
On Fri Feb 18, 2022 at 6:07 PM GMT, Jason Yundt wrote:
> Radicle Upstream’s LICENSE file [1] had some improvements that this
> repo’s LICENSE file was missing. This change adds those improvements:
>
> - Bump copyright year.
> - Fix capitalization of “Developer Certificate of Origin”.
> - Correct location of DCO. Before this change, LICENSE incorrectly said
> that the DCO was “below”.
> - More consistent word wrapping.
>
> [1]: <https://github.com/radicle-dev/radicle-upstream/blob/main/LICENSE>
>
> Signed-off-by: Jason Yundt <jason@jasonyundt.email>
> ---
> LICENSE | 50 ++++++++++++++++++++++++++------------------------
> 1 file changed, 26 insertions(+), 24 deletions(-)
>
> diff --git a/LICENSE b/LICENSE
> index c4744b96..840d3a50 100644
> --- a/LICENSE
> +++ b/LICENSE
> @@ -1,29 +1,31 @@
> -radicle-link is Copyright © 2019-2020
> +radicle-link is Copyright © 2019-2021

Not be a PITA, but should this be 2022 as well? ^_^

> The Radicle Foundation <hello@radicle.foundation>
>  
> -radicle-link is licensed under version 3 of the GNU General Public
> -License (GPLv3) with the Radicle Linking Exception. Any contribution
> -to radicle-link must be made subject to the developer certificate of
> -origin (DCO).
> -
> -By making your contribution, you are (1) making the declaration set
> -out in the Linux Foundation’s Developer Certificate of Origin
> -version 1.1 as set out below, in which the “open source licence
> -indicated in the file” is GPLv3 with the Radicle Linking Exception,
> and
> -(2) granting the additional permission referred to in the Radicle
> -Linking Exception to downstream recipients of current and future
> -versions of radicle-link released by the Radicle Foundation.
> -
> - Radicle Linking Exception
> -
> -In addition to the permissions in the GNU General Public License,
> -the authors give you unlimited permission to link the compiled
> -version of this unmodified program into combinations with other
> programs,
> -and to distribute those combinations without any restriction
> -coming from the use of this program. (The General Public License
> -restrictions do apply in other respects; for example, they cover
> -modification of this program, and distribution when not linked into
> -a combined executable.)
> +radicle-link is licensed under version 3 of the GNU General Public
> License
> +(GPLv3) with the Radicle Linking Exception. Any contribution to
> +radicle-link must be made subject to the Developer Certificate of
> Origin
> +(DCO).
> +
> +By making your contribution, you are (1) making the declaration set out
> in
> +the Linux Foundation’s Developer Certificate of Origin version 1.1,
> in
> +which the “open source licence indicated in the file” is GPLv3 with
> the
> +Radicle Linking Exception, and (2) granting the additional permission
> +referred to in the Radicle Linking Exception to downstream recipients
> of
> +current and future versions of radicle-link released by the Radicle
> +Foundation.
> +
> +A copy of the Radicle Linking Exception and the GPLv3 can be found
> below.
> +A copy of the DCO can be found in the file named “DCO”.
> +
> + Radicle Linking Exception
> +
> +In addition to the permissions in the GNU General Public License, the
> +authors give you unlimited permission to link the compiled version of
> this
> +unmodified program into combinations with other programs, and to
> +distribute those combinations without any restriction coming from the
> use
> +of this program. (The General Public License restrictions do apply in
> +other respects; for example, they cover modification of this program,
> and
> +distribution when not linked into a combined executable.)
>  
> --------------------------------------------------------------------------
>  
> --
> 2.35.1

Re: [PATCH radicle-link v4 1/3] Sync LICENSE file with Radicle Upstream

Details
Message ID
<21370164.EfDdHjke4D@jason-desktop-linux>
In-Reply-To
<CI04SOM3SXL6.1J89427KITPMW@haptop> (view parent)
DKIM signature
pass
Download raw message
On Saturday, February 19, 2022 10:33:50 AM EST Fintan Halpenny wrote:
> On Fri Feb 18, 2022 at 6:07 PM GMT, Jason Yundt wrote:
> > Radicle Upstream’s LICENSE file [1] had some improvements that this
> > repo’s LICENSE file was missing. This change adds those improvements:
> > 
> > - Bump copyright year.
> > - Fix capitalization of “Developer Certificate of Origin”.
> > - Correct location of DCO. Before this change, LICENSE incorrectly said
> > that the DCO was “below”.
> > - More consistent word wrapping.
> > 
> > [1]: <https://github.com/radicle-dev/radicle-upstream/blob/main/LICENSE>
> > 
> > Signed-off-by: Jason Yundt <jason@jasonyundt.email>
> > ---
> > LICENSE | 50 ++++++++++++++++++++++++++------------------------
> > 1 file changed, 26 insertions(+), 24 deletions(-)
> > 
> > diff --git a/LICENSE b/LICENSE
> > index c4744b96..840d3a50 100644
> > --- a/LICENSE
> > +++ b/LICENSE
> > @@ -1,29 +1,31 @@
> > -radicle-link is Copyright © 2019-2020
> > +radicle-link is Copyright © 2019-2021
> 
> Not be a PITA, but should this be 2022 as well? ^_^

I don’t think so. That commit makes LICENSE read

> radicle-link is Copyright © 2019-2021
> The Radicle Foundation <hello@radicle.foundation>

which is an accurate statement, even if radicle-link is also copyright 2021–
2022 the Radicle Link Contributors. In the first version of the patch [1],
that commit did make it say

> radicle-link is Copyright © 2019-2022
> The Radicle Foundation <hello@radicle.foundation>

but Kim out that that statement was incorrect [2].

Also, don’t worry about being a PITA. You’re doing exactly what I’ve been 
doing: finding little issues and helping people fix them.

[1]: <https://lists.sr.ht/~radicle-link/dev/%3C20220203220246.49585-1-jason%40jasonyundt.email%3E#%3C20220203220246.49585-1-jason@jasonyundt.email%3E>
[2]: <https://lists.sr.ht/~radicle-link/dev/%3C20220203220246.49585-1-jason%40jasonyundt.email%3E#%3C20220204092601.GD43431@schmidt.localdomain%3E>

Re: [PATCH radicle-link v4 1/3] Sync LICENSE file with Radicle Upstream

Details
Message ID
<CI1MCXHIM5OX.20M89SDPIIW6K@haptop>
In-Reply-To
<21370164.EfDdHjke4D@jason-desktop-linux> (view parent)
DKIM signature
pass
Download raw message
On Sat Feb 19, 2022 at 5:49 PM GMT, Jason Yundt wrote:
> On Saturday, February 19, 2022 10:33:50 AM EST Fintan Halpenny wrote:
> > On Fri Feb 18, 2022 at 6:07 PM GMT, Jason Yundt wrote:
> > > Radicle Upstream’s LICENSE file [1] had some improvements that this
> > > repo’s LICENSE file was missing. This change adds those improvements:
> > > 
> > > - Bump copyright year.
> > > - Fix capitalization of “Developer Certificate of Origin”.
> > > - Correct location of DCO. Before this change, LICENSE incorrectly said
> > > that the DCO was “below”.
> > > - More consistent word wrapping.
> > > 
> > > [1]: <https://github.com/radicle-dev/radicle-upstream/blob/main/LICENSE>
> > > 
> > > Signed-off-by: Jason Yundt <jason@jasonyundt.email>
> > > ---
> > > LICENSE | 50 ++++++++++++++++++++++++++------------------------
> > > 1 file changed, 26 insertions(+), 24 deletions(-)
> > > 
> > > diff --git a/LICENSE b/LICENSE
> > > index c4744b96..840d3a50 100644
> > > --- a/LICENSE
> > > +++ b/LICENSE
> > > @@ -1,29 +1,31 @@
> > > -radicle-link is Copyright © 2019-2020
> > > +radicle-link is Copyright © 2019-2021
> > 
> > Not be a PITA, but should this be 2022 as well? ^_^
>
> I don’t think so. That commit makes LICENSE read
>
> > radicle-link is Copyright © 2019-2021
> > The Radicle Foundation <hello@radicle.foundation>
>
> which is an accurate statement, even if radicle-link is also copyright
> 2021–
> 2022 the Radicle Link Contributors. In the first version of the patch
> [1],
> that commit did make it say

Ah thanks! I missed that context when reviewing :)

>
> > radicle-link is Copyright © 2019-2022
> > The Radicle Foundation <hello@radicle.foundation>
>
> but Kim out that that statement was incorrect [2].
>
> Also, don’t worry about being a PITA. You’re doing exactly what
> I’ve been
> doing: finding little issues and helping people fix them.

True! Appreciate the help in tracking down these little issues ^_^

>
> [1]:
> <https://lists.sr.ht/~radicle-link/dev/%3C20220203220246.49585-1-jason%40jasonyundt.email%3E#%3C20220203220246.49585-1-jason@jasonyundt.email%3E>
> [2]:
> <https://lists.sr.ht/~radicle-link/dev/%3C20220203220246.49585-1-jason%40jasonyundt.email%3E#%3C20220204092601.GD43431@schmidt.localdomain%3E>

Re: [PATCH radicle-link v4 0/3] Improvements to copyright and licensing info

Details
Message ID
<CI1MDUVDEVFD.3C2HPE9P0AOQ5@haptop>
In-Reply-To
<20220218180801.12382-1-jason@jasonyundt.email> (view parent)
DKIM signature
pass
Download raw message
LGTM!

Re: [PATCH radicle-link v4 0/3] Improvements to copyright and licensing info

Details
Message ID
<CAH_DpYSEN0+1fhfGh6qTVOSh5tskE1AgUy-O+ih0M9C1Ff9iWw@mail.gmail.com>
In-Reply-To
<20220218180801.12382-1-jason@jasonyundt.email> (view parent)
DKIM signature
missing
Download raw message
Merged to master

Master-At: 7a3131bbc170537b24e1ece60d2133c75f470450
Reply to thread Export thread (mbox)