Authentication-Results: mail-b.sr.ht; dkim=pass header.d=gmail.com header.i=@gmail.com Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mail-b.sr.ht (Postfix) with ESMTPS id C0C2211EF24 for <~radicle-link/dev@lists.sr.ht>; Tue, 16 Aug 2022 13:54:27 +0000 (UTC) Received: by mail-pf1-f178.google.com with SMTP id 130so9142445pfy.6 for <~radicle-link/dev@lists.sr.ht>; Tue, 16 Aug 2022 06:54:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=JkrRORA1+Q4tb+TJFO4uEfBv9Gh6pHsG9GqcshMIQKc=; b=UZP6lQ4qZHQRsPdfvHJ2rEFroeqs4fOhLPSExBko9sNxHLYUyXFgoEDbCuFKIgtMSY pditREnQ4mD+ERwhNvSw3m12j+1vbC0HYo1c/b7QLj3GFBLx6TVNU/2WIyM4OzE/dIAM YQJ5lIJGvOpyMZkqXG0FsTGVCUcs5CR7G71r4+k42r4UOSnuCVkl3zLlDlUmeuSalepB b5JWKgVSgqtXkSsVu8YlgdqUdV8JaYxDJo9Dw8C2kMjX8SM0DFdz55P4Dm68g+YWlSQj hICLitRSJZTHP3YyuLq5fFSXxwE1DHZRDhJrhGl0el01MxFHtcxAUoSufmcTaTFOPI81 xVRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=JkrRORA1+Q4tb+TJFO4uEfBv9Gh6pHsG9GqcshMIQKc=; b=Y1b3ywEWCaa2kgY9fmYVINQft9P1vs6ASdlEDcICouClhXzoaUt12DJLwvmHKckRzU tnkVap0vh9xnys6fsjUHzTZRHTRKc7RbLM5kT+ihtinLA5H7V43pxxGTkktfkilFde2M 9GUu76hC5/Kx/yZbcmGCznNCW2fg+K9oY1bkDphSAlM6eiXOuFvy10ziH0m9CoHw1Rai zdr7waYvdf3cmMizd/qU0mgXoQ2LWn/uo2RFLj9XpCA/hwmr8VLjfcS/9FNZsBWiz+au kwlAOMpnTBYfcUHwkuJkMGnfLa1MhmBrgczetjsdA/RekWdShRWrbM1KyBwdmI7EBNYB pyBg== X-Gm-Message-State: ACgBeo2qqxCK8SDc4qysEjJdJFYNfBnqcX4Vo4q0Gxvt7H0OeOHu4ocB M635nvdMePjhHu9bZpvpEBErEmdf1Tg= X-Google-Smtp-Source: AA6agR70JQHam/D28Y4ZGeDmCneAScjSYjiWVpxxJoTJ+smy6Bz4iOZFUuboRtovAsOpecB/H3O4hw== X-Received: by 2002:a63:68c2:0:b0:421:9e8f:35c4 with SMTP id d185-20020a6368c2000000b004219e8f35c4mr17834743pgc.363.1660658066456; Tue, 16 Aug 2022 06:54:26 -0700 (PDT) Received: from localhost.localdomain (c-98-207-161-235.hsd1.ca.comcast.net. [98.207.161.235]) by smtp.gmail.com with ESMTPSA id f4-20020a170902684400b0016a7b9558f7sm9058256pln.136.2022.08.16.06.54.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Aug 2022 06:54:26 -0700 (PDT) From: Han Xu To: ~radicle-link/dev@lists.sr.ht Cc: Han Xu Subject: [PATCH radicle-link v2 1/2] unlink unix socket before bind Date: Tue, 16 Aug 2022 06:54:05 -0700 Message-Id: <20220816135406.62129-2-keepsimple@gmail.com> X-Mailer: git-send-email 2.32.0 (Apple Git-132) In-Reply-To: <20220816135406.62129-1-keepsimple@gmail.com> References: <20220812033750.4409-1-keepsimple@gmail.com> <20220816135406.62129-1-keepsimple@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit --- cli/linkd-lib/src/api/sockets.rs | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/cli/linkd-lib/src/api/sockets.rs b/cli/linkd-lib/src/api/sockets.rs index 050c1dd0..6ea13315 100644 --- a/cli/linkd-lib/src/api/sockets.rs +++ b/cli/linkd-lib/src/api/sockets.rs @@ -132,8 +132,19 @@ fn env_sockets() -> Result { fn profile_sockets(profile: &Profile, peer_id: &PeerId) -> Result { let rpc_socket_path = profile.paths().rpc_socket(peer_id); let events_socket_path = profile.paths().events_socket(peer_id); - let rpc = StdUnixListener::bind(rpc_socket_path.as_path())?; - let events = StdUnixListener::bind(events_socket_path.as_path())?; + + // UNIX socket needs to be unlinked if already exists. + nix::unistd::unlink(&rpc_socket_path).ok(); + let rpc = StdUnixListener::bind(rpc_socket_path.as_path()).map_err(|e| { + tracing::error!("bind rpc_socket_path: {:?} error: {}", &rpc_socket_path, &e); + e + })?; + nix::unistd::unlink(&events_socket_path).ok(); + let events = StdUnixListener::bind(events_socket_path.as_path()).map_err(|e| { + tracing::error!("bind events_socket_path: {:?} error: {}", &events_socket_path, &e); + e + })?; + Ok(SyncSockets { rpc, events, -- 2.32.0 (Apple Git-132)