~raphi/public-inbox

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
5 3

[PATCH somebar] fix version

Ben Collerson <benc@benc.cc>
Details
Message ID
<20230602072644.353315-1-benc@benc.cc>
DKIM signature
missing
Download raw message
Patch: +1 -1
---
 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index 6ad5a0f..5b6a244 100644
--- a/meson.build
+++ b/meson.build
@@ -1,5 +1,5 @@
project('somebar', ['c', 'cpp'],
	version: '0.1.0',
	version: run_command('git', 'describe', '--tags').stdout().strip(),
	default_options: [
	    'cpp_std=c++17',
	    'cpp_args=-Wno-parentheses',
-- 
2.40.1

[somebar/patches] build failed

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CT1ZJMFON9WQ.20TJBKKAKF64W@cirno2>
In-Reply-To
<20230602072644.353315-1-benc@benc.cc> (view parent)
DKIM signature
missing
Download raw message
somebar/patches: FAILED in 54s

[fix version][0] from [Ben Collerson][1]

[0]: https://lists.sr.ht/~raphi/public-inbox/patches/41579
[1]: benc@benc.cc

✗ #1000058 FAILED somebar/patches/archlinux.yml https://builds.sr.ht/~raphi/job/1000058
✗ #1000059 FAILED somebar/patches/freebsd.yml   https://builds.sr.ht/~raphi/job/1000059
Details
Message ID
<2fa85412-4316-47d7-a00b-8492a17a56d6@app.fastmail.com>
In-Reply-To
<20230602072644.353315-1-benc@benc.cc> (view parent)
DKIM signature
missing
Download raw message
I'll fix the version manually. I don't want this to happen automatically with `git describe` because then downstream distributions would have to patch that invocation out (e.g. https://github.com/NixOS/nixpkgs/blob/5717cbc076d996e6c07b16706073f09e021d0b99/pkgs/applications/window-managers/yabar/build.nix#L45-L47)

Raphael
Ben Collerson <benc@benc.cc>
Details
Message ID
<23b88613-b81e-444a-b60d-8812d0df2f21@app.fastmail.com>
In-Reply-To
<2fa85412-4316-47d7-a00b-8492a17a56d6@app.fastmail.com> (view parent)
DKIM signature
missing
Download raw message
No worries. Sounds good.

On Fri, 2 Jun 2023, at 17:52, Raphael Robatsch wrote:
> I'll fix the version manually. I don't want this to happen 
> automatically with `git describe` because then downstream distributions 
> would have to patch that invocation out (e.g. 
> https://github.com/NixOS/nixpkgs/blob/5717cbc076d996e6c07b16706073f09e021d0b99/pkgs/applications/window-managers/yabar/build.nix#L45-L47)
>
> Raphael
Ben Collerson <benc@benc.cc>
Details
Message ID
<6a9a7f51-a8c7-4756-977c-6daceda3bf7d@app.fastmail.com>
In-Reply-To
<23b88613-b81e-444a-b60d-8812d0df2f21@app.fastmail.com> (view parent)
DKIM signature
missing
Download raw message
I might send this through as a contrib patch then?

On Fri, 2 Jun 2023, at 18:10, Ben Collerson wrote:
> No worries. Sounds good.
>
> On Fri, 2 Jun 2023, at 17:52, Raphael Robatsch wrote:
>> I'll fix the version manually. I don't want this to happen 
>> automatically with `git describe` because then downstream distributions 
>> would have to patch that invocation out (e.g. 
>> https://github.com/NixOS/nixpkgs/blob/5717cbc076d996e6c07b16706073f09e021d0b99/pkgs/applications/window-managers/yabar/build.nix#L45-L47)
>>
>> Raphael
Details
Message ID
<0ef13444-b946-4e67-8445-07d4454eccf9@app.fastmail.com>
In-Reply-To
<6a9a7f51-a8c7-4756-977c-6daceda3bf7d@app.fastmail.com> (view parent)
DKIM signature
missing
Download raw message
Sure

Raphael
Reply to thread Export thread (mbox)