Fix possible OOB access for clicking tags v1 APPLIED

mortezadadgar: 1
 Fix possible OOB access for clicking tags

 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH] Fix possible OOB access for clicking tags Export this patch

specify the signed type for indexing tags as intended
for `tag >= 0` check.

Signed-off-by: mortezadadgar <mortezadadgar97@gmail.com>
---
 src/bar.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bar.cpp b/src/bar.cpp
index 4fda8b0..18a0b63 100644
--- a/src/bar.cpp
+++ b/src/bar.cpp
@@ -181,7 +181,7 @@ void Bar::click(Monitor* mon, int x, int, int btn)
 		control = ClkWinTitle;
 	} else if (x > _layoutCmp.x) {
 		control = ClkLayoutSymbol;
-	} else for (auto tag = _tags.size()-1; tag >= 0; tag--) {
+	} else for (int tag = _tags.size()-1; tag >= 0; tag--) {
 		if (x > _tags[tag].component.x) {
 			control = ClkTagBar;
 			arg.ui = 1<<tag;
-- 
2.41.0

Raphael Robatsch <raphael@tapesoftware.net>

1 year, 6 months ago

Good catch, thanks.

To git.sr.ht:~raphi/somebar
   b069830..e1f8c63  master -> master