~redstrate/public-inbox

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[PATCH astra 0/1] Fixing connection to a Sapphire Server

Details
Message ID
<167372727006.25347.12957442346607503432-0@git.sr.ht>
DKIM signature
missing
Download raw message
Currently when trying to connect to a sapphire server a connection to
the server is never able to made because the scheme is already in the
URL, and the GUI expects that the protocol is included in the settings
tab. This patch fixes it.

Toofy (1):
  Adding fix for connecting to a sapphire server

 launcher/core/src/sapphirelauncher.cpp | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

-- 
2.34.5

[PATCH astra 1/1] Adding fix for connecting to a sapphire server

Details
Message ID
<167372727006.25347.12957442346607503432-1@git.sr.ht>
In-Reply-To
<167372727006.25347.12957442346607503432-0@git.sr.ht> (view parent)
DKIM signature
missing
Download raw message
Patch: +2 -5
From: Toofy <mostafa.alsari@gmail.com>

---
 launcher/core/src/sapphirelauncher.cpp | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/launcher/core/src/sapphirelauncher.cpp b/launcher/core/src/sapphirelauncher.cpp
index f6ed125..1c7a3d2 100644
--- a/launcher/core/src/sapphirelauncher.cpp
+++ b/launcher/core/src/sapphirelauncher.cpp
@@ -39,10 +39,7 @@ void SapphireLauncher::login(const QString& lobbyUrl, const LoginInformation& in

void SapphireLauncher::registerAccount(const QString& lobbyUrl, const LoginInformation& info) {
    QJsonObject data{{"username", info.username}, {"pass", info.password}};
    QUrl url;
    url.setScheme("http");
    url.setHost(lobbyUrl);
    url.setPath("/sapphire-api/lobby/createAccount");
    QUrl url(lobbyUrl + "/sapphire-api/lobby/login");

    QNetworkRequest request(url);
    request.setHeader(QNetworkRequest::ContentTypeHeader, "application/x-www-form-urlencoded");
@@ -59,4 +56,4 @@ void SapphireLauncher::registerAccount(const QString& lobbyUrl, const LoginInfor

        window.launchGame(*info.settings, auth);
    });
}
\ No newline at end of file
}
-- 
2.34.5

Re: [PATCH astra 1/1] Adding fix for connecting to a sapphire server

Details
Message ID
<12328810.O9o76ZdvQC@adrastea>
In-Reply-To
<167372727006.25347.12957442346607503432-1@git.sr.ht> (view parent)
DKIM signature
missing
Download raw message
Thank you for your patch! It's been a while since I was able to test Sapphire 
myself. Applied to main.
Reply to thread Export thread (mbox)