MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Wed, 21 Apr 2021 19:27:50 +0000
Message-Id: <CATNE8IV9M9K.1MKBCYDW7D485@Kristofers-MacBook-Pro.local>
Cc: 
Subject: Re: Possible bug in nova-phpcs
From: =?utf-8?q?Krist=C3=B3fer_Reykjal=C3=ADn?= <kristofer@thorlaksson.com>
To: "Guilherme Cartaxo" <guilherme@weareboq.com>,
 <~reykjalin/public-inbox@lists.sr.ht>
References: <949DA8B7-8F82-47D2-BE1B-A58813656659@weareboq.com>
In-Reply-To: <949DA8B7-8F82-47D2-BE1B-A58813656659@weareboq.com>

Hi Guilherme,

> After the last update, nova-phpcs started automatic fixing code on
> every save.
>
> Today I finally decided to investigate and found that config.js seems
> to be loading phpcbf instead of phpcs in lines 16 and 20.

Thank you so much for reporting this! I don't know how I haven't seen
this since I've been using the extension like this since the last
release :O .

I'm so sorry about the issue! I hope it didn't cause any issues in your
workflows.

For now, you can quickly monkey patch this yourself by manually
modifying config.js in
"~/Library/Application Support/Nova/Extensions/com.thorlaksson.phpcs/Script=
s/config.js"
(at least I think that's the right path).

Unfortunately I don't have the time at the moment to release a fix, but
you can expect a release with an update this coming Monday (April 26).

Thank you again for reporting this! I'll be in touch again once I've
fixed the issue, just to make sure everything works as intended :) .


Best regards,
Krist=C3=B3fer R.