From: Guilherme Cartaxo <guilherme@weareboq.com>
To: =?utf-8?b?S3Jpc3TDs2ZlciBSZXlramFsw61u?= <kristofer@thorlaksson.com>
Cc: ~reykjalin/public-inbox@lists.sr.ht
Subject: Re: Possible bug in nova-phpcs
Date: Thu, 22 Apr 2021 13:04:09 +0100
Message-ID: <E6EBB8EF-F829-40D0-8498-B40C5720ADDB@weareboq.com>
In-Reply-To: <CATNE8IV9M9K.1MKBCYDW7D485@Kristofers-MacBook-Pro.local>
References: <949DA8B7-8F82-47D2-BE1B-A58813656659@weareboq.com>
 <CATNE8IV9M9K.1MKBCYDW7D485@Kristofers-MacBook-Pro.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed; markup=markdown
Content-Transfer-Encoding: 8bit

Hi Kristófer,

No worries! I thought it was some misconfiguration on my side, but it 
didn’t really affect our workflow.

I did the fixes you mentioned and it’s working as expected again.

Thank you for the plugin.

Guilherme

On 21 Apr 2021, at 20:27, Kristófer Reykjalín wrote:

> Hi Guilherme,
>
>> After the last update, nova-phpcs started automatic fixing code on
>> every save.
>>
>> Today I finally decided to investigate and found that config.js seems
>> to be loading phpcbf instead of phpcs in lines 16 and 20.
>
> Thank you so much for reporting this! I don't know how I haven't seen
> this since I've been using the extension like this since the last
> release :O .
>
> I'm so sorry about the issue! I hope it didn't cause any issues in 
> your
> workflows.
>
> For now, you can quickly monkey patch this yourself by manually
> modifying config.js in
> "~/Library/Application 
> Support/Nova/Extensions/com.thorlaksson.phpcs/Scripts/config.js"
> (at least I think that's the right path).
>
> Unfortunately I don't have the time at the moment to release a fix, 
> but
> you can expect a release with an update this coming Monday (April 26).
>
> Thank you again for reporting this! I'll be in touch again once I've
> fixed the issue, just to make sure everything works as intended :) .
>
>
> Best regards,
> Kristófer R.