~rjarry

Paris, France

~rjarry/aerc-devel

Last active 2 days ago

~rjarry/aerc-announce

Last active 22 days ago
View more

Recent activity

Re: [PATCH v3] style: customize vertical and horizontal border characters 2 days ago

From Robin Jarry to ~rjarry/aerc-devel

Dian M Fay, Nov 29, 2021 at 23:48:
> New border-char-horizontal and border-char-vertical config settings in
> aerc.conf allow users to modify border appearance from the default
> 1-wide/tall blank space. In stylesets, border.fg now affects the
> foreground color when custom characters are defined.
> ---
> > I wonder if we could manually parse the setting and force it to a rune
> > type in the UIConfig object. It would make it easier to use in the
> > remaining code.
> I did notice https://gowalker.org/gopkg.in/ini.v1#MapToWithMapper while
> trying to find something better than the current implementation, but
> that appears only to handle keys (e.g. casing style variations) and
> won't help changing value types. There's also a recent issue regarding
> uint8 parsing: https://github.com/go-ini/ini/issues/302

Re: [PATCH v2 2/2] doc: fix typo in stylesets-dirs 3 days ago

From Robin Jarry to ~rjarry/aerc-devel

Applied on master.

Thanks!

Re: [PATCH v2 1/2] style: customize vertical and horizontal border characters 3 days ago

From Robin Jarry to ~rjarry/aerc-devel

Dian M Fay, Nov 29, 2021 at 04:47:
> New border-char-horizontal and border-char-vertical config settings in
> aerc.conf allow users to modify border appearance from the default
> 1-wide/tall blank space. In stylesets, border.fg now affects the
> foreground color when custom characters are defined.
> ---
> Unfortunately go-ini doesn't seem to be capable of deserializing a rune
> directly or this'd be noticeably shorter :(

I wonder if we could manually parse the setting and force it to a rune
type in the UIConfig object. It would make it easier to use in the
remaining code.

> diff --git a/config/config.go b/config/config.go

[PATCH hub.sr.ht] webhooks/git: use markdown for tracker comments 3 days ago

From Robin Jarry to ~sircmpwn/sr.ht-dev

The raw body of comments is included in email notifications. HTML makes
ugly plain text messages.

Use markdown for generated tracker comments which can be used in plain
text emails as-is.

Fixes: https://todo.sr.ht/~sircmpwn/hub.sr.ht/77
Fixes: be5d50d8d893 ("webhooks: update todo tickets with git commits")
Signed-off-by: Robin Jarry <robin@jarry.cc>
---
 hubsrht/blueprints/webhooks.py | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/hubsrht/blueprints/webhooks.py b/hubsrht/blueprints/webhooks.py
[message trimmed]

[PATCH sr.ht-docs] Fix broken relative links 3 days ago

From Robin Jarry to ~sircmpwn/sr.ht-dev

For some obscure reason yet to be identified, *some* (not all) relative
links that use "../" to reference parent items in the repository point
to invalid URLs. This may be an issue with the rendering process from
markdown to html.

Replace relative links with absolute ones.

Signed-off-by: Robin Jarry <robin@jarry.cc>
---
 git.sr.ht/index.md     | 8 ++++----
 lists.sr.ht/api.md     | 2 +-
 lists.sr.ht/index.md   | 4 ++--
 meta.sr.ht/user-api.md | 4 ++--
 todo.sr.ht/api.md      | 4 ++--
[message trimmed]

Re: [PATCH] style: customize vertical and horizontal border-chars 4 days ago

From Robin Jarry to ~rjarry/aerc-devel

Hi,

Dian M Fay, Nov 28, 2021 at 17:49:
> ---
>  config/aerc.conf.in      | 5 +++++
>  config/config.go         | 8 ++++++++
>  doc/aerc-config.5.scd    | 7 ++++++-
>  doc/aerc-stylesets.7.scd | 2 +-
>  lib/ui/borders.go        | 4 +++-
>  widgets/compose.go       | 3 ++-
>  widgets/msgviewer.go     | 5 +++--
>  7 files changed, 28 insertions(+), 6 deletions(-)

Could you write a short description of what your commit does and why it

[PATCH sr.ht-docs v3] git.sr.ht: add section about referencing todo tickets 4 days ago

From Robin Jarry to ~sircmpwn/sr.ht-dev

It is now possible to reference tracker tickets in git commit messages.
Describe how it works.

Signed-off-by: Robin Jarry <robin@jarry.cc>
---
v2 -> v3:
    Tested rendering: https://man.sr.ht/~rjarry/sr.ht-docs/git.sr.ht/
    Adjusted ticket comment following the changes in hub.sr.ht v3 patch.

 git.sr.ht/index.md | 87 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 87 insertions(+)

diff --git a/git.sr.ht/index.md b/git.sr.ht/index.md
index 3ca034ba320a..ec281e47770e 100644
[message trimmed]

[PATCH hub.sr.ht v3 2/2] webhooks: update todo tickets with git commits 4 days ago

From Robin Jarry to ~sircmpwn/sr.ht-dev

Allow referencing tracker tickets in git commit messages via specific
trailer words:

  Fixes: <ticket url>
  Implements: <ticket url>
  References: <ticket url>

These must follow standard git trailer syntax. The trailers are
extracted from commit messages with the function added in previous
commit. The ticket url must point to a valid ticket.

A comment will be inserted in the ticket with a back reference to the
git commit and its original author. The comment will be made by the user
who pushed the commit. E.g.:
[message trimmed]

[PATCH hub.sr.ht v3 1/2] git: add function to parse message trailers 4 days ago

From Robin Jarry to ~sircmpwn/sr.ht-dev

This is a pure python implementation of the message trailer parsing
algorithm in git (and libgit2). It is intended for use on finalized
commit messages only. Lines starting with comments are not ignored.

The function returns a list of pairs (name, value) where name is the
name of the trailer. Trailer values may span over multiple lines.

Link: https://git-scm.com/docs/git-interpret-trailers
Link: https://github.com/git/git/blob/master/trailer.c
Link: https://github.com/libgit2/libgit2/blob/main/src/trailer.c
Signed-off-by: Robin Jarry <robin@jarry.cc>
---
v2 -> v3:
    * Added a separate function to extract trailers from commit
[message trimmed]

Re: [PATCH] style: customize vertical and horizontal border-chars 4 days ago

From Robin Jarry to ~rjarry/aerc-devel

Hi Dian,

Please do not send patches as email attachments. They should be inline. You can use the `git send-email` command which will take care of it for you.

Here are some guides for reference:

https://git-send-email.io/
https://doc.dpdk.org/guides/contributing/patches.html#sending-patches

Thanks!