Paris, France
From Robin Jarry to ~rjarry/dlrepo
Julien Floret, May 25, 2022 at 14:54: > While attempting to connect to the ldap server, catch > bonsai.ConnectionError to avoid getting this kind of backtrace: > > dlrepo[603976]: Error handling request > Traceback (most recent call last): > File "/usr/lib/python3/dist-packages/aiohttp/web_protocol.py", line 435, in _handle_request > resp = await request_handler(request) > File "/usr/lib/python3/dist-packages/aiohttp/web_app.py", line 504, in _handle > resp = await handler(request) > File "/usr/lib/python3/dist-packages/aiohttp/web_middlewares.py", line 117, in impl > return await handler(request) > File "/usr/lib/python3/dist-packages/dlrepo/views/auth.py", line 31, in middleware > await backend.check(request)
From Robin Jarry to ~rjarry/aerc-devel
Koni Marti, May 25, 2022 at 11:16: > Commit 1bac87e80414 ("terminal: fix race when closing a terminal") fixed > a race in Terminal.Draw by using a mutex. The current locking of the > entire Draw function could create a deadlock, however, since this > function itself might call Terminal.Close which is protected by the same > mutex. A finer-grained locking solves both the race and deadlock > problem. > > Signed-off-by: Koni Marti <koni.marti@gmail.com> > --- > v2: unlock mutex on return if term.cmd=nil Acked-by: Robin Jarry <robin@jarry.cc>
From Robin Jarry to ~rjarry/aerc-devel
Tim Culverhouse, May 25, 2022 at 21:24: > Aerc was sending empty address list header fields (specifically CC by > default). This was causing DKIM failures in lists.sr.ht. RFC 5322 states > that an address field should consist of the field name and one or more > addresses, implying empty fields are not allowed. > > Signed-off-by: Tim Culverhouse <tim@timculverhouse.com> Acked-by: Robin Jarry <robin@jarry.cc> Applied on master. Nice find!
From Robin Jarry to ~rjarry/aerc-devel
Koni Marti, May 25, 2022 at 11:00: > Yes. That's correct. I can unlock the mutex before the return. > > I introduced this check because it was necessary to prevent the panic in > pty.StartWithAttr after implementing the fine-grained locking, even > though the first check is just a few lines above. Apparently, it happens > that the terminal is closed between the check and while we are still in > StartwithAttr. > > Would you accept a v2 with the following changes which should avoid the > panic and be correct with the locking/unlocking: > > term.closeMutex.Lock() > if term.cmd == nil {
From Robin Jarry to ~rjarry/aerc-devel
Koni Marti, May 24, 2022 at 19:07: > Commit 1bac87e80414 ("terminal: fix race when closing a terminal") fixed > a race in Terminal.Draw by using a mutex. The current locking of the > entire Draw function could create a deadlock, however, since this > function itself might call Terminal.Close which is protected by the same > mutex. A finer-grained locking solves both the race and deadlock > problem. > > Signed-off-by: Koni Marti <koni.marti@gmail.com> Hey Koni, > --- > widgets/terminal.go | 10 +++++++---
From Robin Jarry to ~rjarry/aerc-devel
Tim Culverhouse, May 24, 2022 at 22:12: > Refactor lib/crypto/gpg tests to facilitate unit test runs on macos. > Macos creates temporary directories with names too long to call > gpg-agent (108 characters). Additionally, too many concurrent test calls > created IPC errors to gpg-agent. To get around this, tests were given > shorter names and refactored into subtests to create fewer concurrent > tests > > Tested on Linux and MacOS. > > Signed-off-by: Tim Culverhouse <tim@timculverhouse.com> Acked-by: Robin Jarry <robin@jarry.cc>
From Robin Jarry to ~rjarry/aerc-devel
Koni Marti, May 23, 2022 at 22:32: > Fix race when closing a terminal. The race appears as a nil pointer > dereference panic in pty.StartWithAttrs when trying to access the > provided term.cmd variable. > > Before calling pty.StartwithAttrs in the Terminal.Draw function, > term.cmd is checked for nil. Terminal.Close must be called concurrently > right after this check and before/while entering pty.StartWithAttrs. > This can be avoid with a mutex. > > Link: https://github.com/creack/pty/issues/146 > Link: https://lists.sr.ht/~rjarry/aerc-devel/%3CCJ2I45HMOTGD.2J1QMEJ4T1E3N%40t450.arielp.com%3E#%3CCJ3D069RCTXL.3VEZ7JIGFHOHK@Archetype%3E > Fixes: https://todo.sr.ht/~rjarry/aerc/38 > Signed-off-by: Koni Marti <koni.marti@gmail.com>
From Robin Jarry to ~rjarry/aerc-devel
Koni Marti, May 23, 2022 at 22:16: > Fix race when closing a terminal. The race appears as a nil pointer > dereference panic in pty.StartWithAttrs when trying to access the > provided term.cmd variable. > > Before calling pty.StartwithAttrs in the Terminal.Draw function, > term.cmd is checked for nil. Terminal.Close must be called concurrently > right after this check and before/while entering pty.StartWithAttrs. > This can be avoided with a mutex. > > Link: https://github.com/creack/pty/issues/146 > Link: https://lists.sr.ht/~rjarry/aerc-devel/%3CCJ2I45HMOTGD.2J1QMEJ4T1E3N%40t450.arielp.com%3E#%3CCJ3D069RCTXL.3VEZ7JIGFHOHK@Archetype%3E > Fixes: https://todo.sr.ht/~rjarry/aerc/38 > Signed-off-by: Koni Marti <koni.marti@gmail.com>
From Robin Jarry to ~rjarry/aerc-devel
Tim Culverhouse, May 20, 2022 at 01:44: > Add :help completion arguments (config, imap, etc). The option "aerc" > brings up the general manpage > > Signed-off-by: Tim Culverhouse <tim@timculverhouse.com> Applied on master. Thanks!
From Robin Jarry to ~rjarry/aerc-devel
Koni Marti, May 21, 2022 at 10:14: > Provide a generic selector dialog popup where the user can select from > different options. > > Signed-off-by: Koni Marti <koni.marti@gmail.com> Hi Koni, reusable widgets are good :) > --- > widgets/aerc.go | 6 +++-- > widgets/selector.go | 65 +++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 69 insertions(+), 2 deletions(-) > > diff --git a/widgets/aerc.go b/widgets/aerc.go