Paris, France
From Robin Jarry to ~rjarry/aerc-devel
Tim Culverhouse, Sep 07, 2023 at 18:50: > Add a UI config value to enable showing of an "entire thread", similar > to `notmuch show --entire-thread=true`. Add an associated style called > "msglist_borrowed" which can be used to style such messages. > > Currently this feature is only supported by notmuch. It would be > possible for maildir to implement as well, IMAP with gmail custom > extensions, and JMAP. This patch merely implements the notmuch version > and puts the groundwork in for handling these sorts of displays. > > Signed-off-by: Tim Culverhouse <tim@timculverhouse.com> Hey Tim,
From Robin Jarry to ~rjarry/aerc-devel
Bence Ferdinandy, Sep 19, 2023 at 22:04: > > On Tue Sep 19, 2023 at 01:07, Robin Jarry wrote: > > This style object was not documented. Make it so. > > > > Fixes: 995dfc15a806 ("styles: add style for folded threads") > > Signed-off-by: Robin Jarry <robin@jarry.cc> > > --- > > I was thinking about the order of the commands in the global parts in the man > page, seems not totally but somewhat random, but that does not concern this > patch. Otherwise for all the doc patches: > > Acked-by: Bence Ferdinandy <bence@ferdinandy.com>
From Robin Jarry to ~rjarry/aerc-devel
Vitaly Ovchinnikov, Sep 19, 2023 at 23:04: > > Patch 3/3 also contains a revert of the aforementioned patch since > > colors/style now allow differentiating MIME types from filenames without > > any alignment. > > It looks like I missed the discussion part, so here's my 2c. Although I > like the new styling options, the patch needs some extra touches. Sorry, maybe I applied it too quickly. I was expecting some reaction from you :) > Here's an example of what I used to have before for a particular > parts-filled message: > =========================================================================
From Robin Jarry to ~rjarry/aerc-devel
Moritz Poldrack, Sep 19, 2023 at 18:23: > On Sun Aug 27, 2023 at 6:59 PM CEST, Robin Jarry wrote: > > Use similar writing mood than other versions. > > * as other versions. > > > > > Signed-off-by: Robin Jarry <robin@jarry.cc> > > --- > > We should clarify what kind of style we want in the change log. This is > > not the same as git commit messages. > > > > CHANGELOG.md | 28 +++++++++++++--------------- > > doc/aerc.1.scd | 2 +-
From Robin Jarry to ~rjarry/aerc-devel
Moritz Poldrack, Sep 19, 2023 at 18:08:
> Acked-by: Moritz Poldrack <moritz@poldrack.dev>
Applied. Thanks!
From Robin Jarry to ~rjarry/aerc-devel
Vitaly Ovchinnikov, Sep 19, 2023 at 18:06: > > did you test this on macos? > > Never tried applying a patch before, sorry :) > > Got this one a try and can confirm that the current master without the > patch fails `go test ./...` and the patched version passes it. > > Tested-by: Vitaly Ovchinnikov <v@postbox.nz> > > Is the above line correct? Yes, perfect :)
From Robin Jarry to ~rjarry/aerc-devel
Vitaly Ovchinnikov, Sep 19, 2023 at 18:56: > OK, so I had a bit of trying with this idea, and it sort of works, but > not for everything. Simple things like `:pipe | sort | less` work, but > something more complex doesn't. Here's an example: > > :pipe tr "\n" "!" | less > > The problem is that the initial command parser transforms this into: > > args := []string { > "pipe", > "tr", > "n", // !! > "!", // !
From Robin Jarry to ~rjarry/aerc-devel
Robin Jarry, Aug 29, 2023 at 09:47: > When any XDG_*_HOME or XDG_RUNTIME_DIR variables are set, this causes > test failures. > > FAIL: TestConfigPath//home/user/Library/Preferences/aerc/accounts.conf (0.00s) > xdg_test.go:86: got "/Users/vitaly/.config/aerc/accounts.conf" > expected "/home/user/Library/Preferences/aerc/accounts.conf" > > Avoid leaking the local user's environment in the unit tests. Always > override the XDG_* variables. > > Fixes: fff16640ad7c ("xdg: add functions to deal with user home paths") > Reported-by: Vitaly Ovchinnikov <v@postbox.nz> > Signed-off-by: Robin Jarry <robin@jarry.cc>
From Robin Jarry to ~rjarry/aerc-devel
inwit, Sep 19, 2023 at 16:22: > Beautiful! > > Tested-By: inwit <inwit@sindominio.net> Applied. Thanks!
From Robin Jarry to ~rjarry/aerc-devel
inwit, Sep 19, 2023 at 16:28: > Works as advertised. > > Tested-By: inwit <inwit@sindominio.net> Applied. Thanks!