~rjarry/aerc-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
4 3

[PATCH aerc] Fix a typo in the doc.

Details
Message ID
<20220123122502.1278628-1-inwit@sindominio.net>
DKIM signature
pass
Download raw message
Patch: +2 -2
---
 README.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index 71f382c..338d9c2 100644
--- a/README.md
+++ b/README.md
@@ -105,12 +105,12 @@ defaults:

And send the patch to the mailing list:

    $ git sendemail --annotate -1
    $ git send-email --annotate -1

Wait for feedback. Address comments and amend changes to your original commit.
Then you should send a v2:

    $ git sendemail --in-reply-to=$first_message_id --annotate -v2 -1
    $ git send-email --in-reply-to=$first_message_id --annotate -v2 -1

Once the maintainer is happy with your patch, they will apply it and push it.

-- 
2.32.0

[aerc/patches] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CHD1YK4NOTBS.3N6USSYS55BGK@cirno>
In-Reply-To
<20220123122502.1278628-1-inwit@sindominio.net> (view parent)
DKIM signature
missing
Download raw message
aerc/patches: SUCCESS in 3m40s

[Fix a typo in the doc.][0] from [inwit][1]

[0]: https://lists.sr.ht/~rjarry/aerc-devel/patches/28633
[1]: inwit@sindominio.net

✓ #678869 SUCCESS aerc/patches/alpine-edge.yml   https://builds.sr.ht/~rjarry/job/678869
✓ #678871 SUCCESS aerc/patches/debian-stable.yml https://builds.sr.ht/~rjarry/job/678871
✓ #678870 SUCCESS aerc/patches/archlinux.yml     https://builds.sr.ht/~rjarry/job/678870
✓ #678872 SUCCESS aerc/patches/fedora-latest.yml https://builds.sr.ht/~rjarry/job/678872
Details
Message ID
<CHDRG6O0RNHV.12OD7D60HXUAF@diabtop>
In-Reply-To
<20220123122502.1278628-1-inwit@sindominio.net> (view parent)
DKIM signature
missing
Download raw message
Hi,

inwit, Jan 23, 2022 at 13:25:
> ---
>  README.md | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Could you write a small explanation in the message body. Also, I would
prefer that the title has a prefix and that you add a Fixes trailer
referencing the commit that introduced the typo. Something like:

  readme: fix typo in contribution guide

  git: 'sendemail' is not a git command. See 'git --help'.

  The most similar command is
          send-email

  Fixes: b84374a572b4 ("readme: add contribution guide")
  Signed-off-by: inwit <inwit@sindominio.net>

Thanks!

[PATCH aerc v2] readme: fix typo in contribution guide

Details
Message ID
<20220124084450.3364794-1-inwit@sindominio.net>
In-Reply-To
<20220123122502.1278628-1-inwit@sindominio.net> (view parent)
DKIM signature
pass
Download raw message
Patch: +2 -2
git: 'sendemail' is not a git command. See 'git --help'.

The most similar command is
        send-email

Fixes: b84374a572b4 ("readme: add contribution guide")
Signed-off-by: inwit <inwit@sindominio.net>
---
 README.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index 71f382c..338d9c2 100644
--- a/README.md
+++ b/README.md
@@ -105,12 +105,12 @@ defaults:

And send the patch to the mailing list:

    $ git sendemail --annotate -1
    $ git send-email --annotate -1

Wait for feedback. Address comments and amend changes to your original commit.
Then you should send a v2:

    $ git sendemail --in-reply-to=$first_message_id --annotate -v2 -1
    $ git send-email --in-reply-to=$first_message_id --annotate -v2 -1

Once the maintainer is happy with your patch, they will apply it and push it.

-- 
2.32.0

Re: [PATCH aerc v2] readme: fix typo in contribution guide

Details
Message ID
<CHDRWHDKHDT0.1U07XY4I2HHL8@diabtop>
In-Reply-To
<20220124084450.3364794-1-inwit@sindominio.net> (view parent)
DKIM signature
missing
Download raw message
inwit, Jan 24, 2022 at 09:44:
> git: 'sendemail' is not a git command. See 'git --help'.
>
> The most similar command is
>         send-email
>
> Fixes: b84374a572b4 ("readme: add contribution guide")
> Signed-off-by: inwit <inwit@sindominio.net>

To git.sr.ht:~rjarry/aerc
   e58194c7b515..50b0436510b0  master -> master

Thanks!
Reply to thread Export thread (mbox)