~rjarry/aerc-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
5 4

[PATCH] edit: add a warning for the setup crash

Details
Message ID
<20220505154554.169946-1-antoine@quaternum.net>
DKIM signature
missing
Download raw message
Patch: +2 -0
---
 README.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/README.md b/README.md
index 06db966..1d51465 100644
--- a/README.md
+++ b/README.md
@@ -100,6 +100,8 @@ This will install templates and other config files to `/custom/location/share/ae
and man pages to `/custom/location/share/man`. This extra location will have lower
priority than the XDG locations but higher than the fixed paths.

Be careful, during the setup aerc will crash if the terminal window is not large enough.

## Contribution Quick Start

Anyone can contribute to aerc. First you need to clone the repository and build
-- 
2.25.1
Details
Message ID
<CJRYCWHCW9CP.280PF83OVAWRF@Archetype>
In-Reply-To
<20220505154554.169946-1-antoine@quaternum.net> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
On Thu May 5, 2022 at 5:45 PM CEST, antoinentl wrote:
> ---
>  README.md | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/README.md b/README.md
> index 06db966..1d51465 100644
> --- a/README.md
> +++ b/README.md
> @@ -100,6 +100,8 @@ This will install templates and other config files to `/custom/location/share/ae
>  and man pages to `/custom/location/share/man`. This extra location will have lower
>  priority than the XDG locations but higher than the fixed paths.
>
> +Be careful, during the setup aerc will crash if the terminal window is not large enough.

It would be great if you could quantify "not large enough".

> +
>  ## Contribution Quick Start
>
>  Anyone can contribute to aerc. First you need to clone the repository and build
> --
> 2.25.1
Details
Message ID
<CJRYFQTJJ35Y.3A0QVDSSPJJ2E@Archetype>
In-Reply-To
<CJRYCWHCW9CP.280PF83OVAWRF@Archetype> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
On Thu May 5, 2022 at 6:01 PM CEST, Moritz Poldrack wrote:
> On Thu May 5, 2022 at 5:45 PM CEST, antoinentl wrote:
> > ---
> >  README.md | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/README.md b/README.md
> > index 06db966..1d51465 100644
> > --- a/README.md
> > +++ b/README.md
> > @@ -100,6 +100,8 @@ This will install templates and other config files to `/custom/location/share/ae
> >  and man pages to `/custom/location/share/man`. This extra location will have lower
> >  priority than the XDG locations but higher than the fixed paths.
> >
> > +Be careful, during the setup aerc will crash if the terminal window is not large enough.
>
> It would be great if you could quantify "not large enough".

$ stty size < /dev/tty | cut -d " " -f 2
gives you the number of columns

>
> > +
> >  ## Contribution Quick Start
> >
> >  Anyone can contribute to aerc. First you need to clone the repository and build
> > --
> > 2.25.1
Details
Message ID
<CJRYG4HXG8M0.1XFZVKMW945YE@marty>
In-Reply-To
<20220505154554.169946-1-antoine@quaternum.net> (view parent)
DKIM signature
missing
Download raw message
antoinentl, May 05, 2022 at 17:45:
> ---
>  README.md | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/README.md b/README.md
> index 06db966..1d51465 100644
> --- a/README.md
> +++ b/README.md
> @@ -100,6 +100,8 @@ This will install templates and other config files to `/custom/location/share/ae
>  and man pages to `/custom/location/share/man`. This extra location will have lower
>  priority than the XDG locations but higher than the fixed paths.
>  
> +Be careful, during the setup aerc will crash if the terminal window is not large enough.
> +

Hi,

I assume you are referring to this:

https://lists.sr.ht/~rjarry/aerc-devel/%3C3C0445YFB4K4X.33HV0Q07DOX4R%40venera%3E

I will not accept such a patch. If there is a bug, it should be fixed.
A README file is not a place for such things, a bug tracker is.

In the meantime, Omar, can you create a ticket with all details that you
included in your email? https://todo.sr.ht/~rjarry/aerc

Thanks!
Details
Message ID
<CJRYKTMUC937.1LRDQV16CQQYK@crcen-thinkpad-x13>
In-Reply-To
<CJRYG4HXG8M0.1XFZVKMW945YE@marty> (view parent)
DKIM signature
missing
Download raw message
On Thu May 5, 2022 at 6:05 PM CEST, Robin Jarry wrote:
> Hi,
>
> I assume you are referring to this:
>
> https://lists.sr.ht/~rjarry/aerc-devel/%3C3C0445YFB4K4X.33HV0Q07DOX4R%40venera%3E
>
> I will not accept such a patch. If there is a bug, it should be fixed.
> A README file is not a place for such things, a bug tracker is.
>
> In the meantime, Omar, can you create a ticket with all details that you
> included in your email? https://todo.sr.ht/~rjarry/aerc
>
> Thanks!

Yes I refer to this message and another[1].
And I agree that it's a bug, my patch can be forgotten :)

[1] https://lists.sr.ht/~rjarry/aerc-devel/%3C1db09ffa-43b0-3367-5bd9-6abb1273603c%40quaternum.net%3E
Omar Polo <op@omarpolo.com>
Details
Message ID
<2T8HGVEEBYJ2J.2ORY3DBZNXFKZ@venera>
In-Reply-To
<CJRYG4HXG8M0.1XFZVKMW945YE@marty> (view parent)
DKIM signature
pass
Download raw message
"Robin Jarry" <robin@jarry.cc> wrote:

> In the meantime, Omar, can you create a ticket with all details that you
> included in your email? https://todo.sr.ht/~rjarry/aerc

ticket created :)

https://todo.sr.ht/~rjarry/aerc/41

Thanks!
Reply to thread Export thread (mbox)